mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 15:08:10 +00:00
Chandler Carruth
d0badecd2a
Historically, we disabled the rendered form in tests outside of `toolchain/diagnostics`. The idea was to keep tests shorter and avoid very long chains of autoupdate before stabilizing due to all the line numbers and other artifacts in the rendered form. This PR adds `--diagnostic-line-numbers=[all|first]` and defaults to `first` in tests. This keeps the rendered form so that we can easily code review that form and the visual cues it does or doesn't provide. But it removes all but the first location's line numbers to provide significantly more stability in tests. By default, tests get the full unicode line-drawing form of diagnostics so we can ensure all of the artifacts there make sense with the specific case being diagnosed, but we do retain some focused ASCII-rendering tests to ensure that fallback remains usable. There are some issues here that will be fixed in subsequent PRs. Notably, we try to keep the frame together in the check lines, and so force some parts to use the first location. This largely works, but fails in some edge cases, causing the entire frame to be located incorrectly. There is a TODO about this that we need to fix, and it only occurs 6 times across the test suite, so it didn't seem worth front-loading a fix for here. Assisted-by: Claude Code
294 lines
12 KiB
Plaintext
294 lines
12 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/int.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interop/cpp/class/export/base.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interop/cpp/class/export/base.carbon
|
|
|
|
// --- derived_to_base.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
base class A {}
|
|
|
|
class B {
|
|
extend base: A;
|
|
}
|
|
|
|
inline Cpp '''
|
|
Carbon::A* Convert(Carbon::B* p) {
|
|
return p;
|
|
}
|
|
''';
|
|
|
|
// --- name_lookup.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
base class LookupBase {
|
|
fn F();
|
|
fn G(n: i32);
|
|
}
|
|
|
|
class LookupDerived {
|
|
extend base: LookupBase;
|
|
fn G();
|
|
}
|
|
|
|
inline Cpp '''
|
|
void Qualified() {
|
|
Carbon::LookupDerived::F();
|
|
Carbon::LookupDerived::G();
|
|
}
|
|
|
|
void MemberAccess(Carbon::LookupBase *a, Carbon::LookupDerived *b) {
|
|
b->F();
|
|
b->G();
|
|
}
|
|
''';
|
|
|
|
// --- fail_derive_from_final.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
class FinalClass {}
|
|
|
|
inline Cpp '''
|
|
// CHECK:STDERR: ╭─┤ fail_derive_from_final.carbon:[[@LINE+11]]:12
|
|
// CHECK:STDERR: │ class FinalClass {}
|
|
// CHECK:STDERR: · ┬
|
|
// CHECK:STDERR: · ╰──┤ 'FinalClass' declared here [CppInteropParseNote]
|
|
// CHECK:STDERR: ┆
|
|
// CHECK:STDERR: -> │ struct A : Carbon::FinalClass {};
|
|
// CHECK:STDERR: · ┳
|
|
// CHECK:STDERR: · ┗━━┫ error: base 'FinalClass' is marked 'final'
|
|
// CHECK:STDERR: · ┃ [CppInteropParseError]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
struct A : Carbon::FinalClass {};
|
|
''';
|
|
|
|
// --- fail_abstract.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: Add a way to give a class a virtual destructor without C++ interop.
|
|
inline Cpp '''
|
|
struct VirtualDestructor {
|
|
virtual ~VirtualDestructor() {}
|
|
};
|
|
''';
|
|
|
|
// CHECK:STDERR: ╭─┤ fail_abstract.carbon:[[@LINE+14]]:1
|
|
// CHECK:STDERR: -> │ abstract class AbstractWithVdtor {
|
|
// CHECK:STDERR: · ┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
// CHECK:STDERR: · ┗━━┫ error: cannot convert type `AbstractWithVdtor` into type implementing
|
|
// CHECK:STDERR: · ┃ `Core.Destroy`
|
|
// CHECK:STDERR: · ┃ [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: ┆
|
|
// CHECK:STDERR: ├─┤ min_prelude/parts/destroy.carbon
|
|
// CHECK:STDERR: │ fn SelfDestruct[T: Destroy](ref t: T) {
|
|
// CHECK:STDERR: · ───────────────────┬───────────────────
|
|
// CHECK:STDERR: · ╰──┤ while deducing parameters of generic declared here
|
|
// CHECK:STDERR: · │ [DeductionGenericHere]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
abstract class AbstractWithVdtor {
|
|
extend base: Cpp.VirtualDestructor;
|
|
}
|
|
|
|
inline Cpp '''
|
|
// CHECK:STDERR: ╭─┤ fail_abstract.carbon:[[@LINE+16]]:27
|
|
// CHECK:STDERR: │ abstract class AbstractWithVdtor {
|
|
// CHECK:STDERR: · ┬
|
|
// CHECK:STDERR: · ╰──┤ unimplemented pure virtual method
|
|
// CHECK:STDERR: · │ '~AbstractWithVdtor' in
|
|
// CHECK:STDERR: · │ 'AbstractWithVdtor'
|
|
// CHECK:STDERR: · │ [CppInteropParseNote]
|
|
// CHECK:STDERR: ┆
|
|
// CHECK:STDERR: -> │ Carbon::AbstractWithVdtor x;
|
|
// CHECK:STDERR: · ┳
|
|
// CHECK:STDERR: · ┗━━┫ error: variable type 'Carbon::AbstractWithVdtor'
|
|
// CHECK:STDERR: · ┃ (aka 'Carbon::Main::AbstractWithVdtor') is
|
|
// CHECK:STDERR: · ┃ an abstract class
|
|
// CHECK:STDERR: · ┃ [CppInteropParseError]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
Carbon::AbstractWithVdtor x;
|
|
''';
|
|
|
|
// --- fail_todo_abstract_nonvirtual_dtor.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: Find a way to export this to C++ as an abstract class, despite not
|
|
// having a vptr.
|
|
// CHECK:STDERR: ╭─┤ fail_todo_abstract_nonvirtual_dtor.carbon:[[@LINE+23]]:1
|
|
// CHECK:STDERR: -> │ abstract class AbstractNonvirtualDtor {}
|
|
// CHECK:STDERR: · ━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━
|
|
// CHECK:STDERR: · ┏━━━━━━━━━━━━━━━━━━┛
|
|
// CHECK:STDERR: · ┃ error: semantics TODO:
|
|
// CHECK:STDERR: · ┃ `exporting abstract class with no abstract methods and non-virtual destructor to C++`
|
|
// CHECK:STDERR: · ┃ [SemanticsTodo]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: ╭─┤ fail_todo_abstract_nonvirtual_dtor.carbon:[[@LINE+14]]:1
|
|
// CHECK:STDERR: -> │ abstract class AbstractNonvirtualDtor {}
|
|
// CHECK:STDERR: · ┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
// CHECK:STDERR: · ┗━━┫ error: cannot convert type `AbstractNonvirtualDtor` into type implementing
|
|
// CHECK:STDERR: · ┃ `Core.Destroy`
|
|
// CHECK:STDERR: · ┃ [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: ┆
|
|
// CHECK:STDERR: ├─┤ min_prelude/parts/destroy.carbon
|
|
// CHECK:STDERR: │ fn SelfDestruct[T: Destroy](ref t: T) {
|
|
// CHECK:STDERR: · ───────────────────┬───────────────────
|
|
// CHECK:STDERR: · ╰──┤ while deducing parameters of generic declared here
|
|
// CHECK:STDERR: · │ [DeductionGenericHere]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
abstract class AbstractNonvirtualDtor {}
|
|
|
|
inline Cpp '''
|
|
class DerivedNonvirtualDtor : public Carbon::AbstractNonvirtualDtor {};
|
|
''';
|
|
|
|
// --- fail_todo_abstract_nonvirtual_dtor_but_virtual_fns.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: We should support generating a base subobject destructor for an
|
|
// abstract class, even though we refuse to generate a complete object
|
|
// destructor.
|
|
// CHECK:STDERR: ╭─┤ fail_todo_abstract_nonvirtual_dtor_but_virtual_fns.carbon:[[@LINE+14]]:1
|
|
// CHECK:STDERR: -> │ abstract class AbstractWithMethodNoVptr {
|
|
// CHECK:STDERR: · ┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
// CHECK:STDERR: · ┗━━┫ error: cannot convert type `AbstractWithMethodNoVptr` into type
|
|
// CHECK:STDERR: · ┃ implementing `Core.Destroy`
|
|
// CHECK:STDERR: · ┃ [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: ┆
|
|
// CHECK:STDERR: ├─┤ min_prelude/parts/destroy.carbon
|
|
// CHECK:STDERR: │ fn SelfDestruct[T: Destroy](ref t: T) {
|
|
// CHECK:STDERR: · ───────────────────┬───────────────────
|
|
// CHECK:STDERR: · ╰──┤ while deducing parameters of generic declared here
|
|
// CHECK:STDERR: · │ [DeductionGenericHere]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
abstract class AbstractWithMethodNoVptr {
|
|
abstract fn F(self);
|
|
}
|
|
|
|
inline Cpp '''
|
|
class DerivedWithMethodNoVptr : public Carbon::AbstractWithMethodNoVptr {
|
|
};
|
|
''';
|
|
|
|
// --- fail_variable_with_abstract_method.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: We should support generating a base subobject destructor for an
|
|
// abstract class, even though we refuse to generate a complete object
|
|
// destructor.
|
|
// CHECK:STDERR: ╭─┤ fail_variable_with_abstract_method.carbon:[[@LINE+14]]:1
|
|
// CHECK:STDERR: -> │ abstract class AbstractWithMethod {
|
|
// CHECK:STDERR: · ┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
// CHECK:STDERR: · ┗━━┫ error: cannot convert type `AbstractWithMethod` into type implementing
|
|
// CHECK:STDERR: · ┃ `Core.Destroy`
|
|
// CHECK:STDERR: · ┃ [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: ┆
|
|
// CHECK:STDERR: ├─┤ min_prelude/parts/destroy.carbon
|
|
// CHECK:STDERR: │ fn SelfDestruct[T: Destroy](ref t: T) {
|
|
// CHECK:STDERR: · ───────────────────┬───────────────────
|
|
// CHECK:STDERR: · ╰──┤ while deducing parameters of generic declared here
|
|
// CHECK:STDERR: · │ [DeductionGenericHere]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
abstract class AbstractWithMethod {
|
|
abstract fn F(self);
|
|
}
|
|
|
|
inline Cpp '''
|
|
// CHECK:STDERR: ╭─┤ fail_variable_with_abstract_method.carbon:[[@LINE+16]]:28
|
|
// CHECK:STDERR: │ abstract fn F(self);
|
|
// CHECK:STDERR: · ┬
|
|
// CHECK:STDERR: · ╰──┤ unimplemented pure virtual method 'F' in
|
|
// CHECK:STDERR: · │ 'AbstractWithMethod'
|
|
// CHECK:STDERR: · │ [CppInteropParseNote]
|
|
// CHECK:STDERR: ┆
|
|
// CHECK:STDERR: -> │ Carbon::AbstractWithMethod x_abstract;
|
|
// CHECK:STDERR: · ┳
|
|
// CHECK:STDERR: · ┗━━┫ error: variable type
|
|
// CHECK:STDERR: · ┃ 'Carbon::AbstractWithMethod' (aka
|
|
// CHECK:STDERR: · ┃ 'Carbon::Main::AbstractWithMethod') is an
|
|
// CHECK:STDERR: · ┃ abstract class
|
|
// CHECK:STDERR: · ┃ [CppInteropParseError]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
Carbon::AbstractWithMethod x_abstract;
|
|
''';
|
|
|
|
// --- fail_todo_abstract_method_overridden_in_cpp.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: We should support generating a base subobject destructor for an
|
|
// abstract class, even though we refuse to generate a complete object
|
|
// destructor.
|
|
// CHECK:STDERR: ╭─┤ fail_todo_abstract_method_overridden_in_cpp.carbon:[[@LINE+14]]:1
|
|
// CHECK:STDERR: -> │ abstract class AbstractToOverride {
|
|
// CHECK:STDERR: · ┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
// CHECK:STDERR: · ┗━━┫ error: cannot convert type `AbstractToOverride` into type implementing
|
|
// CHECK:STDERR: · ┃ `Core.Destroy`
|
|
// CHECK:STDERR: · ┃ [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: ┆
|
|
// CHECK:STDERR: ├─┤ min_prelude/parts/destroy.carbon
|
|
// CHECK:STDERR: │ fn SelfDestruct[T: Destroy](ref t: T) {
|
|
// CHECK:STDERR: · ───────────────────┬───────────────────
|
|
// CHECK:STDERR: · ╰──┤ while deducing parameters of generic declared here
|
|
// CHECK:STDERR: · │ [DeductionGenericHere]
|
|
// CHECK:STDERR: ╰────
|
|
// CHECK:STDERR:
|
|
abstract class AbstractToOverride {
|
|
abstract fn F(ref self);
|
|
}
|
|
|
|
// A C++ class that overrides the abstract method can be instantiated.
|
|
inline Cpp '''
|
|
struct DerivedOverriding : Carbon::AbstractToOverride {
|
|
void F() & override {}
|
|
};
|
|
DerivedOverriding d;
|
|
''';
|
|
|
|
// --- override_virtual_dtor.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
inline Cpp '''
|
|
struct BaseWithPureVdtor {
|
|
virtual ~BaseWithPureVdtor() = 0;
|
|
};
|
|
''';
|
|
|
|
class DerivedWithVdtor {
|
|
extend base: Cpp.BaseWithPureVdtor;
|
|
}
|
|
|
|
inline Cpp '''
|
|
Carbon::DerivedWithVdtor b;
|
|
''';
|