mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 19:50:14 +01:00
Replaces the callback-based `ForEach` methods on `RawHashtable`, `Map`,
and
`Set` with a range object supporting range-for loops, structured
bindings, and
the standard range concepts.
- Adds `.entries()` on `Map`, `Set`, and `RawHashtable`, returning a
range that
models `std::ranges::forward_range` and `std::ranges::common_range`.
Obtaining one is an explicit call rather than `begin()`/`end()` on the
container, as scanning a whole table is costly and shouldn't be hidden.
- Iterating a `Map` yields a `std::pair` of key and value references,
which
fits in two registers and is returned without being materialized in
memory.
- `Map::Range` and `Set::Range` are aliases of the raw hashtable's range
rather
than wrappers around it. The raw iterator produces the user-facing
reference
itself -- a `KeyT&` for a set, a pair of references for a map -- picked
by
`StorageEntry`, which is already specialized on whether there is a value
type. That leaves one iterator to reason about instead of three.
- Deletes the rvalue `.entries()` overloads on the owning containers, as
a
range built from a temporary table would dangle. Views don't own their
storage, so the operation remains available on them.
- In release builds, the walk over the groups is a single induction
variable: a
negative byte offset counting up to zero, anchored at the ends of the
metadata and entry arrays. Both arrays are then reached by indexed
addressing
off a base that stays put, and the entry pointer is formed only once a
group
with a present entry has been found.
- In debug builds, the range hashes the table's metadata when it is
built and
re-checks that hash when it is destroyed, catching mutation of the table
while a range is live. It also picks a random starting group and a
random odd
group stride, which varies the traversal order between ranges while
still
visiting every group exactly once. That entropy is drawn when the range
is
built rather than in `begin()`, so `begin()` stays a pure function of
the
range and the multi-pass guarantee holds.
- Removes `ForEachEntry` and all of its callers.
Measured against the iteration benchmark added in its own commit, a
traversal is at or ahead of what the callback compiled to across nearly
the
whole size range. The largest tables spend 3-5% fewer cycles, small
`Set`s as
much as 24% fewer, and instruction counts stay within about 1%. What
remains
behind is a handful of mid-sized `Map`s by up to 1%, and `Set` at 65536,
which
sits at exactly half its load factor, by 2%.
Both revisions were built with `-c opt --copt=-march=x86-64-v3` and
compared
with:
```
./scripts/bench_runner.py --exp_benchmark=... --base_benchmark=... \
--benchmark_args=--benchmark_perf_counters=INSTRUCTIONS,CYCLES \
--benchmark_args='--benchmark_filter=(Set|Map)Iterate<(Set|Map)<' \
--extra_metrics_filter='(INSTRUCTIONS|CYCLES)'
```
Trimmed below to the primary integer configurations and to the two
counters;
the pointer- and string-keyed configurations follow the same pattern.
```
Benchmark ┃ CYCLES ┃ INSTRUCTIONS
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
BM_MapIterate<Map<int, int>>/1....... │ 👍 -6.032% p=1.14e-05 │ ?? p=0.752
baseline: │ 12.06 ± 1.520% │ 64 ± 3.125%
experiment: │ 11.33 ± 2.765% │ 65.5 ± 3.817%
│ │
BM_MapIterate<Map<int, int>>/2....... │ ?? p=0.155 │ ?? p=0.343
baseline: │ 7.587 ± 1.285% │ 41 ± 0.000%
experiment: │ 7.652 ± 0.865% │ 41 ± 2.439%
│ │
BM_MapIterate<Map<int, int>>/3....... │ ?? p=0.343 │ 👍 -1.020% p=0.0039
baseline: │ 6.663 ± 4.260% │ 32.67 ± 2.041%
experiment: │ 6.368 ± 12.224% │ 32.33 ± 2.062%
│ │
BM_MapIterate<Map<int, int>>/4....... │ ?? p=0.343 │ 👍 -1.786% p=0.0297
baseline: │ 6.091 ± 15.470% │ 28 ± 3.571%
experiment: │ 5.957 ± 8.932% │ 27.5 ± 3.636%
│ │
BM_MapIterate<Map<int, int>>/8....... │ ?? p=0.323 │ 👍 -1.220% p=0.000148
baseline: │ 4.845 ± 0.800% │ 20.5 ± 0.000%
experiment: │ 4.814 ± 3.585% │ 20.25 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/16...... │ 👍 -2.195% p=0.00908 │ 👍 0.769% p=6.58e-06
baseline: │ 4.312 ± 0.187% │ 16.25 ± 0.000%
experiment: │ 4.218 ± 2.368% │ 16.13 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/32...... │ ?? p=0.236 │ 👍 0.442% p=9.53e-06
baseline: │ 4.051 ± 1.084% │ 14.13 ± 0.000%
experiment: │ 4.063 ± 0.737% │ 14.06 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/64...... │ ?? p=0.693 │ 👎 0.227% p=4.52e-06
baseline: │ 4.021 ± 0.239% │ 13.75 ± 0.000%
experiment: │ 4.019 ± 0.417% │ 13.78 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/256..... │ 👍 0.360% p=0.00119 │ 👎 0.754% p=1.37e-05
baseline: │ 3.996 ± 0.173% │ 13.47 ± 0.000%
experiment: │ 3.982 ± 0.272% │ 13.57 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/4096.... │ 👍 0.581% p=1.96e-05 │ 👎 0.923% p=1.96e-05
baseline: │ 4.005 ± 0.816% │ 13.38 ± 0.000%
experiment: │ 3.981 ± 0.192% │ 13.5 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/65536... │ 👍 -4.957% p=1.14e-05 │ 👎 0.934% p=1.14e-05
baseline: │ 5.307 ± 0.501% │ 13.38 ± 0.000%
experiment: │ 5.044 ± 1.746% │ 13.5 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/1048576. │ 👍 -3.947% p=9.09e-05 │ 👎 0.935% p=3.3e-05
baseline: │ 6.074 ± 0.807% │ 13.38 ± 0.000%
experiment: │ 5.834 ± 2.159% │ 13.5 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/16777216 │ ?? p=0.155 │ 👎 0.935% p=2.11e-05
baseline: │ 5.082 ± 3.650% │ 13.38 ± 0.000%
experiment: │ 5.012 ± 1.316% │ 13.5 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/56...... │ 👎 0.825% p=0.0268 │ 👍 0.270% p=1.14e-05
baseline: │ 3.918 ± 0.501% │ 13.21 ± 0.000%
experiment: │ 3.951 ± 0.342% │ 13.18 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/224..... │ 👎 0.788% p=0.000504 │ 👎 0.346% p=1.64e-05
baseline: │ 3.895 ± 0.111% │ 12.89 ± 0.000%
experiment: │ 3.926 ± 0.285% │ 12.94 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/3584.... │ 👎 1.028% p=0.000148 │ 👎 0.545% p=1.14e-05
baseline: │ 3.913 ± 0.427% │ 12.79 ± 0.000%
experiment: │ 3.954 ± 0.325% │ 12.86 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/57344... │ ?? p=0.236 │ 👎 0.558% p=2.55e-06
baseline: │ 4.574 ± 0.721% │ 12.79 ± 0.000%
experiment: │ 4.51 ± 3.709% │ 12.86 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/917504.. │ 👍 -3.826% p=6.58e-06 │ 👎 0.559% p=2.33e-05
baseline: │ 5.221 ± 0.507% │ 12.79 ± 0.000%
experiment: │ 5.021 ± 0.556% │ 12.86 ± 0.000%
│ │
BM_MapIterate<Map<int, int>>/14680064 │ 👍 -3.839% p=1.37e-05 │ 👎 0.559% p=3.31e-05
baseline: │ 5.129 ± 1.194% │ 12.79 ± 0.000%
experiment: │ 4.932 ± 1.475% │ 12.86 ± 0.000%
│ │
Benchmark ┃ CYCLES ┃ INSTRUCTIONS
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
BM_SetIterate<Set<int>>/1....... │ 👍 -3.104% p=0.000583 │ ?? p=0.206
baseline: │ 11.2 ± 6.323% │ 60 ± 3.333%
experiment: │ 10.85 ± 5.820% │ 61 ± 3.279%
│ │
BM_SetIterate<Set<int>>/2....... │ 👍 -7.037% p=0.0362 │ ?? p=0.155
baseline: │ 7.086 ± 16.857% │ 37 ± 0.000%
experiment: │ 6.587 ± 0.479% │ 36 ± 4.167%
│ │
BM_SetIterate<Set<int>>/3....... │ 👎 1.400% p=2.34e-05 │ 👍 -1.163% p=0.00136
baseline: │ 5.363 ± 0.463% │ 28.67 ± 2.326%
experiment: │ 5.438 ± 32.763% │ 28.33 ± 1.176%
│ │
BM_SetIterate<Set<int>>/4....... │ ?? p=0.968 │ ?? p=0.286
baseline: │ 4.642 ± 32.751% │ 23.5 ± 2.128%
experiment: │ 4.658 ± 38.416% │ 23.63 ± 3.704%
│ │
BM_SetIterate<Set<int>>/8....... │ 👍 -23.823% p=3.74e-06 │ 👍 -1.515% p=5.52e-05
baseline: │ 4.701 ± 6.589% │ 16.5 ± 0.000%
experiment: │ 3.581 ± 7.790% │ 16.25 ± 0.000%
│ │
BM_SetIterate<Set<int>>/16...... │ 👍 -4.502% p=1.37e-05 │ 👍 -1.020% p=3.31e-05
baseline: │ 3.124 ± 0.585% │ 12.25 ± 0.000%
experiment: │ 2.983 ± 0.625% │ 12.13 ± 0.000%
│ │
BM_SetIterate<Set<int>>/32...... │ 👍 -4.032% p=5.46e-06 │ 👍 0.617% p=1.96e-05
baseline: │ 2.957 ± 0.260% │ 10.13 ± 0.000%
experiment: │ 2.838 ± 0.434% │ 10.06 ± 0.000%
│ │
BM_SetIterate<Set<int>>/64...... │ 👍 -5.054% p=4.52e-06 │ 👎 0.321% p=1.37e-05
baseline: │ 2.937 ± 0.301% │ 9.75 ± 0.000%
experiment: │ 2.788 ± 1.143% │ 9.781 ± 0.000%
│ │
BM_SetIterate<Set<int>>/256..... │ 👍 -5.325% p=1.14e-05 │ 👎 1.073% p=6.58e-06
baseline: │ 2.916 ± 0.220% │ 9.469 ± 0.000%
experiment: │ 2.761 ± 0.142% │ 9.57 ± 0.000%
│ │
BM_SetIterate<Set<int>>/4096.... │ 👍 -4.865% p=4.52e-06 │ 👎 1.317% p=2.34e-05
baseline: │ 2.921 ± 0.194% │ 9.381 ± 0.000%
experiment: │ 2.779 ± 0.224% │ 9.504 ± 0.000%
│ │
BM_SetIterate<Set<int>>/65536... │ 👎 1.961% p=3.93e-05 │ 👎 1.332% p=1.49e-05
baseline: │ 4.015 ± 0.482% │ 9.375 ± 0.000%
experiment: │ 4.094 ± 0.613% │ 9.5 ± 0.000%
│ │
BM_SetIterate<Set<int>>/1048576. │ 👍 -4.843% p=1.14e-05 │ 👎 1.333% p=5.38e-06
baseline: │ 5.239 ± 0.144% │ 9.375 ± 0.000%
experiment: │ 4.986 ± 0.139% │ 9.5 ± 0.000%
│ │
BM_SetIterate<Set<int>>/16777216 │ 👍 0.840% p=0.0362 │ 👎 1.333% p=2.52e-06
baseline: │ 3.719 ± 1.420% │ 9.375 ± 0.000%
experiment: │ 3.688 ± 1.308% │ 9.5 ± 0.000%
│ │
BM_SetIterate<Set<int>>/56...... │ 👍 -2.857% p=9.53e-06 │ 👍 0.388% p=3.31e-05
baseline: │ 2.942 ± 0.439% │ 9.214 ± 0.000%
experiment: │ 2.858 ± 0.619% │ 9.179 ± 0.000%
│ │
BM_SetIterate<Set<int>>/224..... │ 👍 -2.161% p=2.34e-05 │ 👎 0.502% p=4.52e-06
baseline: │ 2.888 ± 0.347% │ 8.893 ± 0.000%
experiment: │ 2.826 ± 0.450% │ 8.938 ± 0.000%
│ │
BM_SetIterate<Set<int>>/3584.... │ 👍 -1.750% p=6.58e-06 │ 👎 0.793% p=2.34e-05
baseline: │ 2.89 ± 0.261% │ 8.792 ± 0.000%
experiment: │ 2.84 ± 0.411% │ 8.862 ± 0.000%
│ │
BM_SetIterate<Set<int>>/57344... │ ?? p=0.502 │ 👎 0.812% p=2.78e-05
baseline: │ 3.684 ± 4.246% │ 8.786 ± 0.000%
experiment: │ 3.644 ± 4.431% │ 8.857 ± 0.000%
│ │
BM_SetIterate<Set<int>>/917504.. │ 👍 -2.629% p=0.000148 │ 👎 0.813% p=3.08e-06
baseline: │ 4.372 ± 0.693% │ 8.786 ± 0.000%
experiment: │ 4.257 ± 0.210% │ 8.857 ± 0.000%
│ │
BM_SetIterate<Set<int>>/14680064 │ 👍 -2.927% p=0.0219 │ 👎 0.813% p=3.03e-06
baseline: │ 4.154 ± 3.286% │ 8.786 ± 0.000%
experiment: │ 4.032 ± 3.198% │ 8.857 ± 0.000%
│ │
```
Assisted-by: Antigravity with Opus
426 lines
17 KiB
C++
426 lines
17 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_COMMON_SET_H_
|
|
#define CARBON_COMMON_SET_H_
|
|
|
|
#include <concepts>
|
|
#include <type_traits>
|
|
#include <utility>
|
|
|
|
#include "common/check.h"
|
|
#include "common/hashtable_key_context.h"
|
|
#include "common/raw_hashtable.h"
|
|
#include "llvm/Support/Compiler.h"
|
|
|
|
namespace Carbon {
|
|
|
|
// Forward declarations to resolve cyclic references.
|
|
template <typename KeyT, typename KeyContextT>
|
|
class SetView;
|
|
template <typename KeyT, typename KeyContextT>
|
|
class SetBase;
|
|
template <typename KeyT, ssize_t SmallSize, typename KeyContextT>
|
|
class Set;
|
|
|
|
// A read-only view type for a set of keys.
|
|
//
|
|
// This view is a cheap-to-copy type that should be passed by value, but
|
|
// provides view or read-only reference semantics to the underlying set data
|
|
// structure.
|
|
//
|
|
// This should always be preferred to a `const`-ref parameter for the `SetBase`
|
|
// or `Set` type as it provides more flexibility and a cleaner API. By default
|
|
// a `SetView` provides no more immutability than a `const Set`: elements
|
|
// can't be added or removed, but they can be mutated, and the user is
|
|
// responsible for avoiding mutations that affect the hash value or equality
|
|
// comparison. However, a `SetView<T>` can be converted to a `SetView<const T>`,
|
|
// which prevents mutating the elements. As with any other view type, `const`
|
|
// on the `SetView` itself is "shallow": it prevents rebinding the `SetView` to
|
|
// a different underlying set, but doesn't affect mutability of the underlying
|
|
// set.
|
|
//
|
|
// A specific `KeyContextT` type can optionally be provided to configure how
|
|
// keys will be hashed and compared. The default is `DefaultKeyContext` which is
|
|
// stateless and will hash using `Carbon::HashValue` and compare using
|
|
// `operator==`. Every method accepting a lookup key or operating on the keys in
|
|
// the table will also accept an instance of this type. For stateless context
|
|
// types, including the default, an instance will be default constructed if not
|
|
// provided to these methods. However, stateful contexts should be constructed
|
|
// and passed in explicitly. The context type should be small and reasonable to
|
|
// pass by value, often a wrapper or pointer to the relevant context needed for
|
|
// hashing and comparing keys. For more details about the key context, see
|
|
// `hashtable_key_context.h`.
|
|
template <typename InputKeyT, typename InputKeyContextT = DefaultKeyContext>
|
|
class SetView : RawHashtable::ViewImpl<InputKeyT, void, InputKeyContextT> {
|
|
using ImplT = RawHashtable::ViewImpl<InputKeyT, void, InputKeyContextT>;
|
|
|
|
public:
|
|
using KeyT = ImplT::KeyT;
|
|
using KeyContextT = ImplT::KeyContextT;
|
|
using MetricsT = ImplT::MetricsT;
|
|
|
|
// A range over the keys of the set. Bound to the lifetime of the viewed set,
|
|
// and invalidated by mutating it.
|
|
using Range = ImplT::EntryRange;
|
|
|
|
// This type represents the result of lookup operations. It encodes whether
|
|
// the lookup was a success as well as accessors for the key.
|
|
class LookupResult {
|
|
public:
|
|
LookupResult() = default;
|
|
explicit LookupResult(KeyT& key) : key_(&key) {}
|
|
|
|
explicit operator bool() const { return key_ != nullptr; }
|
|
|
|
auto key() const -> KeyT& { return *key_; }
|
|
|
|
private:
|
|
KeyT* key_ = nullptr;
|
|
};
|
|
|
|
// Enable implicit conversions that add `const`-ness to the key type.
|
|
explicit(false)
|
|
SetView(const SetView<std::remove_const_t<KeyT>, KeyContextT>& other_view)
|
|
requires(!std::same_as<KeyT, std::remove_const_t<KeyT>>)
|
|
: ImplT(other_view) {}
|
|
|
|
// Tests whether a key is present in the set.
|
|
template <typename LookupKeyT>
|
|
auto Contains(LookupKeyT lookup_key,
|
|
KeyContextT key_context = KeyContextT()) const -> bool;
|
|
|
|
// Lookup a key in the set.
|
|
template <typename LookupKeyT>
|
|
auto Lookup(LookupKeyT lookup_key,
|
|
KeyContextT key_context = KeyContextT()) const -> LookupResult;
|
|
|
|
// Returns a range for iterating over all keys in the set.
|
|
auto entries() const -> Range;
|
|
|
|
// This routine is relatively inefficient and only intended for use in
|
|
// benchmarking or logging of performance anomalies. The specific metrics
|
|
// returned have no specific guarantees beyond being informative in
|
|
// benchmarks.
|
|
auto ComputeMetrics(KeyContextT key_context = KeyContextT()) -> MetricsT {
|
|
return ImplT::ComputeMetricsImpl(key_context);
|
|
}
|
|
|
|
private:
|
|
template <typename SetKeyT, ssize_t SmallSize, typename KeyContextT>
|
|
friend class Set;
|
|
friend class SetBase<KeyT, KeyContextT>;
|
|
friend class SetView<const KeyT, KeyContextT>;
|
|
|
|
using EntryT = ImplT::EntryT;
|
|
|
|
SetView() = default;
|
|
explicit(false) SetView(ImplT base) : ImplT(base) {}
|
|
SetView(ssize_t size, RawHashtable::Storage* storage)
|
|
: ImplT(size, storage) {}
|
|
};
|
|
|
|
// A base class for a `Set` type that remains mutable while type-erasing the
|
|
// `SmallSize` (SSO) template parameter.
|
|
//
|
|
// Note that `SetBase` has "shallow" const semantics: a `const SetBase<T>&`
|
|
// can't be used to mutate the set data structure itself (e.g. by changing
|
|
// the number of elements), but it can be used to mutate the `T` elements it
|
|
// contains. The user is responsible for avoiding mutations that would change
|
|
// the hash value or equality of an element. A `SetView<const T>` can be used
|
|
// to provide read-only access to the elements of a `SetBase<T>`.
|
|
//
|
|
// A pointer or reference to this type is the preferred way to pass a mutable
|
|
// handle to a `Set` type across API boundaries as it avoids encoding specific
|
|
// SSO sizing information while providing a near-complete mutable API.
|
|
template <typename InputKeyT, typename InputKeyContextT = DefaultKeyContext>
|
|
class SetBase
|
|
: protected RawHashtable::BaseImpl<InputKeyT, void, InputKeyContextT> {
|
|
protected:
|
|
using ImplT = RawHashtable::BaseImpl<InputKeyT, void, InputKeyContextT>;
|
|
|
|
public:
|
|
using KeyT = ImplT::KeyT;
|
|
using KeyContextT = ImplT::KeyContextT;
|
|
using ViewT = SetView<KeyT, KeyContextT>;
|
|
using LookupResult = ViewT::LookupResult;
|
|
using MetricsT = ImplT::MetricsT;
|
|
using Range = ViewT::Range;
|
|
|
|
// The result type for insertion operations both indicates whether an insert
|
|
// was needed (as opposed to the key already being in the set), and provides
|
|
// access to the key.
|
|
class InsertResult {
|
|
public:
|
|
InsertResult() = default;
|
|
explicit InsertResult(bool inserted, KeyT& key)
|
|
: key_(&key), inserted_(inserted) {}
|
|
|
|
auto is_inserted() const -> bool { return inserted_; }
|
|
|
|
auto key() const -> KeyT& { return *key_; }
|
|
|
|
private:
|
|
KeyT* key_;
|
|
bool inserted_;
|
|
};
|
|
|
|
// Implicitly convertible to the relevant view type.
|
|
//
|
|
// NOLINTNEXTLINE(google-explicit-constructor): Designed to implicitly decay.
|
|
explicit(false) operator ViewT() const { return this->view_impl(); }
|
|
|
|
// We can't chain the above conversion with the conversions on `ViewT` to add
|
|
// const, so explicitly support adding const to produce a view here.
|
|
//
|
|
// NOLINTNEXTLINE(google-explicit-constructor): Designed to implicitly decay.
|
|
explicit(false) operator SetView<const KeyT, KeyContextT>() const {
|
|
return ViewT(*this);
|
|
}
|
|
|
|
// Convenience forwarder to the view type.
|
|
template <typename LookupKeyT>
|
|
auto Contains(LookupKeyT lookup_key,
|
|
KeyContextT key_context = KeyContextT()) const -> bool {
|
|
return ViewT(*this).Contains(lookup_key, key_context);
|
|
}
|
|
|
|
// Convenience forwarder to the view type.
|
|
template <typename LookupKeyT>
|
|
auto Lookup(LookupKeyT lookup_key,
|
|
KeyContextT key_context = KeyContextT()) const -> LookupResult {
|
|
return ViewT(*this).Lookup(lookup_key, key_context);
|
|
}
|
|
|
|
// Convenience forwarder to the view type.
|
|
auto entries() const& -> Range { return ViewT(*this).entries(); }
|
|
// Deleted on rvalues: the range refers to storage owned by this table, so a
|
|
// range built from a temporary set would dangle. Both qualifiers are needed
|
|
// as `&&` alone would leave a const rvalue binding to the `const&` overload.
|
|
auto entries() && = delete;
|
|
auto entries() const&& = delete;
|
|
|
|
// Convenience forwarder to the view type.
|
|
auto ComputeMetrics(KeyContextT key_context = KeyContextT()) const
|
|
-> MetricsT {
|
|
return ViewT(*this).ComputeMetrics(key_context);
|
|
}
|
|
|
|
// Insert a key into the set. If the key is already present, no insertion is
|
|
// performed and that present key is available in the result. Otherwise a new
|
|
// key is inserted and constructed from the argument and available in the
|
|
// result.
|
|
template <typename LookupKeyT>
|
|
auto Insert(LookupKeyT lookup_key, KeyContextT key_context = KeyContextT())
|
|
-> InsertResult;
|
|
|
|
// Insert a key into the set and call the provided callback if necessary to
|
|
// produce a new key when no existing key is found.
|
|
//
|
|
// Example: `s.Insert(key_equivalent, [] { return real_key; });`
|
|
//
|
|
// The point of this function is when the lookup key is _different_from the
|
|
// stored key. However, we don't restrict it in case that blocks generic
|
|
// usage.
|
|
template <typename LookupKeyT, typename KeyCallbackT>
|
|
auto Insert(LookupKeyT lookup_key, KeyCallbackT key_cb,
|
|
KeyContextT key_context = KeyContextT()) -> InsertResult
|
|
requires(
|
|
!std::same_as<KeyT, KeyCallbackT> &&
|
|
std::convertible_to<decltype(std::declval<KeyCallbackT>()()), KeyT>);
|
|
|
|
// Insert a key into the set and call the provided callback to allow in-place
|
|
// construction of the key if not already present. The lookup key is passed
|
|
// through to the callback so it needn't be captured and can be kept in a
|
|
// register argument throughout.
|
|
//
|
|
// Example:
|
|
// ```cpp
|
|
// m.Insert("widget", [](MyStringViewType lookup_key, void* key_storage) {
|
|
// new (key_storage) MyStringType(lookup_key);
|
|
// });
|
|
// ```
|
|
template <typename LookupKeyT, typename InsertCallbackT>
|
|
auto Insert(LookupKeyT lookup_key, InsertCallbackT insert_cb,
|
|
KeyContextT key_context = KeyContextT()) -> InsertResult
|
|
requires std::invocable<InsertCallbackT, LookupKeyT, void*>;
|
|
|
|
// Grow the set to a specific allocation size.
|
|
//
|
|
// This will grow the set's hashtable if necessary for it to have an
|
|
// allocation size of `target_alloc_size` which must be a power of two. Note
|
|
// that this will not allow that many keys to be inserted, but a smaller
|
|
// number based on the maximum load factor. If a specific number of insertions
|
|
// need to be achieved without triggering growth, use the `GrowForInsertCount`
|
|
// method.
|
|
auto GrowToAllocSize(ssize_t target_alloc_size,
|
|
KeyContextT key_context = KeyContextT()) -> void;
|
|
|
|
// Grow the set sufficiently to allow inserting the specified number of keys.
|
|
auto GrowForInsertCount(ssize_t count,
|
|
KeyContextT key_context = KeyContextT()) -> void;
|
|
|
|
// Erase a key from the set.
|
|
template <typename LookupKeyT>
|
|
auto Erase(LookupKeyT lookup_key, KeyContextT key_context = KeyContextT())
|
|
-> bool;
|
|
|
|
// Clear all key/value pairs from the set but leave the underlying hashtable
|
|
// allocated and in place.
|
|
auto Clear() -> void;
|
|
|
|
protected:
|
|
using ImplT::ImplT;
|
|
};
|
|
|
|
// A data structure for a set of keys.
|
|
//
|
|
// This set supports small size optimization (or "SSO"). The provided
|
|
// `SmallSize` type parameter indicates the size of an embedded buffer for
|
|
// storing sets small enough to fit. The default is zero, which always allocates
|
|
// a heap buffer on construction. When non-zero, must be a multiple of the
|
|
// `MaxGroupSize` which is currently 16. The library will check that the size is
|
|
// valid and provide an error at compile time if not. We don't automatically
|
|
// select the next multiple or otherwise fit the size to the constraints to make
|
|
// it clear in the code how much memory is used by the SSO buffer.
|
|
//
|
|
// This data structure optimizes heavily for small key types that are cheap to
|
|
// move and even copy. Using types with large keys or expensive to copy keys may
|
|
// create surprising performance bottlenecks. A `std::string` key should be fine
|
|
// with generally small strings, but if some or many strings are large heap
|
|
// allocations the performance of hashtable routines may be unacceptably bad and
|
|
// another data structure or key design is likely preferable.
|
|
//
|
|
// Note that `Set`, like `SetBase`, has "shallow" const semantics. Note also
|
|
// that this type should typically not appear on API boundaries; either
|
|
// `SetBase` or `SetView` should be used instead.
|
|
template <typename InputKeyT, ssize_t SmallSize = 0,
|
|
typename InputKeyContextT = DefaultKeyContext>
|
|
class Set : public RawHashtable::TableImpl<SetBase<InputKeyT, InputKeyContextT>,
|
|
SmallSize> {
|
|
using BaseT = SetBase<InputKeyT, InputKeyContextT>;
|
|
using ImplT = RawHashtable::TableImpl<BaseT, SmallSize>;
|
|
|
|
public:
|
|
using KeyT = BaseT::KeyT;
|
|
|
|
Set() = default;
|
|
Set(const Set& arg) = default;
|
|
Set(Set&& arg) noexcept = default;
|
|
auto operator=(const Set& arg) -> Set& = default;
|
|
auto operator=(Set&& arg) noexcept -> Set& = default;
|
|
|
|
// Reset the entire state of the hashtable to as it was when constructed,
|
|
// throwing away any intervening allocations.
|
|
auto Reset() -> void;
|
|
};
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
template <typename LookupKeyT>
|
|
auto SetView<InputKeyT, InputKeyContextT>::Contains(
|
|
LookupKeyT lookup_key, KeyContextT key_context) const -> bool {
|
|
return this->LookupEntry(lookup_key, key_context) != nullptr;
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
template <typename LookupKeyT>
|
|
auto SetView<InputKeyT, InputKeyContextT>::Lookup(LookupKeyT lookup_key,
|
|
KeyContextT key_context) const
|
|
-> LookupResult {
|
|
EntryT* entry = this->LookupEntry(lookup_key, key_context);
|
|
if (!entry) {
|
|
return LookupResult();
|
|
}
|
|
|
|
return LookupResult(entry->key());
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
auto SetView<InputKeyT, InputKeyContextT>::entries() const -> Range {
|
|
return this->ImplT::EntriesImpl();
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
template <typename LookupKeyT>
|
|
auto SetBase<InputKeyT, InputKeyContextT>::Insert(LookupKeyT lookup_key,
|
|
KeyContextT key_context)
|
|
-> InsertResult {
|
|
return Insert(
|
|
lookup_key,
|
|
[](LookupKeyT lookup_key, void* key_storage) {
|
|
new (key_storage) KeyT(std::move(lookup_key));
|
|
},
|
|
key_context);
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
template <typename LookupKeyT, typename KeyCallbackT>
|
|
auto SetBase<InputKeyT, InputKeyContextT>::Insert(LookupKeyT lookup_key,
|
|
KeyCallbackT key_cb,
|
|
KeyContextT key_context)
|
|
-> InsertResult
|
|
requires(!std::same_as<KeyT, KeyCallbackT> &&
|
|
std::convertible_to<decltype(std::declval<KeyCallbackT>()()), KeyT>)
|
|
{
|
|
return Insert(
|
|
lookup_key,
|
|
[&key_cb](LookupKeyT /*lookup_key*/, void* key_storage) {
|
|
new (key_storage) KeyT(key_cb());
|
|
},
|
|
key_context);
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
template <typename LookupKeyT, typename InsertCallbackT>
|
|
auto SetBase<InputKeyT, InputKeyContextT>::Insert(LookupKeyT lookup_key,
|
|
InsertCallbackT insert_cb,
|
|
KeyContextT key_context)
|
|
-> InsertResult
|
|
requires std::invocable<InsertCallbackT, LookupKeyT, void*>
|
|
{
|
|
auto [entry, inserted] = this->InsertImpl(lookup_key, key_context);
|
|
CARBON_DCHECK(entry, "Should always result in a valid index.");
|
|
|
|
if (LLVM_LIKELY(!inserted)) {
|
|
return InsertResult(false, entry->key());
|
|
}
|
|
|
|
insert_cb(lookup_key, static_cast<void*>(&entry->key_storage));
|
|
return InsertResult(true, entry->key());
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
auto SetBase<InputKeyT, InputKeyContextT>::GrowToAllocSize(
|
|
ssize_t target_alloc_size, KeyContextT key_context) -> void {
|
|
this->GrowToAllocSizeImpl(target_alloc_size, key_context);
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
auto SetBase<InputKeyT, InputKeyContextT>::GrowForInsertCount(
|
|
ssize_t count, KeyContextT key_context) -> void {
|
|
this->GrowForInsertCountImpl(count, key_context);
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
template <typename LookupKeyT>
|
|
auto SetBase<InputKeyT, InputKeyContextT>::Erase(LookupKeyT lookup_key,
|
|
KeyContextT key_context)
|
|
-> bool {
|
|
return this->EraseImpl(lookup_key, key_context);
|
|
}
|
|
|
|
template <typename InputKeyT, typename InputKeyContextT>
|
|
auto SetBase<InputKeyT, InputKeyContextT>::Clear() -> void {
|
|
this->ClearImpl();
|
|
}
|
|
|
|
template <typename InputKeyT, ssize_t SmallSize, typename InputKeyContextT>
|
|
auto Set<InputKeyT, SmallSize, InputKeyContextT>::Reset() -> void {
|
|
this->ResetImpl();
|
|
}
|
|
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_COMMON_SET_H_
|