mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 22:02:41 +01:00
Chandler Carruth
d010d52f37
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
48 lines
1.8 KiB
C++
48 lines
1.8 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/sem_ir/impl.h"
|
|
|
|
#include "toolchain/base/kind_switch.h"
|
|
#include "toolchain/base/value_store_impl.h"
|
|
#include "toolchain/sem_ir/facet_type_info.h"
|
|
#include "toolchain/sem_ir/file.h"
|
|
#include "toolchain/sem_ir/specific_interface.h"
|
|
#include "toolchain/sem_ir/specific_named_constraint.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
ImplStore::ImplStore(File& sem_ir)
|
|
: sem_ir_(sem_ir), values_(sem_ir.check_ir_id()) {}
|
|
|
|
auto ImplStore::GetOrAddLookupBucket(const Impl& impl) -> LookupBucketRef {
|
|
auto self_const_id = sem_ir_.constant_values().Get(impl.self_id);
|
|
auto impl_as_interface = SpecificInterface::None;
|
|
auto facet_type_type_id = TypeId::ForTypeConstant(
|
|
sem_ir_.constant_values().Get(impl.constraint_id));
|
|
if (auto facet_type =
|
|
sem_ir_.types().TryGetAs<FacetType>(facet_type_type_id)) {
|
|
auto identified_id = sem_ir_.identified_facet_types().Lookup(
|
|
{facet_type->facet_type_id, self_const_id});
|
|
CARBON_CHECK(identified_id.has_value(),
|
|
"impl with unidentitied facet type");
|
|
const auto& identified =
|
|
sem_ir_.identified_facet_types().Get(identified_id);
|
|
if (identified.is_valid_impl_as_target()) {
|
|
impl_as_interface = identified.impl_as_target_interface();
|
|
}
|
|
}
|
|
return LookupBucketRef(
|
|
*this, lookup_
|
|
.Insert(std::pair{self_const_id, impl_as_interface},
|
|
[] { return ImplOrLookupBucketId::None; })
|
|
.value());
|
|
}
|
|
|
|
} // namespace Carbon::SemIR
|
|
|
|
namespace Carbon {
|
|
template class ValueStore<SemIR::ImplId, SemIR::Impl, Tag<SemIR::CheckIRId>>;
|
|
} // namespace Carbon
|