mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-04 22:02:52 +01:00
When converting from a facet value (an instruction whose type is FacetType), we require making a FacetAccessType to have a type instruction when building the resulting FacetValue. Otherwise, the conversion is the same for values of type TypeType, and we relax the convert function to support either. Corrects the test expectations for converting `Goat as Animal`, a facet value of type FacetType, into `Eats`, a facet type of type TypeType. This would be a promotion in the typish hierarchy which is incorrect. We had an extra case in Convert that was handling this, and it's now removed. `Animal`, a facet type, does still correctly convert into `Eats`, a facet type, if `impl Animal as Eats` exists.