mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-17 06:08:11 +00:00
Seems the instructions got emitted out of order & that caused problems for lowering. This was because most of the initialization instructions were added to a PendingBlock, but the vptr initialization instructions were added to the (non-pending) block directly. (I don't fully understand the pending stuff (is there a different test I could/should write that demonstrates the vptr init instructions not being discarded because they didn't go in the pending block (before this patch)), or the out of order instruction problem (could we add more robust checking for instruction ordering?) - but perhaps this is adequate understanding for this bug fix at least) Fixes #5094 --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk>