mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 21:50:14 +01:00
Jon Ross-Perkins
acbe6530c3
What this really does is avoids shadowing names, so that we can comfortable have things like `Check::DiagnosticEmitter` or `Check::DiagnosticLoc` without shadowing being a concern. Note, down this path I'm also thinking about: - Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly just to DiagnosticConsumer/DiagnosticEmitter (so `Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`). - Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`. - But not for `Check::DiagnosticBuilder`, because `Check::Builder` would be ambiguous. - Renaming diagnostics/diagnostic_* to drop "diagnostic". [Discussion about SemIRLoc -> DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698) reminded me of this (in particular the older [Check::DiagnosticBuilder discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)), but I'd only do that rename if there's matching consensus about a path forward where we keep SemIRLoc, and in a way that it's only ever used for diagnostics (the divergence from which is at the root of current LocId discussion). I'm trying to keep that separate from a namespace addition for clarity.
51 lines
1.3 KiB
C++
51 lines
1.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include <benchmark/benchmark.h>
|
|
|
|
#include "common/check.h"
|
|
#include "toolchain/diagnostics/null_diagnostics.h"
|
|
#include "toolchain/lex/numeric_literal.h"
|
|
|
|
namespace Carbon::Lex {
|
|
namespace {
|
|
|
|
static void BM_Lex_Float(benchmark::State& state) {
|
|
for (auto _ : state) {
|
|
CARBON_CHECK(NumericLiteral::Lex("0.000001", true));
|
|
}
|
|
}
|
|
|
|
static void BM_Lex_Int(benchmark::State& state) {
|
|
for (auto _ : state) {
|
|
CARBON_CHECK(NumericLiteral::Lex("1_234_567_890", true));
|
|
}
|
|
}
|
|
|
|
static void BM_ComputeValue_Float(benchmark::State& state) {
|
|
auto val = NumericLiteral::Lex("0.000001", true);
|
|
CARBON_CHECK(val);
|
|
auto& emitter = Diagnostics::NullEmitter<const char*>();
|
|
for (auto _ : state) {
|
|
val->ComputeValue(emitter);
|
|
}
|
|
}
|
|
|
|
static void BM_ComputeValue_Int(benchmark::State& state) {
|
|
auto val = NumericLiteral::Lex("1_234_567_890", true);
|
|
auto& emitter = Diagnostics::NullEmitter<const char*>();
|
|
CARBON_CHECK(val);
|
|
for (auto _ : state) {
|
|
val->ComputeValue(emitter);
|
|
}
|
|
}
|
|
|
|
BENCHMARK(BM_Lex_Float);
|
|
BENCHMARK(BM_Lex_Int);
|
|
BENCHMARK(BM_ComputeValue_Float);
|
|
BENCHMARK(BM_ComputeValue_Int);
|
|
|
|
} // namespace
|
|
} // namespace Carbon::Lex
|