mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:40:11 +01:00
Jon Ross-PerkinsandRichard Smith
7fe8bb308b
google-readability-function-size and readability-function-size were _both_ triggering on TypeCheckExp. It looks like the Google version may be a subset of the general version, so I've disabled the Google version while keeping the general version and adding a NOLINT for it. I manually removed the `const` in cases like `Nonnull<const VTable* const>` based on the readability-const-return-type warning. i.e., where a return type is a pointer, the `const` isn't meaningful and the tidy check was warning about that. Added a NOLINT for misc-definitions-in-headers on IsRecursivelyTransformable. I think that's the right choice for the `constexpr`, the warning didn't feel accurate and may be getting confused by the templating. I changed the structure of `carbon_files` in the fuzzer because the `new` was causing a warning about exceptions. However, also disabling bugprone-exception-escape because it's what was flagging this and it's not really a helpful warning. Other changes were automated. Co-authored-by: Richard Smith <richard@metafoo.co.uk>
65 lines
2.0 KiB
C++
65 lines
2.0 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "common/fuzzing/proto_to_carbon.h"
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "explorer/fuzzing/ast_to_proto.h"
|
|
#include "explorer/syntax/parse.h"
|
|
|
|
namespace Carbon::Testing {
|
|
namespace {
|
|
|
|
static std::vector<llvm::StringRef>* carbon_files = nullptr;
|
|
|
|
// Returns a string representation of `ast`.
|
|
auto AstToString(const AST& ast) -> std::string {
|
|
std::string s;
|
|
llvm::raw_string_ostream out(s);
|
|
out << "package " << ast.package.package << (ast.is_api ? "api" : "impl")
|
|
<< ";\n";
|
|
for (auto* declaration : ast.declarations) {
|
|
out << *declaration << "\n";
|
|
}
|
|
return s;
|
|
}
|
|
|
|
TEST(ProtoToCarbonTest, Roundtrip) {
|
|
int parsed_ok_count = 0;
|
|
for (const llvm::StringRef f : *carbon_files) {
|
|
Carbon::Arena arena;
|
|
const ErrorOr<AST> ast = Carbon::Parse(&arena, f, /*parser_debug=*/false);
|
|
if (ast.ok()) {
|
|
++parsed_ok_count;
|
|
const std::string source_from_proto = ProtoToCarbon(AstToProto(*ast));
|
|
SCOPED_TRACE(testing::Message()
|
|
<< "Carbon file: " << f << ", source from proto:\n"
|
|
<< source_from_proto);
|
|
const ErrorOr<AST> ast_from_proto = Carbon::ParseFromString(
|
|
&arena, f, source_from_proto, /*parser_debug=*/false);
|
|
|
|
if (ast_from_proto.ok()) {
|
|
EXPECT_EQ(AstToString(*ast), AstToString(*ast_from_proto));
|
|
} else {
|
|
ADD_FAILURE() << "Parse error " << ast_from_proto.error().message();
|
|
}
|
|
}
|
|
}
|
|
// Makes sure files were actually processed.
|
|
EXPECT_GT(parsed_ok_count, 0);
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon::Testing
|
|
|
|
auto main(int argc, char** argv) -> int {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
// gtest should remove flags, leaving just input files.
|
|
std::vector<llvm::StringRef> carbon_files(&argv[1], &argv[argc]);
|
|
Carbon::Testing::carbon_files = &carbon_files;
|
|
return RUN_ALL_TESTS();
|
|
}
|