Jon Ross-PerkinsandRichard Smith bed5fdcbbe Fix indirect import handling for functions. (#4258) ...

The particular test this focused on is indirect_two_file in
toolchain/check/testdata/function/definition/no_prelude/extern_library.carbon.

This removes `parent_scope_id_for_new_inst` because I think it's
returning unhelpful results. The use was at the root of incorrect
results for the indirect import chain. `name_id_for_new_inst` is
actually wrapping a union, so it's more important.

The merging of `is_extern` and `first_owning_decl_id` in
`handle_function.cpp` feels like it's less correct with the changes
that've been made to `extern`. This ripples in tests, because the error
recovery shifts.

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>

2024-08-27 20:26:23 +00:00

..

no_prelude

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

fail_param_in_type.carbon

Improve namespace handling in imports. (#4153)

2024-07-24 19:56:17 +00:00

fail_param_redecl.carbon

Improve namespace handling in imports. (#4153)

2024-07-24 19:56:17 +00:00

import.carbon

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

param_same_name.carbon

Improve namespace handling in imports. (#4153)

2024-07-24 19:56:17 +00:00