mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-29 09:34:56 +01:00
Chandler Carruth
d010d52f37
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
109 lines
3.2 KiB
C++
109 lines
3.2 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/sem_ir/name_scope.h"
|
|
|
|
#include <optional>
|
|
#include <utility>
|
|
|
|
#include "toolchain/base/value_store_impl.h"
|
|
#include "toolchain/sem_ir/file.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
NameScopeStore::NameScopeStore(const File* file)
|
|
// 1 reserved untagged id because the Package NameScope is used across
|
|
// Files.
|
|
: file_(file), values_(file->check_ir_id(), 1) {}
|
|
|
|
auto NameScope::Print(llvm::raw_ostream& out) const -> void {
|
|
out << "{inst: " << inst_id_ << ", parent_scope: " << parent_scope_id_
|
|
<< ", has_error: " << (has_error_ ? "true" : "false");
|
|
|
|
out << ", extended_scopes: [";
|
|
llvm::ListSeparator scope_sep;
|
|
for (auto id : extended_scopes_) {
|
|
out << scope_sep << id;
|
|
}
|
|
out << "]";
|
|
|
|
out << ", names: {";
|
|
llvm::ListSeparator sep;
|
|
for (auto entry : names_) {
|
|
if (entry.result.is_poisoned()) {
|
|
continue;
|
|
}
|
|
out << sep << entry.name_id << ": " << entry.result.target_inst_id();
|
|
}
|
|
out << "}";
|
|
|
|
out << "}";
|
|
}
|
|
|
|
auto NameScope::AddRequired(Entry name_entry) -> void {
|
|
CARBON_CHECK(!name_entry.result.is_poisoned(),
|
|
"Cannot add a poisoned name: {0}.", name_entry.name_id);
|
|
auto add_name = [&] {
|
|
EntryId index(names_.size());
|
|
names_.push_back(name_entry);
|
|
return index;
|
|
};
|
|
auto result = name_map_.Insert(name_entry.name_id, add_name);
|
|
if (!result.is_inserted()) {
|
|
// A required name can overwrite poison.
|
|
auto& name = names_[result.value().index];
|
|
CARBON_CHECK(name.result.is_poisoned(), "Failed to add required name: {0}",
|
|
name_entry.name_id);
|
|
name = name_entry;
|
|
}
|
|
}
|
|
|
|
auto NameScope::LookupOrAdd(NameId name_id, InstId inst_id,
|
|
AccessKind access_kind)
|
|
-> std::pair<bool, EntryId> {
|
|
auto insert_result = name_map_.Insert(name_id, EntryId(names_.size()));
|
|
if (!insert_result.is_inserted()) {
|
|
return {false, EntryId(insert_result.value())};
|
|
}
|
|
|
|
names_.push_back({.name_id = name_id,
|
|
.result = ScopeLookupResult::MakeWrappedLookupResult(
|
|
inst_id, access_kind)});
|
|
return {true, EntryId(names_.size() - 1)};
|
|
}
|
|
|
|
auto NameScope::LookupOrPoison(LocId loc_id, NameId name_id)
|
|
-> std::optional<EntryId> {
|
|
if (!name_id.AsIdentifierId().has_value()) {
|
|
return Lookup(name_id);
|
|
}
|
|
|
|
auto insert_result = name_map_.Insert(name_id, EntryId(names_.size()));
|
|
if (insert_result.is_inserted()) {
|
|
names_.push_back({.name_id = name_id,
|
|
.result = ScopeLookupResult::MakePoisoned(loc_id)});
|
|
return std::nullopt;
|
|
}
|
|
return insert_result.value();
|
|
}
|
|
|
|
auto NameScopeStore::GetInstIfValid(NameScopeId scope_id) const
|
|
-> std::pair<InstId, std::optional<Inst>> {
|
|
if (!scope_id.has_value()) {
|
|
return {InstId::None, std::nullopt};
|
|
}
|
|
auto inst_id = Get(scope_id).inst_id();
|
|
if (!inst_id.has_value()) {
|
|
return {InstId::None, std::nullopt};
|
|
}
|
|
return {inst_id, file_->insts().Get(inst_id)};
|
|
}
|
|
|
|
} // namespace Carbon::SemIR
|
|
|
|
namespace Carbon {
|
|
template class ValueStore<SemIR::NameScopeId, SemIR::NameScope,
|
|
Tag<SemIR::CheckIRId>>;
|
|
}
|