carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-27 10:10:09 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
bbca8668aef03ca995bc2dbddff4e36be3ff082d
carbon-lang/toolchain/check/testdata/pointer/convert_qualifiers.carbon
T
Richard Smith 05cc09daca Fix cross-package signature mismatches. (#7232) 
Fixes link failures when referencing a symbol involving a fingerprint
from a different package.

Previously we included the `Namespace`'s `import_id` as part of its
fingerprint, which caused local and imported namespaces to get different
fingerprints. We now store the `import_id` on the `NameScope` instead of
on the `Namespace` inst to avoid this problem.

Also, when we reach a package-level `NameScopeId`, consistently
fingerprint it as a (package name, library name) pair. Previously the
fingerprinting depended on whether it was imported or not, as an
imported `NameScopeId` had a parent scope (the current package). We need
to include the library name here so that private entities with the same
name in different libraries have different fingerprints.
2026-05-21 00:02:29 +00:00

209 lines
9.9 KiB
Plaintext
Raw Blame History

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/int.carbon
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/pointer/convert_qualifiers.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/pointer/convert_qualifiers.carbon
// --- same_or_added_qualifiers.carbon
library "[[@TEST_NAME]]";
class X {}
fn TakeConst(p: const X*);
fn TakeNonConst(p: X*);
fn NonConst(p: X*) {
//@dump-sem-ir-begin
TakeNonConst(p);
TakeConst(p);
//@dump-sem-ir-end
}
fn Const(p: const X*) {
//@dump-sem-ir-begin
TakeConst(p);
//@dump-sem-ir-end
}
// Same thing, but the pointee type happens to be a pointer.
fn TakeConstConst(p: const (const X*)*);
fn NonConstConst(p: const X**) {
//@dump-sem-ir-begin
TakeConstConst(p);
//@dump-sem-ir-end
}
// --- fail_removed_qualifiers.carbon
library "[[@TEST_NAME]]";
class X {}
fn TakeNonConst(p: X*);
// CHECK:STDERR: fail_removed_qualifiers.carbon:[[@LINE+10]]:38: error: cannot implicitly convert expression of type `const X*` to `X*` [ConversionFailure]
// CHECK:STDERR: fn Const(p: const X*) { TakeNonConst(p); }
// CHECK:STDERR: ^
// CHECK:STDERR: fail_removed_qualifiers.carbon:[[@LINE+7]]:38: note: type `const X*` does not implement interface `Core.ImplicitAs(X*)` [MissingImplInMemberAccessInContext]
// CHECK:STDERR: fn Const(p: const X*) { TakeNonConst(p); }
// CHECK:STDERR: ^
// CHECK:STDERR: fail_removed_qualifiers.carbon:[[@LINE-8]]:17: note: initializing function parameter [InCallToFunctionParam]
// CHECK:STDERR: fn TakeNonConst(p: X*);
// CHECK:STDERR: ^~~~~
// CHECK:STDERR:
fn Const(p: const X*) { TakeNonConst(p); }
// --- fail_todo_nested_qualifiers.carbon
library "[[@TEST_NAME]]";
class X {}
fn TakeConstConst(p: const (const X*)*);
// TODO: We should allow these conversions.
fn NonConstNonConst(p: X**) {
//@dump-sem-ir-begin
// CHECK:STDERR: fail_todo_nested_qualifiers.carbon:[[@LINE+10]]:18: error: cannot implicitly convert expression of type `X**` to `const (const X*)*` [ConversionFailure]
// CHECK:STDERR: TakeConstConst(p);
// CHECK:STDERR: ^
// CHECK:STDERR: fail_todo_nested_qualifiers.carbon:[[@LINE+7]]:18: note: type `X**` does not implement interface `Core.ImplicitAs(const (const X*)*)` [MissingImplInMemberAccessInContext]
// CHECK:STDERR: TakeConstConst(p);
// CHECK:STDERR: ^
// CHECK:STDERR: fail_todo_nested_qualifiers.carbon:[[@LINE-12]]:19: note: initializing function parameter [InCallToFunctionParam]
// CHECK:STDERR: fn TakeConstConst(p: const (const X*)*);
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~
// CHECK:STDERR:
TakeConstConst(p);
//@dump-sem-ir-end
}
fn ConstNonConst(p: const (X*)*) {
//@dump-sem-ir-begin
// CHECK:STDERR: fail_todo_nested_qualifiers.carbon:[[@LINE+10]]:18: error: cannot implicitly convert expression of type `const (X*)*` to `const (const X*)*` [ConversionFailure]
// CHECK:STDERR: TakeConstConst(p);
// CHECK:STDERR: ^
// CHECK:STDERR: fail_todo_nested_qualifiers.carbon:[[@LINE+7]]:18: note: type `const (X*)*` does not implement interface `Core.ImplicitAs(const (const X*)*)` [MissingImplInMemberAccessInContext]
// CHECK:STDERR: TakeConstConst(p);
// CHECK:STDERR: ^
// CHECK:STDERR: fail_todo_nested_qualifiers.carbon:[[@LINE-28]]:19: note: initializing function parameter [InCallToFunctionParam]
// CHECK:STDERR: fn TakeConstConst(p: const (const X*)*);
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~
// CHECK:STDERR:
TakeConstConst(p);
//@dump-sem-ir-end
}
// --- fail_nested_added_qualifiers.carbon
library "[[@TEST_NAME]]";
class X {}
fn TakeNonConstConst(p: (const X*)*);
// CHECK:STDERR: fail_nested_added_qualifiers.carbon:[[@LINE+10]]:49: error: cannot implicitly convert expression of type `X**` to `const X**` [ConversionFailure]
// CHECK:STDERR: fn NonConstNonConst(p: X**) { TakeNonConstConst(p); }
// CHECK:STDERR: ^
// CHECK:STDERR: fail_nested_added_qualifiers.carbon:[[@LINE+7]]:49: note: type `X**` does not implement interface `Core.ImplicitAs(const X**)` [MissingImplInMemberAccessInContext]
// CHECK:STDERR: fn NonConstNonConst(p: X**) { TakeNonConstConst(p); }
// CHECK:STDERR: ^
// CHECK:STDERR: fail_nested_added_qualifiers.carbon:[[@LINE-8]]:22: note: initializing function parameter [InCallToFunctionParam]
// CHECK:STDERR: fn TakeNonConstConst(p: (const X*)*);
// CHECK:STDERR: ^~~~~~~~~~~~~~
// CHECK:STDERR:
fn NonConstNonConst(p: X**) { TakeNonConstConst(p); }
// CHECK:STDOUT: --- same_or_added_qualifiers.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: %X: type = class_type @X [concrete]
// CHECK:STDOUT: %const.cef: type = const_type %X [concrete]
// CHECK:STDOUT: %ptr.9f2: type = ptr_type %const.cef [concrete]
// CHECK:STDOUT: %TakeConst.type: type = fn_type @TakeConst [concrete]
// CHECK:STDOUT: %empty_tuple.type: type = tuple_type () [concrete]
// CHECK:STDOUT: %TakeConst: %TakeConst.type = struct_value () [concrete]
// CHECK:STDOUT: %ptr.aa3: type = ptr_type %X [concrete]
// CHECK:STDOUT: %TakeNonConst.type: type = fn_type @TakeNonConst [concrete]
// CHECK:STDOUT: %TakeNonConst: %TakeNonConst.type = struct_value () [concrete]
// CHECK:STDOUT: %const.966: type = const_type %ptr.9f2 [concrete]
// CHECK:STDOUT: %ptr.ea2: type = ptr_type %const.966 [concrete]
// CHECK:STDOUT: %TakeConstConst.type: type = fn_type @TakeConstConst [concrete]
// CHECK:STDOUT: %TakeConstConst: %TakeConstConst.type = struct_value () [concrete]
// CHECK:STDOUT: %ptr.eab: type = ptr_type %ptr.9f2 [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @NonConst(%p.param: %ptr.aa3) {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %TakeNonConst.ref: %TakeNonConst.type = name_ref TakeNonConst, file.%TakeNonConst.decl [concrete = constants.%TakeNonConst]
// CHECK:STDOUT: %p.ref.loc11: %ptr.aa3 = name_ref p, %p
// CHECK:STDOUT: %TakeNonConst.call: init %empty_tuple.type = call %TakeNonConst.ref(%p.ref.loc11)
// CHECK:STDOUT: %TakeConst.ref: %TakeConst.type = name_ref TakeConst, file.%TakeConst.decl [concrete = constants.%TakeConst]
// CHECK:STDOUT: %p.ref.loc12: %ptr.aa3 = name_ref p, %p
// CHECK:STDOUT: %.loc12_13.1: %ptr.9f2 = as_compatible %p.ref.loc12
// CHECK:STDOUT: %.loc12_13.2: %ptr.9f2 = converted %p.ref.loc12, %.loc12_13.1
// CHECK:STDOUT: %TakeConst.call: init %empty_tuple.type = call %TakeConst.ref(%.loc12_13.2)
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @Const(%p.param: %ptr.9f2) {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %TakeConst.ref: %TakeConst.type = name_ref TakeConst, file.%TakeConst.decl [concrete = constants.%TakeConst]
// CHECK:STDOUT: %p.ref: %ptr.9f2 = name_ref p, %p
// CHECK:STDOUT: %TakeConst.call: init %empty_tuple.type = call %TakeConst.ref(%p.ref)
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @NonConstConst(%p.param: %ptr.eab) {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %TakeConstConst.ref: %TakeConstConst.type = name_ref TakeConstConst, file.%TakeConstConst.decl [concrete = constants.%TakeConstConst]
// CHECK:STDOUT: %p.ref: %ptr.eab = name_ref p, %p
// CHECK:STDOUT: %.loc25_18.1: %ptr.ea2 = as_compatible %p.ref
// CHECK:STDOUT: %.loc25_18.2: %ptr.ea2 = converted %p.ref, %.loc25_18.1
// CHECK:STDOUT: %TakeConstConst.call: init %empty_tuple.type = call %TakeConstConst.ref(%.loc25_18.2)
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: --- fail_todo_nested_qualifiers.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: %X: type = class_type @X [concrete]
// CHECK:STDOUT: %const.33d: type = const_type %X [concrete]
// CHECK:STDOUT: %ptr.cfd: type = ptr_type %const.33d [concrete]
// CHECK:STDOUT: %const.ce5: type = const_type %ptr.cfd [concrete]
// CHECK:STDOUT: %ptr.f12: type = ptr_type %const.ce5 [concrete]
// CHECK:STDOUT: %TakeConstConst.type: type = fn_type @TakeConstConst [concrete]
// CHECK:STDOUT: %empty_tuple.type: type = tuple_type () [concrete]
// CHECK:STDOUT: %TakeConstConst: %TakeConstConst.type = struct_value () [concrete]
// CHECK:STDOUT: %ptr.b19: type = ptr_type %X [concrete]
// CHECK:STDOUT: %ptr.c49: type = ptr_type %ptr.b19 [concrete]
// CHECK:STDOUT: %const.d5d: type = const_type %ptr.b19 [concrete]
// CHECK:STDOUT: %ptr.cb7: type = ptr_type %const.d5d [concrete]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @NonConstNonConst(%p.param: %ptr.c49) {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %TakeConstConst.ref: %TakeConstConst.type = name_ref TakeConstConst, file.%TakeConstConst.decl [concrete = constants.%TakeConstConst]
// CHECK:STDOUT: %p.ref: %ptr.c49 = name_ref p, %p
// CHECK:STDOUT: %.loc22: %ptr.f12 = converted %p.ref, <error> [concrete = <error>]
// CHECK:STDOUT: %TakeConstConst.call: init %empty_tuple.type = call %TakeConstConst.ref(<error>)
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @ConstNonConst(%p.param: %ptr.cb7) {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %TakeConstConst.ref: %TakeConstConst.type = name_ref TakeConstConst, file.%TakeConstConst.decl [concrete = constants.%TakeConstConst]
// CHECK:STDOUT: %p.ref: %ptr.cb7 = name_ref p, %p
// CHECK:STDOUT: %.loc38: %ptr.f12 = converted %p.ref, <error> [concrete = <error>]
// CHECK:STDOUT: %TakeConstConst.call: init %empty_tuple.type = call %TakeConstConst.ref(<error>)
// CHECK:STDOUT: <elided>
// CHECK:STDOUT: }
// CHECK:STDOUT:
Reference in New Issue View Git Blame Copy Permalink