mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-27 11:20:10 +01:00
Chandler Carruth
d010d52f37
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
83 lines
2.3 KiB
C++
83 lines
2.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/base/canonical_value_store.h"
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <string>
|
|
|
|
#include "llvm/ADT/APFloat.h"
|
|
#include "llvm/ADT/StringRef.h"
|
|
#include "toolchain/base/canonical_value_store_impl.h"
|
|
#include "toolchain/base/value_ids.h"
|
|
#include "toolchain/base/value_store_impl.h"
|
|
|
|
namespace Carbon::Testing {
|
|
namespace {
|
|
|
|
using ::testing::Eq;
|
|
using ::testing::Not;
|
|
|
|
TEST(CanonicalValueStore, Float) {
|
|
llvm::APFloat float1(1.0);
|
|
llvm::APFloat float2(2.0);
|
|
|
|
CanonicalValueStore<FloatId, llvm::APFloat> floats;
|
|
FloatId id1 = floats.Add(float1);
|
|
FloatId id2 = floats.Add(float2);
|
|
|
|
ASSERT_TRUE(id1.has_value());
|
|
ASSERT_TRUE(id2.has_value());
|
|
EXPECT_THAT(id1, Not(Eq(id2)));
|
|
|
|
EXPECT_THAT(floats.Get(id1).compare(float1), Eq(llvm::APFloatBase::cmpEqual));
|
|
EXPECT_THAT(floats.Get(id2).compare(float2), Eq(llvm::APFloatBase::cmpEqual));
|
|
}
|
|
|
|
TEST(CanonicalValueStore, Identifiers) {
|
|
std::string a = "a";
|
|
std::string b = "b";
|
|
CanonicalValueStore<IdentifierId, llvm::StringRef> identifiers;
|
|
|
|
// Make sure reserve works, we use it with identifiers.
|
|
identifiers.Reserve(100);
|
|
|
|
auto a_id = identifiers.Add(a);
|
|
auto b_id = identifiers.Add(b);
|
|
|
|
ASSERT_TRUE(a_id.has_value());
|
|
ASSERT_TRUE(b_id.has_value());
|
|
EXPECT_THAT(a_id, Not(Eq(b_id)));
|
|
|
|
EXPECT_THAT(identifiers.Get(a_id), Eq(a));
|
|
EXPECT_THAT(identifiers.Get(b_id), Eq(b));
|
|
|
|
EXPECT_THAT(identifiers.Lookup(a), Eq(a_id));
|
|
EXPECT_THAT(identifiers.Lookup("c"), Eq(IdentifierId::None));
|
|
}
|
|
|
|
TEST(CanonicalValueStore, StringLiterals) {
|
|
std::string a = "a";
|
|
std::string b = "b";
|
|
CanonicalValueStore<StringLiteralValueId, llvm::StringRef> string_literals;
|
|
|
|
auto a_id = string_literals.Add(a);
|
|
auto b_id = string_literals.Add(b);
|
|
|
|
ASSERT_TRUE(a_id.has_value());
|
|
ASSERT_TRUE(b_id.has_value());
|
|
EXPECT_THAT(a_id, Not(Eq(b_id)));
|
|
|
|
EXPECT_THAT(string_literals.Get(a_id), Eq(a));
|
|
EXPECT_THAT(string_literals.Get(b_id), Eq(b));
|
|
|
|
EXPECT_THAT(string_literals.Lookup(a), Eq(a_id));
|
|
EXPECT_THAT(string_literals.Lookup("c"), Eq(StringLiteralValueId::None));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon::Testing
|