mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 15:55:03 +01:00
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
152 lines
5.3 KiB
C++
152 lines
5.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_BASE_BLOCK_VALUE_STORE_H_
|
|
#define CARBON_TOOLCHAIN_BASE_BLOCK_VALUE_STORE_H_
|
|
|
|
#include <type_traits>
|
|
|
|
#include "common/check.h"
|
|
#include "common/set.h"
|
|
#include "llvm/Support/Allocator.h"
|
|
#include "toolchain/base/id_tag.h"
|
|
#include "toolchain/base/mem_usage.h"
|
|
#include "toolchain/base/value_store.h"
|
|
#include "toolchain/base/yaml.h"
|
|
|
|
namespace Carbon {
|
|
|
|
// Provides a block-based ValueStore, which uses slab allocation of added
|
|
// blocks. This allows references to values to outlast vector resizes that might
|
|
// otherwise invalidate references.
|
|
//
|
|
// BlockValueStore is used as-is, but there are also children that expose the
|
|
// protected members for type-specific functionality.
|
|
//
|
|
// This template class is designed to be explicitly instantiated to improve
|
|
// compile times. Heavy method definitions are in `block_value_store_impl.h`.
|
|
//
|
|
// To use a new instantiation:
|
|
// 1. Add an `extern template class BlockValueStore<...>;` declaration in the
|
|
// header where the instantiation is anchored.
|
|
// 2. Add `template class BlockValueStore<...>;` definition in the associated
|
|
// `.cpp` file.
|
|
// 3. Include `toolchain/base/block_value_store_impl.h` in that `.cpp` file.
|
|
template <typename IdT, typename ElementT, typename TagIdT = Untagged>
|
|
class BlockValueStore
|
|
: public Yaml::Printable<BlockValueStore<IdT, ElementT, TagIdT>> {
|
|
public:
|
|
using IdType = IdT;
|
|
using IdTagType = IdTag<IdT, TagIdT>;
|
|
using ElementType = ElementT;
|
|
using RefType = llvm::MutableArrayRef<ElementT>;
|
|
using ConstRefType = llvm::ArrayRef<ElementT>;
|
|
|
|
explicit BlockValueStore(llvm::BumpPtrAllocator& allocator,
|
|
IdTagType::TagIdType tag_id,
|
|
int32_t initial_reserved_ids = 0)
|
|
requires(!IdTagIsUntagged<IdTagType>);
|
|
|
|
~BlockValueStore();
|
|
BlockValueStore(BlockValueStore&&) noexcept;
|
|
auto operator=(BlockValueStore&&) noexcept -> BlockValueStore&;
|
|
|
|
// Adds a block with the given content, returning an ID to reference it.
|
|
auto Add(ConstRefType content) -> IdT {
|
|
if constexpr (requires { IdT::Empty; }) {
|
|
if (content.empty()) {
|
|
return IdT::Empty;
|
|
}
|
|
}
|
|
return values_.Add(AllocateCopy(content));
|
|
}
|
|
|
|
// Returns the requested block.
|
|
auto Get(IdT id) const -> ConstRefType { return values_.Get(id); }
|
|
|
|
// Returns a mutable view of the requested block. This operation should be
|
|
// avoided where possible; we generally want blocks to be immutable once
|
|
// created.
|
|
auto GetMutable(IdT id) -> RefType { return values_.Get(id); }
|
|
|
|
// Returns a new block formed by applying `transform(elem_id)` to each element
|
|
// in the specified block.
|
|
template <typename TransformFnT>
|
|
auto Transform(IdT id, TransformFnT transform) -> IdT {
|
|
llvm::SmallVector<ElementType> block(llvm::map_range(Get(id), transform));
|
|
return Add(block);
|
|
}
|
|
|
|
// Adds a block or finds an existing canonical block with the given content,
|
|
// and returns an ID to reference it.
|
|
auto AddCanonical(ConstRefType content) -> IdT {
|
|
if constexpr (requires { IdT::Empty; }) {
|
|
if (content.empty()) {
|
|
return IdT::Empty;
|
|
}
|
|
}
|
|
auto result = canonical_blocks_.Insert(
|
|
content, [&] { return Add(content); }, KeyContext(this));
|
|
return result.key();
|
|
}
|
|
|
|
// Promotes an existing block ID to a canonical block ID, or returns an
|
|
// existing canonical block ID if the block was already added. The specified
|
|
// block must not be modified after this point.
|
|
auto MakeCanonical(IdT id) -> IdT {
|
|
// Get the content first so that we don't have unnecessary translation of
|
|
// the `id` into the content during insertion.
|
|
auto result = canonical_blocks_.Insert(
|
|
Get(id), [id] { return id; }, KeyContext(this));
|
|
return result.key();
|
|
}
|
|
|
|
auto OutputYaml() const -> Yaml::OutputMapping;
|
|
|
|
// Collects memory usage of members.
|
|
auto CollectMemUsage(MemUsage& mem_usage, llvm::StringRef label) const
|
|
-> void;
|
|
|
|
auto size() const -> size_t { return values_.size(); }
|
|
|
|
auto GetRawIndex(IdT id) const -> int { return values_.GetRawIndex(id); }
|
|
|
|
auto GetIdTag() const -> IdTagType { return values_.GetIdTag(); }
|
|
|
|
auto ids() const -> auto { return values_.ids(); }
|
|
|
|
protected:
|
|
// Allocates a copy of the given data using our slab allocator.
|
|
auto AllocateCopy(ConstRefType data) -> RefType;
|
|
|
|
// Allocates an uninitialized array using our slab allocator.
|
|
auto AllocateUninitialized(size_t size) -> RefType;
|
|
|
|
// Allow children to have more complex value handling.
|
|
auto values() -> ValueStore<IdT, RefType, TagIdT>& { return values_; }
|
|
|
|
private:
|
|
class KeyContext;
|
|
|
|
llvm::BumpPtrAllocator* allocator_;
|
|
ValueStore<IdT, RefType, TagIdT> values_;
|
|
Set<IdT, /*SmallSize=*/0, KeyContext> canonical_blocks_;
|
|
};
|
|
|
|
template <typename IdT, typename ElementT, typename TagIdT>
|
|
class BlockValueStore<IdT, ElementT, TagIdT>::KeyContext
|
|
: public TranslatingKeyContext<KeyContext> {
|
|
public:
|
|
explicit KeyContext(const BlockValueStore* store) : store_(store) {}
|
|
|
|
auto TranslateKey(IdT id) const -> ConstRefType { return store_->Get(id); }
|
|
|
|
private:
|
|
const BlockValueStore* store_;
|
|
};
|
|
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_TOOLCHAIN_BASE_BLOCK_VALUE_STORE_H_
|