Files
carbon-lang/toolchain/check/handle_array.cpp
T
Richard SmithandDana Jansens bba32900c3 Preserve type sugar in ArrayType, ConstType, and PointerType. (#5235)
Each of these types takes another type as an operand. Instead of storing
that other type as a `TypeId`, store it as an `InstId` so that we can
track how it was written, not only its canonical form.

The canonical constant values of these types continue to store the
canonical constant values of their operands, as normal.

---------

Co-authored-by: Dana Jansens <danakj@orodu.net>
2025-04-03 21:14:03 +00:00

62 lines
2.2 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/check/context.h"
#include "toolchain/check/convert.h"
#include "toolchain/check/handle.h"
#include "toolchain/check/inst.h"
#include "toolchain/check/type.h"
#include "toolchain/parse/node_kind.h"
namespace Carbon::Check {
auto HandleParseNode(Context& /*context*/,
Parse::ArrayExprOpenParenId /*node_id*/) -> bool {
return true;
}
auto HandleParseNode(Context& /*context*/,
Parse::ArrayExprKeywordId /*node_id*/) -> bool {
return true;
}
auto HandleParseNode(Context& /*context*/, Parse::ArrayExprCommaId /*node_id*/)
-> bool {
return true;
}
auto HandleParseNode(Context& context, Parse::ArrayExprId node_id) -> bool {
auto bound_inst_id = context.node_stack().PopExpr();
auto [element_type_node_id, element_type_inst_id] =
context.node_stack().PopExprWithNodeId();
auto element_type =
ExprAsType(context, element_type_node_id, element_type_inst_id);
// The array bound must be a constant. Diagnose this prior to conversion
// because conversion to `IntLiteral` will produce a generic "non-constant
// call to compile-time-only function" error.
//
// TODO: Should we support runtime-phase bounds in cases such as:
// comptime fn F(n: i32) -> type { return array(i32; n); }
if (!context.constant_values().Get(bound_inst_id).is_constant()) {
CARBON_DIAGNOSTIC(InvalidArrayExpr, Error, "array bound is not a constant");
context.emitter().Emit(bound_inst_id, InvalidArrayExpr);
context.node_stack().Push(node_id, SemIR::ErrorInst::SingletonInstId);
return true;
}
bound_inst_id = ConvertToValueOfType(
context, context.insts().GetLocId(bound_inst_id), bound_inst_id,
GetSingletonType(context, SemIR::IntLiteralType::SingletonInstId));
AddInstAndPush<SemIR::ArrayType>(
context, node_id,
{.type_id = SemIR::TypeType::SingletonTypeId,
.bound_id = bound_inst_id,
.element_type_inst_id = element_type.inst_id});
return true;
}
} // namespace Carbon::Check