mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 22:02:55 +01:00
Jon Ross-Perkins
a23f15e901
This is how I'm interpreting discussion:
- Basic elements are getting set to an ID.
- SetName exists to assign a name (which can then be referred to later with an identifier expression) to an ID.
- Expressions are broken down into a series of operations which operate on IDs.
So with something like the last test:
```
fn Main() { return 12 + 34; }
```
This becomes:
```
Function(%0,
{IntegerLiteral(%3, 12),
IntegerLiteral(%2, 34),
BinaryOperator(%1, +, %3, %2),
Return(%1),
})
SetName(`Main`, %0)
```
Note I'm treating blocks as fairly equal to the top of a file now, and basically eliminating boundaries between things. That's because we have discussed also supporting code like:
```
fn Foo() {
fn Bar() {}
Bar();
}
```
Here a declaration of a function is occurring inside a code block, so it felt like eliminating the difference was the best choice.
I know you'd commented on the separation of nodes to individual files before; I still think we're going to have a lot of different types of nodes, and so separating them out into individual files makes them easier to browse.
35 lines
1.3 KiB
C++
35 lines
1.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_SEMANTICS_NODES_SET_NAME_TEST_MATCHERS_H_
|
|
#define CARBON_TOOLCHAIN_SEMANTICS_NODES_SET_NAME_TEST_MATCHERS_H_
|
|
|
|
#include <gmock/gmock.h>
|
|
|
|
#include "llvm/ADT/StringExtras.h"
|
|
#include "toolchain/semantics/nodes/set_name.h"
|
|
#include "toolchain/semantics/semantics_ir_for_test.h"
|
|
|
|
namespace Carbon::Testing {
|
|
|
|
MATCHER_P2(
|
|
SetName, name_matcher, target_id_matcher,
|
|
llvm::formatv("SetName(`{0}`, %`{1}`)",
|
|
::testing::DescribeMatcher<llvm::StringRef>(name_matcher),
|
|
::testing::DescribeMatcher<int32_t>(target_id_matcher))) {
|
|
const Semantics::NodeRef& node_ref = arg;
|
|
if (auto node = SemanticsIRForTest::GetNode<Semantics::SetName>(node_ref)) {
|
|
return ExplainMatchResult(name_matcher, node->name(), result_listener) &&
|
|
ExplainMatchResult(target_id_matcher, node->target_id(),
|
|
result_listener);
|
|
} else {
|
|
*result_listener << "node is not a SetName";
|
|
return result_listener;
|
|
}
|
|
}
|
|
|
|
} // namespace Carbon::Testing
|
|
|
|
#endif // CARBON_TOOLCHAIN_SEMANTICS_NODES_SET_NAME_TEST_MATCHERS_H_
|