Files
carbon-lang/toolchain/semantics/semantics_handle_if_expression.cpp
T
Jon Ross-Perkins b9df8ca765 Manual cleanup of toolchain clang-tidy/clangd warnings. (#3157)
A lot of this is more boring "remove unused header", plus some other
minor cleanups. I think the most significant changes were:

- yaml_test_helpers.cpp is doing a switch on an unsigned int, comparing
to enum values.
-
[bugprone-switch-missing-default-case](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/switch-missing-default-case.html)
is unhappy with EnumBase, but correctly identified
yaml_test_helpers.cpp, so I'm opting to address it rather than disabling
it even though it needs NOLINT in several locations as a result, in
addition to what I think are some low-value `default` cases. I'd be fine
going the other way with this too and disabling it globally (I could see
it being noisier in the explorer).
- MarkInitializerFor swaps the argument names between the .h and .cpp. I
think the .cpp had the order as intended.
- There's a new-ish
[performance-enum-size](https://clang.llvm.org/extra/clang-tidy/checks/performance/enum-size.html)
which I'm basically treating as "add int8_t to enums".

My main motivation here is to just clean up as many of these as I can so
that I stop seeing them in vscode.
2023-08-25 22:45:57 +00:00

80 lines
2.9 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/semantics/semantics_context.h"
namespace Carbon::Check {
auto HandleIfExpressionIf(Context& context, ParseTree::Node parse_node)
-> bool {
// Alias parse_node for if/then/else consistency.
auto& if_node = parse_node;
auto cond_value_id = context.node_stack().PopExpression();
context.node_stack().Push(if_node);
// Convert the condition to `bool`, and branch on it.
cond_value_id = context.ConvertToBoolValue(if_node, cond_value_id);
auto then_block_id =
context.AddDominatedBlockAndBranchIf(if_node, cond_value_id);
auto else_block_id = context.AddDominatedBlockAndBranch(if_node);
// Push the `else` block and `then` block, and start emitting the `then`.
context.node_block_stack().Pop();
context.node_block_stack().Push(else_block_id);
context.node_block_stack().Push(then_block_id);
context.AddCurrentCodeBlockToFunction();
return true;
}
auto HandleIfExpressionThen(Context& context, ParseTree::Node parse_node)
-> bool {
// Alias parse_node for if/then/else consistency.
auto& then_node = parse_node;
// Convert the first operand to a value.
auto [then_value_node, then_value_id] =
context.node_stack().PopExpressionWithParseNode();
context.node_stack().Push(then_value_node,
context.ConvertToValueExpression(then_value_id));
context.node_stack().Push(then_node, context.node_block_stack().Pop());
context.AddCurrentCodeBlockToFunction();
return true;
}
auto HandleIfExpressionElse(Context& context, ParseTree::Node parse_node)
-> bool {
// Alias parse_node for if/then/else consistency.
auto& else_node = parse_node;
auto else_value_id = context.node_stack().PopExpression();
auto [then_node, then_end_block_id] =
context.node_stack().PopWithParseNode<ParseNodeKind::IfExpressionThen>();
auto then_value_id = context.node_stack().PopExpression();
auto if_node =
context.node_stack().PopForSoloParseNode<ParseNodeKind::IfExpressionIf>();
// Convert the `else` value to the `then` value's type, and finish the `else`
// block.
// TODO: Find a common type, and convert both operands to it instead.
auto result_type_id = context.semantics_ir().GetNode(then_value_id).type_id();
else_value_id =
context.ConvertToValueOfType(else_node, else_value_id, result_type_id);
auto else_end_block_id = context.node_block_stack().Pop();
// Create a resumption block and branches to it.
auto chosen_value_id = context.AddConvergenceBlockWithArgAndPush(
if_node,
{{then_end_block_id, then_value_id}, {else_end_block_id, else_value_id}});
context.AddCurrentCodeBlockToFunction();
// Push the result value.
context.node_stack().Push(else_node, chosen_value_id);
return true;
}
} // namespace Carbon::Check