mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-29 09:24:58 +01:00
Adrien Leravat
df289efac4
### Features * Add virtual `destructor`s support (Closes #2521) * Check virtual override for virtual destructors * Error if attempting to `Delete` a class that does not have virtual destructors from a base class pointer ### Implementation * Update parser to support virtual override introducers for destructors * Check virtual override for class destructor and add to class vtable if necessary * Add corresponding tests ### Notes Contrary to initial implementation, this implementation leverages the `Address` structure and implements a new `Address::DowncastedAddress()` method to get address from child most class from a base class address. This avoids the need to use `GetAllocationId` and its issues when it comes to having multiple values for an `AllocationId`. ### Next work Following this PR, we need to: * Check when using `Delete` that the class was allocated with `New` (WIP) * Drop the old `GetAllocationId(Value*)` in favor of a better system (WIP)
24 lines
675 B
Plaintext
24 lines
675 B
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
// RUN: %{not} %{explorer-run}
|
|
// RUN: %{not} %{explorer-run-trace}
|
|
|
|
package ExplorerTest api;
|
|
|
|
|
|
base class A {
|
|
virtual destructor[self: Self]{}
|
|
}
|
|
|
|
class B extends A {
|
|
// CHECK:STDERR: COMPILATION ERROR: {{.*}}/explorer/testdata/destructor/fail_override_virtual_virtual.carbon:[[@LINE+1]]: Error declaring destructor for `B`: use `impl` to implement virtual destructor in child class.
|
|
virtual destructor[self: Self]{}
|
|
}
|
|
|
|
fn Main() -> i32 {
|
|
return 0;
|
|
}
|