mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
61 lines
2.3 KiB
C++
61 lines
2.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include <cstring>
|
|
|
|
#include "common/check.h"
|
|
#include "llvm/ADT/StringRef.h"
|
|
#include "testing/fuzzing/libfuzzer.h"
|
|
#include "toolchain/base/value_store.h"
|
|
#include "toolchain/diagnostics/null_diagnostics.h"
|
|
#include "toolchain/lex/lex.h"
|
|
|
|
namespace Carbon::Testing {
|
|
|
|
// NOLINTNEXTLINE: Match the documented fuzzer entry point declaration style.
|
|
extern "C" int LLVMFuzzerTestOneInput(const unsigned char* data,
|
|
std::size_t size) {
|
|
// Ignore large inputs.
|
|
// TODO: Investigate replacement with an error limit. Content with errors on
|
|
// escaped quotes (`\"` repeated) have O(M * N) behavior for M errors in a
|
|
// file length N, so either that will need to also be fixed or M will need to
|
|
// shrink for large (1MB+) inputs.
|
|
// This also affects parse/parse_fuzzer.cpp.
|
|
if (size > 100000) {
|
|
return 0;
|
|
}
|
|
static constexpr llvm::StringLiteral TestFileName = "test.carbon";
|
|
llvm::vfs::InMemoryFileSystem fs;
|
|
llvm::StringRef data_ref(reinterpret_cast<const char*>(data), size);
|
|
CARBON_CHECK(fs.addFile(
|
|
TestFileName, /*ModificationTime=*/0,
|
|
llvm::MemoryBuffer::getMemBuffer(data_ref, /*BufferName=*/TestFileName,
|
|
/*RequiresNullTerminator=*/false)));
|
|
auto source =
|
|
SourceBuffer::MakeFromFile(fs, TestFileName, NullDiagnosticConsumer());
|
|
|
|
SharedValueStores value_stores;
|
|
auto buffer = Lex::Lex(value_stores, *source, NullDiagnosticConsumer());
|
|
if (buffer.has_errors()) {
|
|
return 0;
|
|
}
|
|
|
|
// Walk the lexed and tokenized buffer to ensure it isn't corrupt in some way.
|
|
//
|
|
// TODO: We should enhance this to do more sanity checks on the resulting
|
|
// token stream.
|
|
for (Lex::TokenIndex token : buffer.tokens()) {
|
|
int line_number = buffer.GetLineNumber(token);
|
|
CARBON_CHECK(line_number > 0) << "Invalid line number!";
|
|
CARBON_CHECK(line_number < INT_MAX) << "Invalid line number!";
|
|
int column_number = buffer.GetColumnNumber(token);
|
|
CARBON_CHECK(column_number > 0) << "Invalid line number!";
|
|
CARBON_CHECK(column_number < INT_MAX) << "Invalid line number!";
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
} // namespace Carbon::Testing
|