mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 19:30:12 +01:00

Files

T

Chandler Carruth 8c64f0bfdd Add -Wmissing-prototypes and fix issues it finds. (#4019 )

Most of these are places where we failed to include a header file and
simply never got an error about this. The fix is to include the header
file.

Most other cases are functions that should have been marked `static` but
were not. Finding all of these was a main motivation for me enabling the
warning despite how much work it is.

One complicating factor was that we weren't including the `handle.h` for
all the state-based handler functions. While this isn't a tiny amount of
code, it is just declarations and doesn't add any extra dependencies. It
also lets us have the checking for which functions need to be `static`
and which don't. For the `parse` library I had to add the `handle.h`
header as well, I tried to match the design of it in `check`.

I have also had to work around a bug in the warning, but given the value
it seems to be providing, that seems reasonable. I've filed the bug
upstream: https://github.com/llvm/llvm-project/issues/94138

I also had to use some hacks to work around limitations of Bazel rules
that wrap `cc_library` rules and don't expose `copts`. I filed a bug for
`cc_proto_library` specifically:
~https://github.com/bazelbuild/bazel/issues/22610~ 
https://github.com/bazelbuild/bazel/issues/4446

2024-06-04 20:04:45 +00:00

queries

treesitter: add more highlight rules (#3036 )

2023-07-28 19:15:53 +00:00

src

Add -Wmissing-prototypes and fix issues it finds. (#4019 )

2024-06-04 20:04:45 +00:00

testdata/string

treesitter: implement strings completely (#3007 )

2023-07-27 20:34:17 +00:00

.gitignore

Treesitter parser (#2902 )