mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:30:14 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
62 lines
2.1 KiB
C++
62 lines
2.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/parse/parse.h"
|
|
|
|
#include "common/check.h"
|
|
#include "toolchain/base/pretty_stack_trace_function.h"
|
|
#include "toolchain/parse/context.h"
|
|
#include "toolchain/parse/handle.h"
|
|
#include "toolchain/parse/node_kind.h"
|
|
|
|
namespace Carbon::Parse {
|
|
|
|
auto HandleInvalid(Context& context) -> void {
|
|
CARBON_FATAL() << "The Invalid state shouldn't be on the stack: "
|
|
<< context.PopState();
|
|
}
|
|
|
|
auto Parse(Lex::TokenizedBuffer& tokens, DiagnosticConsumer& consumer,
|
|
llvm::raw_ostream* vlog_stream) -> Tree {
|
|
Lex::TokenDiagnosticConverter converter(&tokens);
|
|
Lex::TokenDiagnosticEmitter emitter(converter, consumer);
|
|
|
|
// Delegate to the parser.
|
|
Tree tree(tokens);
|
|
Context context(tree, tokens, emitter, vlog_stream);
|
|
PrettyStackTraceFunction context_dumper(
|
|
[&](llvm::raw_ostream& output) { context.PrintForStackDump(output); });
|
|
|
|
context.AddLeafNode(NodeKind::FileStart,
|
|
context.ConsumeChecked(Lex::TokenKind::FileStart));
|
|
|
|
context.PushState(State::DeclScopeLoop);
|
|
|
|
while (!context.state_stack().empty()) {
|
|
switch (context.state_stack().back().state) {
|
|
#define CARBON_PARSE_STATE(Name) \
|
|
case State::Name: \
|
|
Handle##Name(context); \
|
|
break;
|
|
#include "toolchain/parse/state.def"
|
|
}
|
|
}
|
|
|
|
context.AddLeafNode(NodeKind::FileEnd, *context.position());
|
|
|
|
if (auto verify = tree.Verify(); !verify.ok()) {
|
|
// TODO: This is temporarily printing to stderr directly during development.
|
|
// If we can, restrict this to a subtree with the error and add it to the
|
|
// stack trace (such as with PrettyStackTraceFunction). Otherwise, switch
|
|
// back to vlog_stream prior to broader distribution so that end users are
|
|
// hopefully comfortable copy-pasting stderr when there are bugs in tree
|
|
// construction.
|
|
tree.Print(llvm::errs());
|
|
CARBON_FATAL() << "Invalid tree returned by Parse(): " << verify.error();
|
|
}
|
|
return tree;
|
|
}
|
|
|
|
} // namespace Carbon::Parse
|