Nicholas Bishop afd679129d Fix crash from accessing a Check::Context during lowering (#7335) ...

In generate_ast.cpp, an `CarbonExternalASTSource` is installed that has
a `Check::Context` pointer. During lowering, this `ExternalASTSource` is
still installed, and using it can cause a crash if the now-invalid
pointer is dereferenced.

Fix by adding a new `ReadOnlyASTSource` in sem_ir, and using that during
lowering.

`CarbonExternalASTSource` now inherits from `ReadOnlyASTSource` to avoid
some code duplication.

In generate_ast.cpp, we now always install a multiplex source, even if
there's only one child source. Clang internally keeps pointers to the
top-level `ExternalASTSource` installed via `setExternalSource`, and
those pointers aren't updated if `setExternalSource` is called again. By
using `MultiplexExternalSemaSource`, we can keep the top-level
`ExternalASTSource` pointer the same, and only update its children.

Using `MultiplexExternalSemaSource` this way requires a new constructor
and a method to modify its child sources; added a new LLVM patch adding
those.

https://github.com/carbon-language/carbon-lang/issues/7142

2026-06-12 18:05:19 +00:00

..

cpp

Fix crash from accessing a Check::Context during lowering (#7335)

2026-06-12 18:05:19 +00:00

fuzzer_corpus

Change array syntax from [T; N] to array(T, N) (#4981)

2025-02-20 22:42:47 +00:00

testdata

Don't form a bound method when calling a C++ operator. (#7345)

2026-06-11 21:49:20 +00:00

action.cpp

Implement BundleStore (#7173)

2026-05-07 19:42:23 +00:00

action.h

Replace form insts with actions (#7100)

2026-04-29 18:13:42 +00:00

BUILD

Fix crash from accessing a Check::Context during lowering (#7335)

2026-06-12 18:05:19 +00:00

call.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

call.h

Don't require ref tags in thunks (#7115)

2026-04-29 18:33:53 +00:00

check_fuzzer.cpp

Switch Driver back to parameters for construction (#4849)

2025-01-27 23:48:44 +00:00

check_unit.cpp

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

check_unit.h

Add a text mode for fingerprinting. (#7231)

2026-05-19 23:16:51 +00:00

check.cpp

Add a text mode for fingerprinting. (#7231)

2026-05-19 23:16:51 +00:00

check.h

Add a text mode for fingerprinting. (#7231)

2026-05-19 23:16:51 +00:00

class.cpp

Add FieldStore and fix field initializer imports (#7287)

2026-06-01 19:02:01 +00:00

class.h

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

context.cpp

Add a text mode for fingerprinting. (#7231)

2026-05-19 23:16:51 +00:00

context.h

Remove CppGlobalVarStore (#7309)

2026-06-05 02:07:46 +00:00

control_flow.cpp

Introduce typed-inst accessors for ConstantValueStore (#6980)

2026-03-27 21:41:04 +00:00

control_flow.h

Handle destruction for return statements (#5785)

2025-07-10 16:32:39 +00:00

convert.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

convert.h

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

core_identifier.cpp

Add well-known identifier caching (#6486)

2025-12-11 21:41:47 +00:00

core_identifier.def

Support for float <-> float conversions. (#7279)

2026-06-04 00:33:33 +00:00

core_identifier.h

Add well-known identifier caching (#6486)

2025-12-11 21:41:47 +00:00

custom_witness.cpp

Adapters should only be destroyable if their adapted type is destroyable (#7271)

2026-06-10 00:48:33 +00:00

custom_witness.h

Add Core.Destroy support for enums imported from C++ (#7267)

2026-05-29 22:42:12 +00:00

decl_introducer_state.h

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

decl_name_stack.cpp

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

decl_name_stack.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

deduce.cpp

Fix crash after anonymous generic binding deduction failure (#7330)

2026-06-11 19:20:22 +00:00

deduce.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

deferred_definition_worklist.cpp

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

deferred_definition_worklist.h

Reimplement derived class thunk in terms of down-casting (#7322)

2026-06-09 21:10:18 +00:00

diagnostic_emitter.cpp

Support for locations in transitively imported C++ code (#7093)

2026-04-23 20:11:04 +00:00

diagnostic_emitter.h

Drop "diagnostic" from some filenames in the "diagnostics" folder (#6686)

2026-02-04 17:24:55 +00:00

diagnostic_helpers.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

dump.cpp

Support dumping ImportIRInstIds (#7328)

2026-06-09 22:17:18 +00:00

eval_inst.cpp

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

eval_inst.h

Replace form insts with actions (#7100)

2026-04-29 18:13:42 +00:00

eval.cpp

Implement Core.CharLiteral operations from #6710 and #7314 (#7316)

2026-06-11 16:45:39 +00:00

eval.h

Have Specific track whether regions contain errors (#6982)

2026-03-27 19:36:52 +00:00

facet_type.cpp

Handle errors and non-constant instructions when substituting non-canonical instructions (#7262)

2026-05-27 15:43:41 +00:00

facet_type.h

Properly diagnose ambiguous .Self in T impls X where... (#7132)

2026-05-01 21:22:32 +00:00

full_pattern_stack.h

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

function.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

function.h

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

generic_region_stack.cpp

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

generic_region_stack.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

generic.cpp

Have Specific track whether regions contain errors (#6982)

2026-03-27 19:36:52 +00:00

generic.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

global_init.cpp

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

global_init.h

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

handle_alias.cpp

Remove trailing () from Core.*Literal and Core.Bool. (#7313)

2026-06-05 22:33:30 +00:00

handle_array.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_binding_pattern.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

handle_call_expr.cpp

Parse ref as operator (#6539)

2025-12-30 19:18:34 +00:00

handle_choice.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

handle_class.cpp

Factor out definition merging logic. (#7154)

2026-05-01 22:45:22 +00:00

handle_codeblock.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

handle_export.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_expr_statement.cpp

Convert discarded calls in thunks. (#5452)

2025-05-09 16:35:28 +00:00

handle_file.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_form_literal.cpp

Remove InitForm::index (#6817)

2026-03-06 17:35:48 +00:00

handle_function.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

handle_if_expr.cpp

Simplify type check. (#7155)

2026-05-01 18:46:52 +00:00

handle_if_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_impl.cpp

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

handle_import_and_package.cpp

Add support for inline Cpp declarations. (#6994)

2026-03-31 22:27:43 +00:00

handle_index.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

handle_inline_decl.cpp

Fix crash if initializing Clang fails. (#7248)

2026-05-21 21:21:50 +00:00

handle_interface.cpp

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

handle_lambda.cpp

[parse] Implement initial parsing support for Lambda expressions (#6583)

2026-01-14 16:58:15 +00:00

handle_let_and_var.cpp

Add support for field initializers (#7238)

2026-05-22 02:48:07 +00:00

handle_literal.cpp

Implement Core.CharLiteral operations from #6710 and #7314 (#7316)

2026-06-11 16:45:39 +00:00

handle_loop_statement.cpp

Import non-const rvalue references as var parameters. (#7125)

2026-04-29 00:28:00 +00:00

handle_match.cpp

Refactor match parse nodes. (#6870)

2026-03-10 20:04:28 +00:00

handle_modifier.cpp

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

handle_name.cpp

Add support for ->? return forms (#6849)

2026-03-09 22:30:16 +00:00

handle_named_constraint.cpp

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

handle_namespace.cpp

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

handle_noop.cpp

Abort checking when encountering an invalid parse node (#4700)

2024-12-18 00:19:12 +00:00

handle_observe.cpp

Implement parsing observe declarations (#6674)

2026-02-26 19:21:19 +00:00

handle_operator.cpp

Fix initialization of var parameters. (#7023)

2026-04-28 20:10:13 +00:00

handle_paren_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_pattern_list.cpp

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

handle_require.cpp

Resolve cycles in .Self replacement in nested designators (#7183)

2026-05-13 16:11:20 +00:00

handle_return_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_struct.cpp

Simplify struct literal pop loop. (#7158)

2026-05-02 01:09:50 +00:00

handle_tuple_literal.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

handle_where.cpp

Remove TODO in impls handler that is already done (#7305)

2026-06-04 20:47:07 +00:00

handle.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

impl_lookup.cpp

Allow witnesses to come from a facet with partially identified type in the lookup target (#7260)

2026-05-25 23:02:06 +00:00

impl_lookup.h

Replace .Self in facet types (#7097)

2026-04-24 19:08:11 +00:00

impl_validation.cpp

Diagnose overlapping impls in the api/impl files of the same library (#7164)

2026-05-06 14:17:54 +00:00

impl_validation.h

Add diagnostics for invalid impl declarations (#5420)

2025-05-22 18:58:47 +00:00

impl.cpp

Support signature mismatch between virtual fn and override fn. (#7198)

2026-05-13 17:40:45 +00:00

impl.h

Resolve cycles in .Self replacement in nested designators (#7183)

2026-05-13 16:11:20 +00:00

import_ref.cpp

Use clang_decls as the source of truth for function interop mapping (#7303)

2026-06-04 23:16:11 +00:00

import_ref.h

When performing an impl lookup, only import impls for related interfaces. (#6040)

2025-09-10 21:40:27 +00:00

import.cpp

Fix cross-package signature mismatches. (#7232)

2026-05-21 00:02:29 +00:00

import.h

Add MakeVerifiedLocIdAndInst for runtime validation (#6942)

2026-03-24 20:56:44 +00:00

inst_block_stack.cpp

Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)

2025-03-21 23:09:37 +00:00

inst_block_stack.h

Add require decls to Interface and NamedConstraint (#6321)

2025-11-11 16:36:15 +00:00

inst.cpp

Replace form insts with actions (#7100)

2026-04-29 18:13:42 +00:00

inst.h

Get rid of AddPatternInst (#7075)

2026-04-16 23:31:31 +00:00

interface.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

interface.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

keyword_modifier_set.cpp

Some more edits to EnumBase and EnumMaskBase (#6054)

2025-09-12 22:59:37 +00:00

keyword_modifier_set.h

Implement static var class fields (#7215)

2026-05-18 20:09:17 +00:00

lexical_lookup.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

literal.cpp

Remove trailing () from Core.*Literal and Core.Bool. (#7313)

2026-06-05 22:33:30 +00:00

literal.h

Add a type_literal instruction to represent syntactic type literals. (#6781)

2026-02-26 20:10:50 +00:00

member_access.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

member_access.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

merge.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

merge.h

Reimplement derived class thunk in terms of down-casting (#7322)

2026-06-09 21:10:18 +00:00

modifiers.cpp

Support unqualified lookup into extended interfaces from classes and impls (#7217)

2026-05-19 18:01:54 +00:00

modifiers.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

name_component.cpp

Restructure return declaration handling (#7076)

2026-04-22 23:38:21 +00:00

name_component.h

Restructure return declaration handling (#7076)

2026-04-22 23:38:21 +00:00

name_lookup.cpp

Don't perform access-control checks on namespace-scope entities. (#7310)

2026-06-05 23:30:09 +00:00

name_lookup.h

Don't re-require complete types for extended scopes (#7194)

2026-05-13 17:16:02 +00:00

name_ref.cpp

Fix lowering of thunks in generic impls (#5631)

2025-06-10 20:54:58 +00:00

name_ref.h

Fix lowering of thunks in generic impls (#5631)

2025-06-10 20:54:58 +00:00

name_scope.cpp

Diagnose explicit Self in extend in the parse node handler (Refactor Impl construction 1/7) (#6465)

2025-12-09 20:38:50 +00:00

name_scope.h

Diagnose explicit Self in extend in the parse node handler (Refactor Impl construction 1/7) (#6465)

2025-12-09 20:38:50 +00:00

node_id_traversal.cpp

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

node_id_traversal.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

node_stack.cpp

Use lines instead of statements for readability-function-size clang-tidy (#6594)

2026-01-14 19:32:03 +00:00

node_stack.h

Parse vars in classes the same as vars in other locations (#7188)

2026-05-13 21:22:46 +00:00

operator.cpp

Don't form a bound method when calling a C++ operator. (#7345)

2026-06-11 21:49:20 +00:00

operator.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

param_and_arg_refs_stack.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

pattern_match.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

pattern_match.h

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

pattern.cpp

Support for mapping array types to/from C++. (#7285)

2026-06-01 21:55:16 +00:00

pattern.h

Support for mapping array types to/from C++. (#7285)

2026-06-01 21:55:16 +00:00

pending_block.h

Fix crash if an inst in a pending block needs a cleanup. (#7166)

2026-05-04 21:50:13 +00:00

period_self.cpp

Avoid replacing .Self in designators more robustly in rewrite constraints (#7202)

2026-05-13 18:24:31 +00:00

period_self.h

Avoid replacing .Self in designators more robustly in rewrite constraints (#7202)

2026-05-13 18:24:31 +00:00

pointer_dereference.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

pointer_dereference.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

region_stack.h

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

require_impls_stack.cpp

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

require_impls_stack.h

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

return.cpp

Fix crash lowering reference return. (#7301)

2026-06-04 15:51:28 +00:00

return.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

scope_index.h

Use inline constexpr where appropriate. (#6374)

2025-11-14 13:50:56 +00:00

scope_stack.cpp

Fix crash when calling local function in generic function (#6912)

2026-06-02 16:27:21 +00:00

scope_stack.h

Detect impl redecls in non-declarative scopes (#7170)

2026-05-07 13:44:40 +00:00

subst.cpp

Handle errors and non-constant instructions when substituting non-canonical instructions (#7262)

2026-05-27 15:43:41 +00:00

subst.h

Finish renaming BindName and related insts. (#6281)

2025-10-28 17:17:38 +00:00

thunk.cpp

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

thunk.h

Reimplement derived class thunk in terms of down-casting (#7322)

2026-06-09 21:10:18 +00:00

type_completion.cpp

Replace .Self in the self type of T(.Self) impls NamedConstraint when identifying a facet type (#7204)

2026-05-13 18:49:02 +00:00

type_completion.h

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

type_structure.cpp

Correctly handle ImplWitnessAccess in impl lookup (#7181)

2026-05-11 14:17:18 +00:00

type_structure.h

Search all facets in the impl lookup query for witnesses (#7178)

2026-05-07 22:33:47 +00:00

type.cpp

Support for mapping array types to/from C++. (#7285)

2026-06-01 21:55:16 +00:00

type.h

Support for mapping array types to/from C++. (#7285)

2026-06-01 21:55:16 +00:00

unused.cpp

Clean up some of the TODOs in unused.carbon (#6794)

2026-02-26 18:57:15 +00:00

unused.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00