mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 04:38:13 +00:00
Continuing on #3070. I moved ParseTree::Node to just Parse::Node, versus Parse::Tree::Node. Other name changes are just removing "Parse" or "Parser" prefixes. In EnumBase, I'm directly defining operator<< because the ostream.h approach just isn't working, not for either of Parse::State nor Parse::NodeKind. Errors look like: ```toolchain/parser/parser_context.cpp:449:34: error: invalid operands to binary expression ('llvm::raw_ostream' and 'const Carbon::Parse::State') output << "\t" << i << ".\t" << entry.state; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ ``` The expected template in `Carbon::` is not in the error list; I only see the: ``` ./common/ostream.h:112:6: note: candidate template ignored: requirement 'std::is_base_of_v<std::ostream, llvm::raw_ostream>' was not satisfied [with S = llvm::raw_ostream, T = Carbon::Parse::State] auto operator<<(S& standard_out, const T& value) -> S& { ^ ``` I'm still prodding at this, but not seeing an obvious fix. --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk>
56 lines
2.1 KiB
C++
56 lines
2.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/parser/parse_node_kind.h"
|
|
#include "toolchain/semantics/semantics_context.h"
|
|
#include "toolchain/semantics/semantics_node.h"
|
|
#include "toolchain/semantics/semantics_node_kind.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
auto HandleArrayExpressionStart(Context& /*context*/,
|
|
Parse::Node /*parse_node*/) -> bool {
|
|
return true;
|
|
}
|
|
|
|
auto HandleArrayExpressionSemi(Context& context, Parse::Node parse_node)
|
|
-> bool {
|
|
context.node_stack().Push(parse_node);
|
|
return true;
|
|
}
|
|
|
|
auto HandleArrayExpression(Context& context, Parse::Node parse_node) -> bool {
|
|
// TODO: Handle array type with undefined bound.
|
|
if (context.parse_tree().node_kind(context.node_stack().PeekParseNode()) ==
|
|
Parse::NodeKind::ArrayExpressionSemi) {
|
|
context.node_stack().PopAndIgnore();
|
|
context.node_stack().PopAndIgnore();
|
|
return context.TODO(parse_node, "HandleArrayExpressionWithoutBounds");
|
|
}
|
|
|
|
auto bound_node_id = context.node_stack().PopExpression();
|
|
context.node_stack()
|
|
.PopAndDiscardSoloParseNode<Parse::NodeKind::ArrayExpressionSemi>();
|
|
auto element_type_node_id = context.node_stack().PopExpression();
|
|
auto bound_node = context.semantics_ir().GetNode(bound_node_id);
|
|
if (bound_node.kind() == SemIR::NodeKind::IntegerLiteral) {
|
|
auto bound_value = context.semantics_ir().GetIntegerLiteral(
|
|
bound_node.GetAsIntegerLiteral());
|
|
if (!bound_value.isNegative()) {
|
|
context.AddNodeAndPush(
|
|
parse_node,
|
|
SemIR::Node::ArrayType::Make(
|
|
parse_node, SemIR::TypeId::TypeType, bound_node_id,
|
|
context.ExpressionAsType(parse_node, element_type_node_id)));
|
|
return true;
|
|
}
|
|
}
|
|
CARBON_DIAGNOSTIC(InvalidArrayExpression, Error, "Invalid array expression.");
|
|
context.emitter().Emit(parse_node, InvalidArrayExpression);
|
|
context.node_stack().Push(parse_node, SemIR::NodeId::BuiltinError);
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon::Check
|