mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:30:14 +01:00
Jon Ross-Perkins
acbe6530c3
What this really does is avoids shadowing names, so that we can comfortable have things like `Check::DiagnosticEmitter` or `Check::DiagnosticLoc` without shadowing being a concern. Note, down this path I'm also thinking about: - Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly just to DiagnosticConsumer/DiagnosticEmitter (so `Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`). - Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`. - But not for `Check::DiagnosticBuilder`, because `Check::Builder` would be ambiguous. - Renaming diagnostics/diagnostic_* to drop "diagnostic". [Discussion about SemIRLoc -> DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698) reminded me of this (in particular the older [Check::DiagnosticBuilder discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)), but I'd only do that rename if there's matching consensus about a path forward where we keep SemIRLoc, and in a way that it's only ever used for diagnostics (the divergence from which is at the root of current LocId discussion). I'm trying to keep that separate from a namespace addition for clarity.
38 lines
1000 B
C++
38 lines
1000 B
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/diagnostics/mocks.h"
|
|
|
|
namespace Carbon::Diagnostics {
|
|
|
|
auto PrintTo(const Diagnostic& diagnostic, std::ostream* os) -> void {
|
|
*os << "Diagnostic{";
|
|
PrintTo(diagnostic.level, os);
|
|
for (const auto& message : diagnostic.messages) {
|
|
*os << ", {" << message.loc.filename << ":" << message.loc.line_number
|
|
<< ":" << message.loc.column_number << ", \"" << message.Format()
|
|
<< "}";
|
|
}
|
|
*os << "\"}";
|
|
}
|
|
|
|
auto PrintTo(Level level, std::ostream* os) -> void {
|
|
switch (level) {
|
|
case Level::LocationInfo:
|
|
*os << "LocationInfo";
|
|
break;
|
|
case Level::Note:
|
|
*os << "Note";
|
|
break;
|
|
case Level::Warning:
|
|
*os << "Warning";
|
|
break;
|
|
case Level::Error:
|
|
*os << "Error";
|
|
break;
|
|
}
|
|
}
|
|
|
|
} // namespace Carbon::Diagnostics
|