carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity
Files
acbe6530c39c2240a883419a0ffa42e79cff50e0
carbon-lang/toolchain/check
T
History
Jon Ross-Perkins acbe6530c3 Move diagnostics into a namespace (#5173) 
What this really does is avoids shadowing names, so that we can
comfortable have things like `Check::DiagnosticEmitter` or
`Check::DiagnosticLoc` without shadowing being a concern.

Note, down this path I'm also thinking about:

- Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly
just to DiagnosticConsumer/DiagnosticEmitter (so
`Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`).
- Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`.
- But not for `Check::DiagnosticBuilder`, because `Check::Builder` would
be ambiguous.
- Renaming diagnostics/diagnostic_* to drop "diagnostic".

[Discussion about SemIRLoc ->
DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698)
reminded me of this (in particular the older [Check::DiagnosticBuilder
discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)),
but I'd only do that rename if there's matching consensus about a path
forward where we keep SemIRLoc, and in a way that it's only ever used
for diagnostics (the divergence from which is at the root of current
LocId discussion).

I'm trying to keep that separate from a namespace addition for clarity.
2025-03-26 19:12:10 +00:00
..
fuzzer_corpus
Change array syntax from [T; N] to array(T, N) (#4981)
2025-02-20 22:42:47 +00:00
testdata
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
action.cpp
Initial work on support for templates (#5081)
2025-03-19 20:19:21 +00:00
action.h
Initial work on support for templates (#5081)
2025-03-19 20:19:21 +00:00
BUILD
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
call.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
call.h
Use As and ImplicitAs interfaces for conversions. (#4209)
2024-09-05 23:39:58 +00:00
check_fuzzer.cpp
Switch Driver back to parameters for construction (#4849)
2025-01-27 23:48:44 +00:00
check_unit.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
check_unit.h
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
check.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
check.h
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
context.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
context.h
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
control_flow.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
control_flow.h
Move control flow block functions to their own file. (#4921)
2025-02-11 21:38:09 +00:00
convert.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
convert.h
Avoid diagnosing conversion errors inside deduction of impl arguments (#4976)
2025-02-19 21:46:46 +00:00
decl_introducer_state.h
Add more empty stack verification (#5020)
2025-03-01 07:56:04 +00:00
decl_name_stack.cpp
Rewrite symbolic constants in generic redeclarations (#5154)
2025-03-21 22:26:08 +00:00
decl_name_stack.h
Rewrite symbolic constants in generic redeclarations (#5154)
2025-03-21 22:26:08 +00:00
deduce.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
deduce.h
Avoid UAF in impl lookup when deduce imports an impl from Core (#5126)
2025-03-14 00:44:51 +00:00
deferred_definition_worklist.cpp
Split deferred node traversal out from check.cpp (#4559)
2024-11-20 20:58:58 +00:00
deferred_definition_worklist.h
Split deferred node traversal out from check.cpp (#4559)
2024-11-20 20:58:58 +00:00
diagnostic_helpers.h
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
dump.cpp
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
eval_inst.cpp
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
eval_inst.h
Initial work on support for templates (#5081)
2025-03-19 20:19:21 +00:00
eval.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
eval.h
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
facet_type.cpp
Add TypeId::is_symbolic and is_concrete. (#5024)
2025-02-27 00:21:01 +00:00
facet_type.h
First iteration of completing and resolving facet types (#4920)
2025-02-19 22:10:11 +00:00
full_pattern_stack.h
Clean up handling of Call params (#5061)
2025-03-04 21:01:59 +00:00
function.cpp
Add error for virtual member function without self (#5005)
2025-02-27 17:01:29 +00:00
function.h
Add error for virtual member function without self (#5005)
2025-02-27 17:01:29 +00:00
generic_region_stack.cpp
Create an array stack type for a shared use-case (#4100)
2024-07-03 16:58:47 +00:00
generic_region_stack.h
Add more empty stack verification (#5020)
2025-03-01 07:56:04 +00:00
generic.cpp
Rebuild the type of a bind_symbolic_name when building an eval block (#5174)
2025-03-25 22:53:25 +00:00
generic.h
Rewrite symbolic constants in generic redeclarations (#5154)
2025-03-21 22:26:08 +00:00
global_init.cpp
[Refactor] Move call_params_id from EntityBase to FunctionFields. (#5146)
2025-03-18 23:49:24 +00:00
global_init.h
Split global init out from InstBlockStack. (#4101)
2024-07-03 17:49:47 +00:00
handle_alias.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_array.cpp
Change array syntax from [T; N] to array(T, N) (#4981)
2025-02-20 22:42:47 +00:00
handle_binding_pattern.cpp
Reduce explicit SemIR::LocIdAndInst construction (#5153)
2025-03-21 21:45:53 +00:00
handle_call_expr.cpp
Include the call arguments in the location of a call. (#4602)
2024-12-02 18:51:44 +00:00
handle_choice.cpp
Reduce explicit SemIR::LocIdAndInst construction (#5153)
2025-03-21 21:45:53 +00:00
handle_class.cpp
Rewrite symbolic constants in generic redeclarations (#5154)
2025-03-21 22:26:08 +00:00
handle_codeblock.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_export.cpp
Fix crash when exporting a poisoned name (#5074)
2025-03-05 21:55:30 +00:00
handle_expr_statement.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_file.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_function.cpp
Rewrite symbolic constants in generic redeclarations (#5154)
2025-03-21 22:26:08 +00:00
handle_if_expr.cpp
Refactor region_stack logic out of Context (#4927)
2025-02-12 00:21:07 +00:00
handle_if_statement.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_impl.cpp
Rewrite symbolic constants in generic redeclarations (#5154)
2025-03-21 22:26:08 +00:00
handle_import_and_package.cpp
Implement #4864: Core is a keyword (#4909)
2025-02-11 21:33:57 +00:00
handle_index.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_interface.cpp
Rewrite symbolic constants in generic redeclarations (#5154)
2025-03-21 22:26:08 +00:00
handle_let_and_var.cpp
Reduce explicit SemIR::LocIdAndInst construction (#5153)
2025-03-21 21:45:53 +00:00
handle_literal.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
handle_loop_statement.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_match.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_modifier.cpp
Remove obsolete '...' hints on node kind macros (#4958)
2025-02-15 01:36:46 +00:00
handle_name.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
handle_named_constraint.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_namespace.cpp
Reduce explicit SemIR::LocIdAndInst construction (#5153)
2025-03-21 21:45:53 +00:00
handle_noop.cpp
Abort checking when encountering an invalid parse node (#4700)
2024-12-18 00:19:12 +00:00
handle_operator.cpp
Add parsing for partial types (#5009)
2025-02-25 02:07:10 +00:00
handle_paren_expr.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_pattern_list.cpp
Support tuple patterns outside parameter lists (#4923)
2025-02-20 03:17:45 +00:00
handle_return_statement.cpp
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
handle_struct.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
handle_tuple_literal.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
handle_where.cpp
Add TypeId::is_symbolic and is_concrete. (#5024)
2025-02-27 00:21:01 +00:00
handle.h
Rename check handlers to HandleParseNode overloads. (#4121)
2024-07-12 22:38:06 +00:00
impl_lookup.cpp
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
impl_lookup.h
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
impl.cpp
Renumber inner parameters when checking an impl function against an interface function. (#5113)
2025-03-12 13:54:49 +00:00
impl.h
First iteration of completing and resolving facet types (#4920)
2025-02-19 22:10:11 +00:00
import_cpp.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
import_cpp.h
Add support for importing a trivial global C++ function (#5033)
2025-03-03 10:38:19 +00:00
import_ref.cpp
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
import_ref.h
When diagnosing a duplicated name, add the name to the diagnosis (#4902)
2025-02-19 07:19:23 +00:00
import.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
import.h
Add support for importing C++ namespaces (#5103)
2025-03-15 20:41:48 +00:00
inst_block_stack.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
inst_block_stack.h
Invalid comment cleanup (#4836)
2025-01-23 02:21:48 +00:00
inst.cpp
Initial work on support for templates (#5081)
2025-03-19 20:19:21 +00:00
inst.h
Reduce explicit SemIR::LocIdAndInst construction (#5153)
2025-03-21 21:45:53 +00:00
interface.cpp
Renumber inner parameters when checking an impl function against an interface function. (#5113)
2025-03-12 13:54:49 +00:00
interface.h
Renumber inner parameters when checking an impl function against an interface function. (#5113)
2025-03-12 13:54:49 +00:00
keyword_modifier_set.h
Treat associated constants as entities parameterized by Self (#4837)
2025-01-25 02:13:52 +00:00
lexical_lookup.h
Refactor value store code to use separate files. (#4477)
2024-11-04 04:00:17 +00:00
literal.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
literal.h
Factor out machinery for forming int type literals. (#4616)
2024-12-03 18:46:27 +00:00
member_access.cpp
Never perform instance binding with implicit Self in an interface (#5121)
2025-03-20 04:25:35 +00:00
member_access.h
Never perform instance binding with implicit Self in an interface (#5121)
2025-03-20 04:25:35 +00:00
merge.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
merge.h
Add error for virtual member function without self (#5005)
2025-02-27 17:01:29 +00:00
modifiers.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
modifiers.h
Refactor modifier formatting to remove string passing. (#4418)
2024-10-17 22:47:40 +00:00
name_component.cpp
Fix parse support for 'fn F[];' (#5135)
2025-03-18 00:31:17 +00:00
name_component.h
Id::Invalid -> Id::None (#4834)
2025-01-22 23:15:00 +00:00
name_lookup.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
name_lookup.h
When diagnosing a duplicated name, add the name to the diagnosis (#4902)
2025-02-19 07:19:23 +00:00
node_id_traversal.cpp
Id::Invalid -> Id::None (#4834)
2025-01-22 23:15:00 +00:00
node_id_traversal.h
Id::Invalid -> Id::None (#4834)
2025-01-22 23:15:00 +00:00
node_stack.cpp
Avoid redundantly specifying Id::Kind. (#4911)
2025-02-07 22:35:18 +00:00
node_stack.h
Fix use of keyword names in qualifiers with params (#5130)
2025-03-14 20:16:01 +00:00
operator.cpp
Move diagnostic usings off Context (#5007)
2025-02-26 18:44:36 +00:00
operator.h
Move diagnostic usings off Context (#5007)
2025-02-26 18:44:36 +00:00
param_and_arg_refs_stack.h
Consolidate post-check logic (#5003)
2025-02-25 02:07:43 +00:00
pattern_match.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
pattern_match.h
Invalid comment cleanup (#4836)
2025-01-23 02:21:48 +00:00
pending_block.h
Reduce explicit SemIR::LocIdAndInst construction (#5153)
2025-03-21 21:45:53 +00:00
pointer_dereference.cpp
Refactor AddInst-family functions to their own file (#4941)
2025-02-14 19:44:36 +00:00
pointer_dereference.h
Handle arrow operator (#3768)
2024-03-18 17:40:00 +00:00
region_stack.h
Add more empty stack verification (#5020)
2025-03-01 07:56:04 +00:00
return.cpp
Move diagnostic usings off Context (#5007)
2025-02-26 18:44:36 +00:00
return.h
Model var as a pattern operator (#4720)
2025-01-17 17:51:34 +00:00
scope_index.h
Move None to IdBase (#5030)
2025-03-01 08:00:17 +00:00
scope_stack.cpp
Clean up handling of Call params (#5061)
2025-03-04 21:01:59 +00:00
scope_stack.h
Consolidate post-check logic (#5003)
2025-02-25 02:07:43 +00:00
sem_ir_loc_diagnostic_emitter.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
sem_ir_loc_diagnostic_emitter.h
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
subpattern.cpp
Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)
2025-03-21 23:09:37 +00:00
subpattern.h
Support tuple patterns outside parameter lists (#4923)
2025-02-20 03:17:45 +00:00
subst.cpp
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
subst.h
Rebuild the type of a bind_symbolic_name when building an eval block (#5174)
2025-03-25 22:53:25 +00:00
type_completion.cpp
Move diagnostics into a namespace (#5173)
2025-03-26 19:12:10 +00:00
type_completion.h
Associated constants can be used in member function signatures (#5089)
2025-03-12 00:33:46 +00:00
type_structure.cpp
Support specialization in impl lookup with a symbolic query/impl. (#5169)
2025-03-26 15:10:23 +00:00
type_structure.h
Deduce through FacetValue (#5158)
2025-03-20 23:52:50 +00:00
type.cpp
Move the EvalConstantInst overloads out of eval.cpp into their own file. (#5040)
2025-02-28 00:50:43 +00:00
type.h
Move the EvalConstantInst overloads out of eval.cpp into their own file. (#5040)
2025-02-28 00:50:43 +00:00