mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-03 22:02:51 +01:00
Jon Meow
6e5070de18
Notes versus what jsiek wrote:
- This adopts Bazel for building.
- System-local versions of bison/flex are used. I found https://github.com/jmillikin/rules_bison, but those print a lot of warnings (things like -Wsign-compare IIRC) which makes builds hard to read. Plus I think the underlying bison_cc_library rule didn't work, so this would really only get a hermetic bison/flex build (helpful, but didn't seem worth more time).
- I'm adding in a .bazeliskrc to push a somewhat more standard choice of bazel versions. I noticed I was getting unstable versions by default, possible Google-specific, but seemed good to include.
- The `-lpthread` kludge.
- Turn all of the examples into golden tests.
- Including adding a golden test rule.
- Fixed various style guide issues. For example:
- Fixing function names to be CamelCase instead of snake_case (https://google.github.io/styleguide/cppguide.html#Function_Names)
- Removed exception use (https://google.github.io/styleguide/cppguide.html#Exceptions)
- File name fixes (https://github.com/carbon-language/carbon-lang/blob/trunk/docs/project/cpp_style_guide.md#file-names)
- Dropped `using` of `std` names -- I believe this is preferred (maybe we should be explicit about this in the Carbon style guide)
- Switched `enum` uses to `enum class` for ease-of-identification.
- Spent some time breaking out files to hopefully be easier to read/edit pieces, and understand relations between structs.
- Added `code requires` to `syntax.ypp` to address include issues
Possibly other things -- but the fundamental structure is, I believe, unchanged. I put in the golden tests pretty early to ensure I wasn't mutating output/results.
108 lines
2.4 KiB
Python
108 lines
2.4 KiB
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
# TODO(https://github.com/carbon-language/carbon-lang/issues/266):
|
|
# Migrate bison/flex usage to a more hermetic bazel build.
|
|
|
|
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
|
|
load("//bazel/testing:golden_test.bzl", "golden_test")
|
|
|
|
cc_binary(
|
|
name = "executable_semantics",
|
|
srcs = ["main.cpp"],
|
|
deps = [":syntax"],
|
|
)
|
|
|
|
cc_library(
|
|
name = "syntax",
|
|
srcs = [
|
|
"syntax.tab.cpp",
|
|
"syntax.yy.cpp",
|
|
"syntax_helpers.cpp",
|
|
"syntax_helpers.h",
|
|
],
|
|
hdrs = ["syntax.tab.h"],
|
|
# Disable warnings for generated code.
|
|
copts = [
|
|
"-Wno-unneeded-internal-declaration",
|
|
"-Wno-unused-function",
|
|
"-Wno-writable-strings",
|
|
],
|
|
deps = [
|
|
"//executable_semantics/ast:declaration",
|
|
"//executable_semantics/ast:expression",
|
|
"//executable_semantics/ast:expression_or_field_list",
|
|
"//executable_semantics/interpreter",
|
|
],
|
|
)
|
|
|
|
genrule(
|
|
name = "syntax_bison_srcs",
|
|
srcs = ["syntax.ypp"],
|
|
outs = [
|
|
"syntax.tab.cpp",
|
|
"syntax.tab.h",
|
|
],
|
|
cmd = "bison " +
|
|
"--output=$(location syntax.tab.cpp) " +
|
|
"--defines=$(location syntax.tab.h) " +
|
|
"$(location syntax.ypp)",
|
|
)
|
|
|
|
genrule(
|
|
name = "syntax_flex_srcs",
|
|
srcs = ["syntax.lpp"],
|
|
outs = ["syntax.yy.cpp"],
|
|
cmd = "flex " +
|
|
"--outfile=$(location syntax.yy.cpp) " +
|
|
"$(location syntax.lpp)",
|
|
)
|
|
|
|
EXAMPLES = [
|
|
"block1",
|
|
"break1",
|
|
"choice1",
|
|
"continue1",
|
|
"fun_recur",
|
|
"fun1",
|
|
"fun2",
|
|
"fun3",
|
|
"fun4",
|
|
"fun5",
|
|
"fun6_fail_type",
|
|
"funptr1",
|
|
"match_int_default",
|
|
"match_int",
|
|
"match_type",
|
|
"next",
|
|
"pattern_init",
|
|
"record1",
|
|
"struct1",
|
|
"struct2",
|
|
"struct3",
|
|
"tuple_assign",
|
|
"tuple_match",
|
|
"tuple1",
|
|
"tuple2",
|
|
"undef1",
|
|
"undef2",
|
|
"while1",
|
|
"zero",
|
|
]
|
|
|
|
[genrule(
|
|
name = "%s_out" % e,
|
|
srcs = ["testdata/%s.6c" % e],
|
|
outs = ["testdata/%s.out" % e],
|
|
# Suppress command errors.
|
|
cmd = "$(location executable_semantics) $< > $@ 2>&1 || true",
|
|
tools = [":executable_semantics"],
|
|
) for e in EXAMPLES]
|
|
|
|
[golden_test(
|
|
name = "%s_test" % e,
|
|
golden = "testdata/%s.golden" % e,
|
|
subject = "testdata/%s.out" % e,
|
|
) for e in EXAMPLES]
|