mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
62 lines
1.7 KiB
C++
62 lines
1.7 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
// To convert a Carbon file to a text proto:
|
|
// `ast_to_proto <file.carbon>`
|
|
|
|
#include <google/protobuf/text_format.h>
|
|
|
|
#include <fstream>
|
|
#include <iostream>
|
|
#include <sstream>
|
|
|
|
#include "common/bazel_working_dir.h"
|
|
#include "common/error.h"
|
|
#include "explorer/ast/ast.h"
|
|
#include "explorer/base/arena.h"
|
|
#include "explorer/fuzzing/ast_to_proto.h"
|
|
#include "explorer/syntax/parse.h"
|
|
#include "testing/fuzzing/carbon.pb.h"
|
|
|
|
namespace Carbon::Testing {
|
|
|
|
static auto Main(int argc, char** argv) -> ErrorOr<Success> {
|
|
SetWorkingDirForBazel();
|
|
|
|
if (argc != 2) {
|
|
return Error("Syntax: ast_to_proto <file.carbon>");
|
|
}
|
|
if (!std::filesystem::is_regular_file(argv[1])) {
|
|
return Error("Argument must be a file.");
|
|
}
|
|
|
|
Arena arena;
|
|
const ErrorOr<AST> ast =
|
|
Parse(*llvm::vfs::getRealFileSystem(), &arena, argv[1], FileKind::Main,
|
|
/*parser_debug=*/false);
|
|
if (!ast.ok()) {
|
|
return ErrorBuilder() << "Parsing failed: " << ast.error().message();
|
|
}
|
|
Fuzzing::Carbon carbon_proto = AstToProto(*ast);
|
|
|
|
std::string proto_string;
|
|
google::protobuf::TextFormat::Printer p;
|
|
if (!p.PrintToString(carbon_proto, &proto_string)) {
|
|
return Error("Failed to convert to text proto");
|
|
}
|
|
std::cout << proto_string;
|
|
return Success();
|
|
}
|
|
|
|
} // namespace Carbon::Testing
|
|
|
|
auto main(int argc, char** argv) -> int {
|
|
auto err = Carbon::Testing::Main(argc, argv);
|
|
if (!err.ok()) {
|
|
std::cerr << err.error().message() << "\n";
|
|
return EXIT_FAILURE;
|
|
}
|
|
return EXIT_SUCCESS;
|
|
}
|