mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-03 09:15:49 +01:00
Jon Ross-Perkins
a196b9840f
This patches bazel_clang_tidy handling of headers. I found an equivalent change at https://github.com/erenon/bazel_clang_tidy/pull/13, but that was [already rejected](https://github.com/erenon/bazel_clang_tidy/pull/13#issuecomment-1047007424). Per the criticism, this will result in redundant processing of headers. The project instead uses `HeaderFilterRegex: ".*"`, but that results in two problems: 1. When running with `-k`, errors are repeated when a header is included more than once, which is common. 2. clang-tidy including errors from headers that are included from other modules (e.g., abseil-cpp); filtering correctly is difficult. Given the trade-offs and options (including forking), I thought patching was preferable so long as it remains narrow.
135 lines
2.8 KiB
Python
135 lines
2.8 KiB
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
|
|
|
|
package(default_visibility = ["//explorer:__subpackages__"])
|
|
|
|
cc_library(
|
|
name = "arena",
|
|
hdrs = ["arena.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":nonnull",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "arena_test",
|
|
size = "small",
|
|
srcs = ["arena_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":arena",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "decompose",
|
|
hdrs = ["decompose.h"],
|
|
deps = [
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "decompose_test",
|
|
size = "small",
|
|
srcs = ["decompose_test.cpp"],
|
|
deps = [
|
|
":decompose",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "error_builders",
|
|
hdrs = ["error_builders.h"],
|
|
deps = [
|
|
":source_location",
|
|
"//common:error",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "error_builders_test",
|
|
size = "small",
|
|
srcs = ["error_builders_test.cpp"],
|
|
deps = [
|
|
":error_builders",
|
|
":source_location",
|
|
"//testing/base:gtest_main",
|
|
"//testing/base:test_raw_ostream",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "nonnull",
|
|
hdrs = ["nonnull.h"],
|
|
deps = [
|
|
"//common:check",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "print_as_id",
|
|
hdrs = ["print_as_id.h"],
|
|
deps = [
|
|
"//common:ostream",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "source_location",
|
|
hdrs = ["source_location.h"],
|
|
deps = [
|
|
":nonnull",
|
|
"//common:ostream",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "trace_stream",
|
|
hdrs = ["trace_stream.h"],
|
|
deps = [
|
|
":source_location",
|
|
"//common:check",
|
|
"//common:ostream",
|
|
"//explorer/base:nonnull",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "set_program_phase_raii_test",
|
|
size = "small",
|
|
srcs = ["set_program_phase_raii_test.cpp"],
|
|
deps = [
|
|
":trace_stream",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "set_file_context_raii_test",
|
|
size = "small",
|
|
srcs = ["set_file_context_raii_test.cpp"],
|
|
deps = [
|
|
":source_location",
|
|
":trace_stream",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|