mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-01 10:24:59 +01:00
Jon Ross-Perkins
f8c8861e5f
This doesn't significantly change logic, although I'm trying to add the location to used state. The issue I'm trying to address is how to identify a declaration as "allowed to be redeclared". Consider: ``` library "a" api; extern fn F(); ``` ``` library "b" api; extern fn F(); ``` ``` library "c" api; import library "a"; import library "b"; var x: auto = F(); fn F(); ``` What currently happens is: 1. On import of "a", `F` becomes ImportRefUnused 2. On import of "b", `F` becomes ImportRefUsed in order to merge. 3. In "c", the call `F()` doesn't change the state. 4. In "c", the declaration `fn F();` needs some breadcrumb to understand whether "F" has been referenced, as in step (3) here. What I want to happen is: 1. On import of "a", `F` becomes ImportRefUnloaded 2. On import of "b", `F` becomes ImportRefLoaded in order to merge. 3. In "c", the call `F()` causes `F` to become ImportRefUsed 4. In "c", the declaration `fn F();` detects that `F` is already ImportRefUsed, and can use the associated `used_id` for a diagnostic about why redeclaring is invalid. Note this PR isn't implementing (4). I'm focused on the refactoring to add a new ImportRef state here.
76 lines
2.6 KiB
Plaintext
76 lines
2.6 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
// --- implicit.carbon
|
|
|
|
package Implicit api;
|
|
|
|
var a_orig: i32 = 0;
|
|
var a_ref: i32* = &a_orig;
|
|
|
|
// --- implicit.impl.carbon
|
|
|
|
package Implicit impl;
|
|
|
|
var a: i32* = a_ref;
|
|
|
|
// CHECK:STDOUT: --- implicit.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: i32 = int_literal 0 [template]
|
|
// CHECK:STDOUT: %.2: type = ptr_type i32 [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace [template] {
|
|
// CHECK:STDOUT: .a_orig = %a_orig
|
|
// CHECK:STDOUT: .a_ref = %a_ref
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %a_orig.var: ref i32 = var a_orig
|
|
// CHECK:STDOUT: %a_orig: ref i32 = bind_name a_orig, %a_orig.var
|
|
// CHECK:STDOUT: %.loc5: type = ptr_type i32 [template = constants.%.2]
|
|
// CHECK:STDOUT: %a_ref.var: ref i32* = var a_ref
|
|
// CHECK:STDOUT: %a_ref: ref i32* = bind_name a_ref, %a_ref.var
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @__global_init() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %.loc4: i32 = int_literal 0 [template = constants.%.1]
|
|
// CHECK:STDOUT: assign file.%a_orig.var, %.loc4
|
|
// CHECK:STDOUT: %a_orig.ref: ref i32 = name_ref a_orig, file.%a_orig
|
|
// CHECK:STDOUT: %.loc5: i32* = addr_of %a_orig.ref
|
|
// CHECK:STDOUT: assign file.%a_ref.var, %.loc5
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: --- implicit.impl.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: type = ptr_type i32 [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace [template] {
|
|
// CHECK:STDOUT: .a_orig = %import_ref.1
|
|
// CHECK:STDOUT: .a_ref = %import_ref.2
|
|
// CHECK:STDOUT: .a = %a
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %import_ref.1 = import_ref ir1, inst+2, unloaded
|
|
// CHECK:STDOUT: %import_ref.2: ref i32* = import_ref ir1, inst+9, loc_11
|
|
// CHECK:STDOUT: %.loc4: type = ptr_type i32 [template = constants.%.1]
|
|
// CHECK:STDOUT: %a.var: ref i32* = var a
|
|
// CHECK:STDOUT: %a: ref i32* = bind_name a, %a.var
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @__global_init() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %a_ref.ref: ref i32* = name_ref a_ref, file.%import_ref.2
|
|
// CHECK:STDOUT: %.loc4: i32* = bind_value %a_ref.ref
|
|
// CHECK:STDOUT: assign file.%a.var, %.loc4
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|