Files
carbon-lang/toolchain/check/merge.cpp
T
Jon Ross-Perkins 5c567b892d Address invalid redeclaration and definitions across imports. (#3842)
Note, there's still a TODO "Allow non-extern declarations in the same
library."
2024-04-02 18:01:25 +00:00

118 lines
4.1 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/check/merge.h"
#include "toolchain/check/function.h"
#include "toolchain/check/import_ref.h"
#include "toolchain/sem_ir/typed_insts.h"
namespace Carbon::Check {
auto ResolvePrevInstForMerge(Context& context, Parse::NodeId node_id,
SemIR::InstId prev_inst_id) -> PrevInstForMerge {
PrevInstForMerge prev_inst{.inst = context.insts().Get(prev_inst_id),
.is_import = false};
if (auto import_ref = prev_inst.inst.TryAs<SemIR::ImportRefUsed>()) {
CARBON_DIAGNOSTIC(
RedeclOfUsedImport, Error,
"Redeclaration of imported entity that was previously used.");
CARBON_DIAGNOSTIC(UsedImportLoc, Note, "Import used here.");
context.emitter()
.Build(node_id, RedeclOfUsedImport)
.Note(import_ref->used_id, UsedImportLoc)
.Emit();
} else if (!prev_inst.inst.Is<SemIR::ImportRefLoaded>()) {
return prev_inst;
}
prev_inst.is_import = true;
prev_inst.inst = context.insts().Get(
context.constant_values().Get(prev_inst_id).inst_id());
return prev_inst;
}
// Returns the instruction to consider when merging the given inst_id. Returns
// nullopt if merging is infeasible and no diagnostic should be printed.
static auto ResolveMergeableInst(Context& context, SemIR::InstId inst_id)
-> std::optional<SemIR::Inst> {
auto inst = context.insts().Get(inst_id);
switch (inst.kind()) {
case SemIR::ImportRefUnloaded::Kind:
// Load before merging.
LoadImportRef(context, inst_id, SemIR::LocId::Invalid);
break;
case SemIR::ImportRefUsed::Kind:
// Already loaded.
break;
case SemIR::Namespace::Kind:
// Return back the namespace directly.
return inst;
default:
CARBON_FATAL() << "Unexpected inst kind passed to ResolveMergeableInst: "
<< inst;
}
auto const_id = context.constant_values().Get(inst_id);
// TODO: Function and type declarations are constant, but `var` declarations
// are non-constant and should still merge.
if (!const_id.is_constant()) {
return std::nullopt;
}
return context.insts().Get(const_id.inst_id());
}
auto ReplacePrevInstForMerge(Context& context, SemIR::NameScopeId scope_id,
SemIR::NameId name_id, SemIR::InstId new_inst_id)
-> void {
auto& names = context.name_scopes().Get(scope_id).names;
auto it = names.find(name_id);
if (it != names.end()) {
it->second = new_inst_id;
}
}
auto MergeImportRef(Context& context, SemIR::InstId new_inst_id,
SemIR::InstId prev_inst_id) -> void {
auto new_inst = ResolveMergeableInst(context, new_inst_id);
auto prev_inst = ResolveMergeableInst(context, prev_inst_id);
if (!new_inst || !prev_inst) {
// TODO: Once `var` declarations get an associated instruction for handling,
// it might be more appropriate to return without diagnosing here, to handle
// invalid declarations.
context.DiagnoseDuplicateName(new_inst_id, prev_inst_id);
return;
}
if (new_inst->kind() != prev_inst->kind()) {
context.DiagnoseDuplicateName(new_inst_id, prev_inst_id);
return;
}
switch (new_inst->kind()) {
case SemIR::FunctionDecl::Kind: {
auto new_fn = context.functions().Get(
new_inst->As<SemIR::FunctionDecl>().function_id);
auto prev_fn_id = prev_inst->As<SemIR::FunctionDecl>().function_id;
// TODO: May need to "spoil" the new function to prevent it from being
// emitted, since it will already be added.
MergeFunctionRedecl(context, context.insts().GetLocId(new_inst_id),
new_fn,
/*new_is_import=*/true,
/*new_is_definition=*/false, prev_fn_id,
/*prev_is_imported=*/true);
return;
}
default:
context.TODO(new_inst_id, "Merging not yet supported.");
return;
}
}
} // namespace Carbon::Check