mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-28 22:02:37 +01:00
David Blaikie
f1f6005d4a
Background: https://docs.google.com/document/d/1wi85FRiWh4X9A-gCYMVGKR40-q5fM6-3JaSpePk-XCY/edit?usp=sharing And specifically this work is essentially an alternative to #5543 Clang's code generation is implemented through an ASTListener (clang::CodeGenerator) that is attached throughout Clang's parsing/sema/code generation phases and acts on Clang AST incrementally throughout that process. Prior to this patch, Carbon has only created the CodeGenerator during Carbon's `lower` phase, missing out on key callbacks that would be made by Clang during `check`. Some of these issues were addressed by #6237 and #6483 - but there were still remaining cases where the delayed processing lead to missing functionality. With #6483 much of the Clang code that made multithreaded complexity of #5543 is no longer present, and we have access to the point of ASTListener registration so we can register the CodeGenerator there and consume its resulting llvm::Module during lower. Examples of some of the bugs this addresses are seen in the linked doc, and checked in as tests in this change in `clang_code_generator_callbacks.carbon` An indicental bug that's also fixed, and caused all the other test case churn, is that the `CodeGenerator` created during `lower` wasn't getting passed the Clang `CodeGenOpts` and was creating its own default - so, most notably, optimization flags were not respected. This meant that the LLVM IR from Clang was always -O0 style IR (optnone, no inlinehint, no TBAA, etc). With this change, now the Clang IRGen gets the real `CodeGenOpts` and respects optimization/other flags specified there. This is only meant to be a rough proof of concept - I'm totally open to reworking this in any way (even quite substantially) if folks have ideas about how this should be implemented most generally/elegantly/etc.
87 lines
4.2 KiB
Plaintext
87 lines
4.2 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/int.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/lower/testdata/interop/cpp/import_inline.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/lower/testdata/interop/cpp/import_inline.carbon
|
|
|
|
import Cpp inline '''
|
|
|
|
void F(int *_Nonnull p) {
|
|
*p = 1;
|
|
}
|
|
|
|
''';
|
|
|
|
fn Call() -> i32 {
|
|
var n: i32 = 0;
|
|
Cpp.F(&n);
|
|
return n;
|
|
}
|
|
|
|
// CHECK:STDOUT: ; ModuleID = 'import_inline.carbon'
|
|
// CHECK:STDOUT: source_filename = "import_inline.carbon"
|
|
// CHECK:STDOUT: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
|
|
// CHECK:STDOUT: target triple = "x86_64-unknown-linux-gnu"
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: nounwind
|
|
// CHECK:STDOUT: define i32 @_CCall.Main() #0 !dbg !12 {
|
|
// CHECK:STDOUT: entry:
|
|
// CHECK:STDOUT: %n.var = alloca i32, align 4, !dbg !16
|
|
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %n.var), !dbg !16
|
|
// CHECK:STDOUT: store i32 0, ptr %n.var, align 4, !dbg !16
|
|
// CHECK:STDOUT: call void @_Z1FPi(ptr %n.var), !dbg !17
|
|
// CHECK:STDOUT: %.loc24 = load i32, ptr %n.var, align 4, !dbg !18
|
|
// CHECK:STDOUT: ret i32 %.loc24, !dbg !19
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: nocallback nofree nosync nounwind willreturn memory(argmem: readwrite)
|
|
// CHECK:STDOUT: declare void @llvm.lifetime.start.p0(ptr captures(none)) #1
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: ; Function Attrs: mustprogress nounwind uwtable
|
|
// CHECK:STDOUT: define dso_local void @_Z1FPi(ptr noundef %p) #2 {
|
|
// CHECK:STDOUT: entry:
|
|
// CHECK:STDOUT: %p.addr = alloca ptr, align 8
|
|
// CHECK:STDOUT: store ptr %p, ptr %p.addr, align 8, !tbaa !20
|
|
// CHECK:STDOUT: %0 = load ptr, ptr %p.addr, align 8, !tbaa !20
|
|
// CHECK:STDOUT: store i32 1, ptr %0, align 4, !tbaa !8
|
|
// CHECK:STDOUT: ret void
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: attributes #0 = { nounwind }
|
|
// CHECK:STDOUT: attributes #1 = { nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) }
|
|
// CHECK:STDOUT: attributes #2 = { mustprogress nounwind uwtable "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cmov,+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !llvm.module.flags = !{!0, !1, !2, !3, !4, !5}
|
|
// CHECK:STDOUT: !llvm.dbg.cu = !{!6}
|
|
// CHECK:STDOUT: !llvm.errno.tbaa = !{!8}
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !0 = !{i32 7, !"Dwarf Version", i32 5}
|
|
// CHECK:STDOUT: !1 = !{i32 2, !"Debug Info Version", i32 3}
|
|
// CHECK:STDOUT: !2 = !{i32 1, !"wchar_size", i32 4}
|
|
// CHECK:STDOUT: !3 = !{i32 8, !"PIC Level", i32 0}
|
|
// CHECK:STDOUT: !4 = !{i32 7, !"PIE Level", i32 2}
|
|
// CHECK:STDOUT: !5 = !{i32 7, !"uwtable", i32 2}
|
|
// CHECK:STDOUT: !6 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !7, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
|
|
// CHECK:STDOUT: !7 = !DIFile(filename: "import_inline.carbon", directory: "")
|
|
// CHECK:STDOUT: !8 = !{!9, !9, i64 0}
|
|
// CHECK:STDOUT: !9 = !{!"int", !10, i64 0}
|
|
// CHECK:STDOUT: !10 = !{!"omnipotent char", !11, i64 0}
|
|
// CHECK:STDOUT: !11 = !{!"Simple C++ TBAA"}
|
|
// CHECK:STDOUT: !12 = distinct !DISubprogram(name: "Call", linkageName: "_CCall.Main", scope: null, file: !7, line: 21, type: !13, spFlags: DISPFlagDefinition, unit: !6)
|
|
// CHECK:STDOUT: !13 = !DISubroutineType(types: !14)
|
|
// CHECK:STDOUT: !14 = !{!15}
|
|
// CHECK:STDOUT: !15 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
|
|
// CHECK:STDOUT: !16 = !DILocation(line: 22, column: 3, scope: !12)
|
|
// CHECK:STDOUT: !17 = !DILocation(line: 23, column: 3, scope: !12)
|
|
// CHECK:STDOUT: !18 = !DILocation(line: 24, column: 10, scope: !12)
|
|
// CHECK:STDOUT: !19 = !DILocation(line: 24, column: 3, scope: !12)
|
|
// CHECK:STDOUT: !20 = !{!21, !21, i64 0}
|
|
// CHECK:STDOUT: !21 = !{!"p1 int", !22, i64 0}
|
|
// CHECK:STDOUT: !22 = !{!"any pointer", !10, i64 0}
|