mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 11:48:11 +00:00
Stop using "performed builtin conversion" as a proxy for whether we created an initializing expression with a correctly-set storage argument. That isn't correct in the case where the builtin conversion creates a new initializing expression without setting its storage, such as by creating an `AsCompatible` wrapper around an existing initializing expression. Instead look at whether the storage argument is a `TemporaryStorage`, and only overwrite in that case, otherwise assuming that the storage argument has been set correctly. This fixes a miscompile that was already visible in our lowering tests!