mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-28 07:40:11 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
32 lines
1.1 KiB
C++
32 lines
1.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/check/convert.h"
|
|
#include "toolchain/check/handle.h"
|
|
#include "toolchain/sem_ir/inst.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
// TODO: Find a better home for this. We'll likely need it for more than just
|
|
// expression statements.
|
|
static auto HandleDiscardedExpr(Context& context, SemIR::InstId expr_id)
|
|
-> void {
|
|
// If we discard an initializing expression, convert it to a value or
|
|
// reference so that it has something to initialize.
|
|
auto expr = context.insts().Get(expr_id);
|
|
Convert(context, context.insts().GetLocId(expr_id), expr_id,
|
|
{.kind = ConversionTarget::Discarded, .type_id = expr.type_id()});
|
|
|
|
// TODO: This will eventually need to do some "do not discard" analysis.
|
|
}
|
|
|
|
auto HandleExprStatement(Context& context, Parse::ExprStatementId /*node_id*/)
|
|
-> bool {
|
|
HandleDiscardedExpr(context, context.node_stack().PopExpr());
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon::Check
|