mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 21:00:13 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
68 lines
1.6 KiB
Python
68 lines
1.6 KiB
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_proto_library", "cc_test")
|
|
load("@rules_proto//proto:defs.bzl", "proto_library")
|
|
|
|
package(default_visibility = ["//visibility:public"])
|
|
|
|
proto_library(
|
|
name = "carbon_proto",
|
|
srcs = ["carbon.proto"],
|
|
)
|
|
|
|
cc_proto_library(
|
|
name = "carbon_cc_proto",
|
|
testonly = 1,
|
|
deps = [":carbon_proto"],
|
|
)
|
|
|
|
# Header for LibFuzzer, does not provide the implementation which should come
|
|
# from some other source such as a fuzz test target.
|
|
cc_library(
|
|
name = "libfuzzer_header",
|
|
testonly = 1,
|
|
hdrs = ["libfuzzer.h"],
|
|
)
|
|
|
|
cc_library(
|
|
name = "proto_to_carbon_lib",
|
|
testonly = 1,
|
|
srcs = ["proto_to_carbon.cpp"],
|
|
hdrs = ["proto_to_carbon.h"],
|
|
deps = [
|
|
":carbon_cc_proto",
|
|
"//common:error",
|
|
"@llvm-project//llvm:Support",
|
|
"@protobuf//:protobuf_headers",
|
|
],
|
|
)
|
|
|
|
cc_binary(
|
|
name = "proto_to_carbon",
|
|
testonly = 1,
|
|
srcs = ["proto_to_carbon_main.cpp"],
|
|
deps = [
|
|
":carbon_cc_proto",
|
|
":proto_to_carbon_lib",
|
|
"//common:bazel_working_dir",
|
|
"//common:error",
|
|
"@llvm-project//llvm:Support",
|
|
"@protobuf//:protobuf_headers",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "proto_to_carbon_test",
|
|
size = "small",
|
|
srcs = ["proto_to_carbon_test.cpp"],
|
|
deps = [
|
|
":carbon_cc_proto",
|
|
":proto_to_carbon_lib",
|
|
"//common:error",
|
|
"//testing/base:gtest_main",
|
|
"@googletest//:gtest",
|
|
],
|
|
)
|