mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Jon Ross-Perkins
acbe6530c3
What this really does is avoids shadowing names, so that we can comfortable have things like `Check::DiagnosticEmitter` or `Check::DiagnosticLoc` without shadowing being a concern. Note, down this path I'm also thinking about: - Renaming misc DiagnosticConsumer/DiagnosticEmitter classes, possibly just to DiagnosticConsumer/DiagnosticEmitter (so `Check::DiagnosticEmitter` instead of `SemIRLocDiagnosticEmitter`). - Dropping `Diagnostic` from `Emitter::DiagnosticBuilder`. - But not for `Check::DiagnosticBuilder`, because `Check::Builder` would be ambiguous. - Renaming diagnostics/diagnostic_* to drop "diagnostic". [Discussion about SemIRLoc -> DiagnosticLoc](https://discord.com/channels/655572317891461132/655578254970716160/1353771570463768698) reminded me of this (in particular the older [Check::DiagnosticBuilder discussion](https://discord.com/channels/655572317891461132/655578254970716160/1344363562608627763)), but I'd only do that rename if there's matching consensus about a path forward where we keep SemIRLoc, and in a way that it's only ever used for diagnostics (the divergence from which is at the root of current LocId discussion). I'm trying to keep that separate from a namespace addition for clarity.
70 lines
2.3 KiB
C++
70 lines
2.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/source/source_buffer.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "common/check.h"
|
|
#include "llvm/Support/VirtualFileSystem.h"
|
|
#include "toolchain/diagnostics/diagnostic_emitter.h"
|
|
|
|
namespace Carbon {
|
|
namespace {
|
|
|
|
static constexpr llvm::StringLiteral TestFileName = "test.carbon";
|
|
|
|
TEST(SourceBufferTest, MissingFile) {
|
|
llvm::vfs::InMemoryFileSystem fs;
|
|
auto buffer = SourceBuffer::MakeFromFile(fs, TestFileName,
|
|
Diagnostics::ConsoleConsumer());
|
|
EXPECT_FALSE(buffer);
|
|
}
|
|
|
|
TEST(SourceBufferTest, SimpleFile) {
|
|
llvm::vfs::InMemoryFileSystem fs;
|
|
CARBON_CHECK(fs.addFile(TestFileName, /*ModificationTime=*/0,
|
|
llvm::MemoryBuffer::getMemBuffer("Hello World")));
|
|
|
|
auto buffer = SourceBuffer::MakeFromFile(fs, TestFileName,
|
|
Diagnostics::ConsoleConsumer());
|
|
ASSERT_TRUE(buffer);
|
|
|
|
EXPECT_EQ(TestFileName, buffer->filename());
|
|
EXPECT_EQ("Hello World", buffer->text());
|
|
}
|
|
|
|
TEST(SourceBufferTest, NoNull) {
|
|
llvm::vfs::InMemoryFileSystem fs;
|
|
static constexpr char NoNull[3] = {'a', 'b', 'c'};
|
|
CARBON_CHECK(fs.addFile(
|
|
TestFileName, /*ModificationTime=*/0,
|
|
llvm::MemoryBuffer::getMemBuffer(llvm::StringRef(NoNull, sizeof(NoNull)),
|
|
/*BufferName=*/"",
|
|
/*RequiresNullTerminator=*/false)));
|
|
|
|
auto buffer = SourceBuffer::MakeFromFile(fs, TestFileName,
|
|
Diagnostics::ConsoleConsumer());
|
|
ASSERT_TRUE(buffer);
|
|
|
|
EXPECT_EQ(TestFileName, buffer->filename());
|
|
EXPECT_EQ("abc", buffer->text());
|
|
}
|
|
|
|
TEST(SourceBufferTest, EmptyFile) {
|
|
llvm::vfs::InMemoryFileSystem fs;
|
|
CARBON_CHECK(fs.addFile(TestFileName, /*ModificationTime=*/0,
|
|
llvm::MemoryBuffer::getMemBuffer("")));
|
|
|
|
auto buffer = SourceBuffer::MakeFromFile(fs, TestFileName,
|
|
Diagnostics::ConsoleConsumer());
|
|
ASSERT_TRUE(buffer);
|
|
|
|
EXPECT_EQ(TestFileName, buffer->filename());
|
|
EXPECT_EQ("", buffer->text());
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon
|