mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Jon Ross-Perkins
6b5eb1a101
High level, replacing `Id::Invalid` with `Id::None` and `Id::is_valid` with `Id::has_value` for clarity, as discussed [here](https://discord.com/channels/655572317891461132/655578254970716160/1331664574545395794). The `IntId` refactoring is needed together with `AnyIdBase` because it's also used with `ValueStore`. Note, trying to be careful not to rewrite `EnumBase::InvalidIndex`, or `is_valid` in general (e.g., `IdKind::is_valid`). I've tried to sequence commits here: 1. Automatic replacements: - `((?:Id|Index)(?: |::|\(|Base(?:\(|::)))Invalid((?:Index)?\W)` -> `$1None$2` - `<invalid>` -> `<none>` - `InvalidNodeId` -> `NoneNodeId` - `/\*invalid\*/` -> `/*none*/` - `id((?:_|\(\))(?:\.|->))is_valid` -> `id$1has_value` 2. Manual edits: - In `int.h` and `int_test.cpp` - `IntT` has `is_value`, which I'm renaming to `is_embedded_value`. - Manual edits to comments in this file. - `AnyIdBase` and `IdBase` - Declaration of `is_valid` -> `has_value`, `InvalidIndex` -> `NoneIndex`. - In `ids.h` and `ids.cpp` - `is_valid` -> `has_value` - `// An explicitly invalid ID.` -> `// An ID with no value.`; similar for index - Various math on `InvalidIndex` -> `NoneIndex` - Various mentions of "valid" in comments - In `value_store.h`, for `IdT::Invalid`, plus one comment - In `impl.h` and `tokenized_buffer.h`, we had different initialization of `::None` values (versus `ids.h` syntax) that I fixed manually. - Spot checks to compile - Particularly where `is_valid` replacements didn't catch spots due to different naming. 3. Autoupdate tests 4. verbose.carbon (NOAUTOUPDATE) 5. Comment spot checks Note there are probably other mentions of "Invalid" that should be swept up, but I'd like to argue for merging and separating out remaining cleanup since this is so sweeping (and likely to hit merge conflicts from churn). We'll probably have lingering mentions of "invalid" for a bit regardless, just because there are uses of "invalid" in non-Id APIs.
104 lines
2.9 KiB
C++
104 lines
2.9 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/base/value_store.h"
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "toolchain/base/value_ids.h"
|
|
|
|
namespace Carbon::Testing {
|
|
namespace {
|
|
|
|
using ::testing::Eq;
|
|
using ::testing::Not;
|
|
|
|
TEST(ValueStore, Real) {
|
|
Real real1{.mantissa = llvm::APInt(64, 1),
|
|
.exponent = llvm::APInt(64, 11),
|
|
.is_decimal = true};
|
|
Real real2{.mantissa = llvm::APInt(64, 2),
|
|
.exponent = llvm::APInt(64, 22),
|
|
.is_decimal = false};
|
|
|
|
ValueStore<RealId> reals;
|
|
RealId id1 = reals.Add(real1);
|
|
RealId id2 = reals.Add(real2);
|
|
|
|
ASSERT_TRUE(id1.has_value());
|
|
ASSERT_TRUE(id2.has_value());
|
|
EXPECT_THAT(id1, Not(Eq(id2)));
|
|
|
|
const auto& real1_copy = reals.Get(id1);
|
|
EXPECT_THAT(real1.mantissa, Eq(real1_copy.mantissa));
|
|
EXPECT_THAT(real1.exponent, Eq(real1_copy.exponent));
|
|
EXPECT_THAT(real1.is_decimal, Eq(real1_copy.is_decimal));
|
|
|
|
const auto& real2_copy = reals.Get(id2);
|
|
EXPECT_THAT(real2.mantissa, Eq(real2_copy.mantissa));
|
|
EXPECT_THAT(real2.exponent, Eq(real2_copy.exponent));
|
|
EXPECT_THAT(real2.is_decimal, Eq(real2_copy.is_decimal));
|
|
}
|
|
|
|
TEST(ValueStore, Float) {
|
|
llvm::APFloat float1(1.0);
|
|
llvm::APFloat float2(2.0);
|
|
|
|
CanonicalValueStore<FloatId> floats;
|
|
FloatId id1 = floats.Add(float1);
|
|
FloatId id2 = floats.Add(float2);
|
|
|
|
ASSERT_TRUE(id1.has_value());
|
|
ASSERT_TRUE(id2.has_value());
|
|
EXPECT_THAT(id1, Not(Eq(id2)));
|
|
|
|
EXPECT_THAT(floats.Get(id1).compare(float1), Eq(llvm::APFloatBase::cmpEqual));
|
|
EXPECT_THAT(floats.Get(id2).compare(float2), Eq(llvm::APFloatBase::cmpEqual));
|
|
}
|
|
|
|
TEST(ValueStore, Identifiers) {
|
|
std::string a = "a";
|
|
std::string b = "b";
|
|
CanonicalValueStore<IdentifierId> identifiers;
|
|
|
|
// Make sure reserve works, we use it with identifiers.
|
|
identifiers.Reserve(100);
|
|
|
|
auto a_id = identifiers.Add(a);
|
|
auto b_id = identifiers.Add(b);
|
|
|
|
ASSERT_TRUE(a_id.has_value());
|
|
ASSERT_TRUE(b_id.has_value());
|
|
EXPECT_THAT(a_id, Not(Eq(b_id)));
|
|
|
|
EXPECT_THAT(identifiers.Get(a_id), Eq(a));
|
|
EXPECT_THAT(identifiers.Get(b_id), Eq(b));
|
|
|
|
EXPECT_THAT(identifiers.Lookup(a), Eq(a_id));
|
|
EXPECT_THAT(identifiers.Lookup("c"), Eq(IdentifierId::None));
|
|
}
|
|
|
|
TEST(ValueStore, StringLiterals) {
|
|
std::string a = "a";
|
|
std::string b = "b";
|
|
CanonicalValueStore<StringLiteralValueId> string_literals;
|
|
|
|
auto a_id = string_literals.Add(a);
|
|
auto b_id = string_literals.Add(b);
|
|
|
|
ASSERT_TRUE(a_id.has_value());
|
|
ASSERT_TRUE(b_id.has_value());
|
|
EXPECT_THAT(a_id, Not(Eq(b_id)));
|
|
|
|
EXPECT_THAT(string_literals.Get(a_id), Eq(a));
|
|
EXPECT_THAT(string_literals.Get(b_id), Eq(b));
|
|
|
|
EXPECT_THAT(string_literals.Lookup(a), Eq(a_id));
|
|
EXPECT_THAT(string_literals.Lookup("c"), Eq(StringLiteralValueId::None));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon::Testing
|