mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 20:01:14 +01:00
Chandler Carruth
8be274cf60
Implement the toolchain side of proposal #7254, removing the `:!` binding syntax for generic and template parameters in favor of the keywords `generic`, `template`, and `runtime` plus contextual defaults for phase. For valid programs this is semantics-preserving: each binding resolves to the same phase, and produces the same SemIR, as it did under `:!`/`:`. The parser derives a binding's phase from its syntactic context plus any explicit phase keyword; new diagnostics and error recovery for misused keywords are described below. Implementation details for each component: - Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual parse-node budget onto `:`, and add the `generic` and `runtime` keywords. - Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or `CompileTimeEntityParam`) from declaration introducers down through parameter lists to each binding pattern, using a one-token lookahead to distinguish a name-qualifier parameter list from a declaration's own final list. Parameters of a compile-time entity (`class`, `interface`, `constraint`, `choice`, `alias`, `export`, `namespace`) and deduced `[]` parameters default to checked generic; explicit function parameters and local bindings default to runtime. `HandleBindingPattern` resolves the phase from that context plus the keyword: a `generic` keyword needs no node of its own (the phase is carried by the binding's node kind), while a `runtime` keyword is preserved as a `RuntimeBindingName` node so `check` can name it in a diagnostic. A phase keyword that is merely redundant with the contextual default is diagnosed here, without invalidating the parse tree. - Check: a phase keyword that is invalid for its context (for example `runtime` on a checked-generic parameter) is diagnosed here, and recovers by building an error binding that still introduces the name so that later uses of it do not produce cascading errors. The removed `:!` syntax is now rejected as an ordinary parse error. The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is left for a separate change. Assisted-by: Claude Code
224 lines
7.0 KiB
Plaintext
224 lines
7.0 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interface/name_poisoning.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interface/name_poisoning.carbon
|
|
|
|
// --- no_poison.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I;
|
|
|
|
// `N.F` uses `N.I` and not `package.I`.
|
|
namespace N;
|
|
interface N.I {}
|
|
fn N.F(unused generic x: I) {}
|
|
|
|
fn TestCall(generic x: N.I) {
|
|
// `N.F` accepts an `N.I` not a `package.I`.
|
|
N.F(x);
|
|
}
|
|
|
|
// --- poison.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I;
|
|
|
|
namespace N;
|
|
// Use `package.I` and poison `N.I`.
|
|
fn N.F(generic x: I);
|
|
|
|
// --- fail_declare_after_poison.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I;
|
|
|
|
namespace N;
|
|
// Use `package.I` and poison `N.I`.
|
|
// CHECK:STDERR: fail_declare_after_poison.carbon:[[@LINE+3]]:19: error: name `I` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: fn N.F(generic x: I);
|
|
// CHECK:STDERR: ^
|
|
fn N.F(generic x: I);
|
|
|
|
// Failure: N.I declared after it was poisoned.
|
|
// CHECK:STDERR: fail_declare_after_poison.carbon:[[@LINE+4]]:13: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: interface N.I {}
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
interface N.I {}
|
|
|
|
// --- fail_use_poison.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I;
|
|
|
|
namespace N;
|
|
// Use `package.I` and poison `N.I`.
|
|
fn N.F1(generic x: I);
|
|
|
|
// CHECK:STDERR: fail_use_poison.carbon:[[@LINE+4]]:20: error: member name `I` not found in `N` [MemberNameNotFoundInInstScope]
|
|
// CHECK:STDERR: fn N.F2(generic x: N.I);
|
|
// CHECK:STDERR: ^~~
|
|
// CHECK:STDERR:
|
|
fn N.F2(generic x: N.I);
|
|
|
|
// --- fail_use_declaration_after_poison.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I;
|
|
|
|
namespace N;
|
|
// Use `package.I` and poison `N.I`.
|
|
// CHECK:STDERR: fail_use_declaration_after_poison.carbon:[[@LINE+3]]:20: error: name `I` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: fn N.F1(generic x: I);
|
|
// CHECK:STDERR: ^
|
|
fn N.F1(generic x: I);
|
|
|
|
// CHECK:STDERR: fail_use_declaration_after_poison.carbon:[[@LINE+4]]:13: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: interface N.I;
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
interface N.I;
|
|
|
|
// CHECK:STDERR: fail_use_declaration_after_poison.carbon:[[@LINE+4]]:20: error: member name `I` not found in `N` [MemberNameNotFoundInInstScope]
|
|
// CHECK:STDERR: fn N.F2(generic x: N.I);
|
|
// CHECK:STDERR: ^~~
|
|
// CHECK:STDERR:
|
|
fn N.F2(generic x: N.I);
|
|
|
|
// --- fail_alias.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I;
|
|
namespace N;
|
|
|
|
// CHECK:STDERR: fail_alias.carbon:[[@LINE+7]]:13: error: name `I` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: alias N.I = I;
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR: fail_alias.carbon:[[@LINE+4]]:9: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: alias N.I = I;
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
alias N.I = I;
|
|
|
|
// --- fail_poison_multiple_scopes.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I1;
|
|
|
|
interface I2 {
|
|
interface I3 {
|
|
interface I4 {
|
|
// Use `package.I1` and poison:
|
|
// * `I2.I1`
|
|
// * `I2.I3.I1`
|
|
// * `I2.I3.I4.I1`
|
|
// CHECK:STDERR: fail_poison_multiple_scopes.carbon:[[@LINE+3]]:23: error: name `I1` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: fn F(generic x: I1);
|
|
// CHECK:STDERR: ^~
|
|
fn F(generic x: I1);
|
|
|
|
// CHECK:STDERR: fail_poison_multiple_scopes.carbon:[[@LINE+7]]:17: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: interface I1;
|
|
// CHECK:STDERR: ^~
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_poison_multiple_scopes.carbon:[[@LINE-6]]:23: error: name `I1` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: fn F(generic x: I1);
|
|
// CHECK:STDERR: ^~
|
|
interface I1;
|
|
}
|
|
// CHECK:STDERR: fail_poison_multiple_scopes.carbon:[[@LINE+7]]:15: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: interface I1;
|
|
// CHECK:STDERR: ^~
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_poison_multiple_scopes.carbon:[[@LINE-15]]:23: error: name `I1` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: fn F(generic x: I1);
|
|
// CHECK:STDERR: ^~
|
|
interface I1;
|
|
}
|
|
// CHECK:STDERR: fail_poison_multiple_scopes.carbon:[[@LINE+4]]:13: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: interface I1;
|
|
// CHECK:STDERR: ^~
|
|
// CHECK:STDERR:
|
|
interface I1;
|
|
}
|
|
|
|
// --- ignored_poison_in_import.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
import library "poison";
|
|
|
|
// This doesn't fail.
|
|
interface N.I;
|
|
|
|
// --- poison.impl.carbon
|
|
|
|
impl library "[[@TEST_NAME]]";
|
|
|
|
// TODO: #4622 This should fail since `N.I` was poisoned in the api.
|
|
interface N.I;
|
|
|
|
// --- fail_poison_when_lookup_fails.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
namespace N;
|
|
// `package.I` and `N.I` poisoned when not found.
|
|
// CHECK:STDERR: fail_poison_when_lookup_fails.carbon:[[@LINE+7]]:19: error: name `I` not found [NameNotFound]
|
|
// CHECK:STDERR: fn N.F(generic x: I);
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_poison_when_lookup_fails.carbon:[[@LINE+3]]:19: error: name `I` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: fn N.F(generic x: I);
|
|
// CHECK:STDERR: ^
|
|
fn N.F(generic x: I);
|
|
|
|
// TODO: We should ideally only produce one diagnostic here.
|
|
// CHECK:STDERR: fail_poison_when_lookup_fails.carbon:[[@LINE+7]]:11: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: interface I;
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_poison_when_lookup_fails.carbon:[[@LINE-7]]:19: error: name `I` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: fn N.F(generic x: I);
|
|
// CHECK:STDERR: ^
|
|
interface I;
|
|
// CHECK:STDERR: fail_poison_when_lookup_fails.carbon:[[@LINE+4]]:13: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: interface N.I;
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
interface N.I;
|
|
|
|
// --- fail_poison_with_lexical_result.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
fn F() {
|
|
interface I1 {}
|
|
|
|
class C {
|
|
// CHECK:STDERR: fail_poison_with_lexical_result.carbon:[[@LINE+3]]:12: error: name `I1` used before it was declared [NameUseBeforeDecl]
|
|
// CHECK:STDERR: var v: I1;
|
|
// CHECK:STDERR: ^~
|
|
var v: I1;
|
|
|
|
// CHECK:STDERR: fail_poison_with_lexical_result.carbon:[[@LINE+4]]:15: note: declared here [NameUseBeforeDeclNote]
|
|
// CHECK:STDERR: interface I1;
|
|
// CHECK:STDERR: ^~
|
|
// CHECK:STDERR:
|
|
interface I1;
|
|
}
|
|
}
|