Files
carbon-lang/toolchain/parse/handle_var.cpp
T
Chandler Carruth 8be274cf60 Replace :! binding syntax with phase keywords and contextual defaults (#7479)
Implement the toolchain side of proposal #7254, removing the `:!`
binding
syntax for generic and template parameters in favor of the keywords
`generic`,
`template`, and `runtime` plus contextual defaults for phase.

For valid programs this is semantics-preserving: each binding resolves
to the
same phase, and produces the same SemIR, as it did under `:!`/`:`. The
parser
derives a binding's phase from its syntactic context plus any explicit
phase
keyword; new diagnostics and error recovery for misused keywords are
described
below.

Implementation details for each component:

- Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual
parse-node
  budget onto `:`, and add the `generic` and `runtime` keywords.
- Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or
`CompileTimeEntityParam`) from declaration introducers down through
parameter
lists to each binding pattern, using a one-token lookahead to
distinguish a
name-qualifier parameter list from a declaration's own final list.
Parameters
of a compile-time entity (`class`, `interface`, `constraint`, `choice`,
`alias`, `export`, `namespace`) and deduced `[]` parameters default to
checked
generic; explicit function parameters and local bindings default to
runtime.
`HandleBindingPattern` resolves the phase from that context plus the
keyword: a
`generic` keyword needs no node of its own (the phase is carried by the
  binding's node kind), while a `runtime` keyword is preserved as a
`RuntimeBindingName` node so `check` can name it in a diagnostic. A
phase
keyword that is merely redundant with the contextual default is
diagnosed
  here, without invalidating the parse tree.
- Check: a phase keyword that is invalid for its context (for example
`runtime`
on a checked-generic parameter) is diagnosed here, and recovers by
building an
error binding that still introduces the name so that later uses of it do
not
  produce cascading errors.

The removed `:!` syntax is now rejected as an ordinary parse error.

The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is
left for a
separate change.

Assisted-by: Claude Code
2026-07-11 01:22:44 +00:00

119 lines
4.0 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/parse/context.h"
#include "toolchain/parse/handle.h"
namespace Carbon::Parse {
// Handles VarAs(Regular|Returned).
static auto HandleVar(Context& context, StateKind finish_state_kind,
Lex::TokenIndex returned_token = Lex::TokenIndex::None)
-> void {
auto state = context.PopState();
// The finished variable declaration will start at the `var` or `returned`.
context.PushState(state, finish_state_kind);
// TODO: is there a cleaner way to give VarAfterPattern access to the `var`
// token?
state.token = *(context.position() - 1);
context.PushState(state, StateKind::VarAfterPattern);
if (returned_token.has_value()) {
context.AddLeafNode(NodeKind::ReturnedModifier, returned_token);
}
context.PushStateForPattern(StateKind::Pattern, /*in_var_pattern=*/true,
/*in_unused_pattern=*/false,
BindingContext::ExplicitParam,
PrecedenceGroup::ForTopLevelPattern());
}
auto HandleVarAsRegular(Context& context) -> void {
HandleVar(context, StateKind::VarFinish);
}
auto HandleVarAsReturned(Context& context) -> void {
auto returned_token = context.Consume();
if (!context.PositionIs(Lex::TokenKind::Var)) {
CARBON_DIAGNOSTIC(ExpectedVarAfterReturned, Error,
"expected `var` after `returned`");
context.emitter().Emit(*context.position(), ExpectedVarAfterReturned);
context.AddLeafNode(NodeKind::EmptyDecl,
context.SkipPastLikelyEnd(returned_token),
/*has_error=*/true);
context.PopAndDiscardState();
return;
}
context.AddLeafNode(NodeKind::VariableIntroducer, context.Consume());
HandleVar(context, StateKind::VarFinish, returned_token);
}
auto HandleVarAfterPattern(Context& context) -> void {
auto state = context.PopState();
if (state.has_error) {
if (auto after_pattern =
context.FindNextOf({Lex::TokenKind::Equal, Lex::TokenKind::Semi})) {
context.SkipTo(*after_pattern);
}
}
context.AddNode(NodeKind::VariablePattern, state.token, state.has_error);
if (context.PositionIs(Lex::TokenKind::Equal)) {
context.AddLeafNode(NodeKind::VariableInitializer,
context.ConsumeChecked(Lex::TokenKind::Equal));
context.PushState(StateKind::Expr);
}
}
auto HandleVarFinish(Context& context) -> void {
auto state = context.PopState();
auto end_token = state.token;
if (context.PositionIs(Lex::TokenKind::Semi)) {
end_token = context.Consume();
} else {
// TODO: Disambiguate between statement and member declaration.
context.DiagnoseExpectedDeclSemi(Lex::TokenKind::Var);
state.has_error = true;
end_token = context.SkipPastLikelyEnd(state.token);
}
context.AddNode(NodeKind::VariableDecl, end_token, state.has_error);
}
auto HandleVariablePattern(Context& context) -> void {
auto state = context.PopState();
if (state.in_var_pattern) {
CARBON_DIAGNOSTIC(NestedVar, Error, "`var` nested within another `var`");
context.emitter().Emit(*context.position(), NestedVar);
state.has_error = true;
}
state.kind = StateKind::FinishVariablePattern;
context.PushState(state);
context.ConsumeChecked(Lex::TokenKind::Var);
// A `var` binding is always runtime, regardless of the enclosing context.
context.PushStateForPattern(
StateKind::Pattern, /*in_var_pattern=*/true, state.in_unused_pattern,
BindingContext::ExplicitParam, state.ambient_precedence);
}
auto HandleFinishVariablePattern(Context& context) -> void {
auto state = context.PopState();
context.AddNode(NodeKind::VariablePattern, state.token, state.has_error);
// Propagate errors to the parent state so that they can take different
// actions on invalid patterns.
if (state.has_error) {
context.ReturnErrorOnState();
}
}
} // namespace Carbon::Parse