mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
59 lines
1.8 KiB
C++
59 lines
1.8 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/sem_ir/class.h"
|
|
|
|
#include "toolchain/base/value_store_impl.h"
|
|
#include "toolchain/sem_ir/file.h"
|
|
#include "toolchain/sem_ir/generic.h"
|
|
#include "toolchain/sem_ir/ids.h"
|
|
#include "toolchain/sem_ir/typed_insts.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
static auto GetFoundationType(const File& file, SpecificId specific_id,
|
|
InstId inst_id) -> TypeId {
|
|
if (!inst_id.has_value()) {
|
|
return TypeId::None;
|
|
}
|
|
if (inst_id == ErrorInst::InstId) {
|
|
return ErrorInst::TypeId;
|
|
}
|
|
return TypeId::ForTypeConstant(GetConstantValueInSpecific(
|
|
file, specific_id,
|
|
file.insts().GetAs<AnyFoundationDecl>(inst_id).foundation_type_inst_id));
|
|
}
|
|
|
|
auto Class::GetAdaptedType(const File& file, SpecificId specific_id) const
|
|
-> TypeId {
|
|
return GetFoundationType(file, specific_id, adapt_id);
|
|
}
|
|
|
|
auto Class::GetBaseType(const File& file, SpecificId specific_id) const
|
|
-> TypeId {
|
|
return GetFoundationType(file, specific_id, base_id);
|
|
}
|
|
|
|
auto Class::GetObjectRepr(const File& file, SpecificId specific_id) const
|
|
-> TypeId {
|
|
if (!complete_type_witness_id.has_value()) {
|
|
return TypeId::None;
|
|
}
|
|
auto witness_id =
|
|
GetConstantValueInSpecific(file, specific_id, complete_type_witness_id);
|
|
if (witness_id == ErrorInst::ConstantId) {
|
|
return ErrorInst::TypeId;
|
|
}
|
|
return file.types().GetTypeIdForTypeInstId(
|
|
file.constant_values()
|
|
.GetInstAs<CompleteTypeWitness>(witness_id)
|
|
.object_repr_type_inst_id);
|
|
}
|
|
|
|
} // namespace Carbon::SemIR
|
|
|
|
namespace Carbon {
|
|
template class ValueStore<SemIR::ClassId, SemIR::Class, Tag<SemIR::CheckIRId>>;
|
|
} // namespace Carbon
|