mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:00:12 +01:00
Chandler CarruthandChristopher Di Bella
8a59f2a76b
Carbon-side thunks (for example the `Copy`/`Destroy` witness thunks generated for imported C++ types) are mangled by Carbon, and their names incorporate a fingerprint of the involved types. The instruction fingerprinter identifies a class only by its name and parent scope, which is sufficient for Carbon classes but not for imported C++ classes: different specializations of one class template (and other cases such as types in anonymous namespaces) share a Carbon name and parent scope. As a result, the thunks for two distinct specializations could mangle to the same name, producing a single LLVM function with two definitions and failing `verifyModule` during lowering. When fingerprinting a class imported from C++, also include the Clang mangled name of its type. Test: toolchain/lower/testdata/interop/cpp/thunks.carbon gains a split with two specializations of one class template, each requiring a thunk; their thunks now get distinct mangled names instead of colliding. Assisted-by: Claude Code --------- Co-authored-by: Christopher Di Bella <cjdb.ns@gmail.com>
225 lines
11 KiB
Plaintext
225 lines
11 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/destroy.carbon
|
|
// EXTRA-ARGS: --dump-sem-ir-ranges=if-present
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interop/cpp/var/global.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interop/cpp/var/global.carbon
|
|
|
|
// ============================================================================
|
|
// Global scope
|
|
// ============================================================================
|
|
|
|
// --- global_scope.h
|
|
|
|
class C {};
|
|
C global;
|
|
C* _Nonnull global_ptr = &global;
|
|
C& global_ref = global;
|
|
|
|
|
|
// --- import_global_scope.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp library "global_scope.h";
|
|
|
|
fn MyF() {
|
|
let unused local: Cpp.C = Cpp.global;
|
|
let unused local_ptr: Cpp.C* = Cpp.global_ptr;
|
|
let unused local_ref: Cpp.C* = Cpp.global_ref;
|
|
}
|
|
|
|
// ============================================================================
|
|
// Unsupported global type
|
|
// ============================================================================
|
|
|
|
// --- unsupported_type.h
|
|
|
|
using UnusupportedType = _BitInt(23);
|
|
UnusupportedType global;
|
|
|
|
// --- fail_import_unsupported_type.carbon
|
|
|
|
library "[[@TEST_NAME]]";
|
|
|
|
// CHECK:STDERR: fail_import_unsupported_type.carbon:[[@LINE+4]]:10: in file included here [InCppInclude]
|
|
// CHECK:STDERR: ./unsupported_type.h:2:7: error: semantics TODO: `Unsupported: Type declaration: UnusupportedType` [SemanticsTodo]
|
|
// CHECK:STDERR: using UnusupportedType = _BitInt(23);
|
|
// CHECK:STDERR: ^
|
|
import Cpp library "unsupported_type.h";
|
|
|
|
fn MyF() {
|
|
// CHECK:STDERR: fail_import_unsupported_type.carbon:[[@LINE+11]]:21: note: in `Cpp` name lookup for `UnusupportedType` [InCppNameLookup]
|
|
// CHECK:STDERR: let unused local: Cpp.UnusupportedType = Cpp.global;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_import_unsupported_type.carbon:[[@LINE+7]]:44: error: semantics TODO: `Unsupported: var type: UnusupportedType` [SemanticsTodo]
|
|
// CHECK:STDERR: let unused local: Cpp.UnusupportedType = Cpp.global;
|
|
// CHECK:STDERR: ^~~~~~~~~~
|
|
// CHECK:STDERR: fail_import_unsupported_type.carbon:[[@LINE+4]]:44: note: in `Cpp` name lookup for `global` [InCppNameLookup]
|
|
// CHECK:STDERR: let unused local: Cpp.UnusupportedType = Cpp.global;
|
|
// CHECK:STDERR: ^~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
let unused local: Cpp.UnusupportedType = Cpp.global;
|
|
}
|
|
|
|
// CHECK:STDOUT: --- import_global_scope.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %MyF.type: type = fn_type @MyF [concrete]
|
|
// CHECK:STDOUT: %MyF: %MyF.type = struct_value () [concrete]
|
|
// CHECK:STDOUT: %C: type = class_type @C [concrete]
|
|
// CHECK:STDOUT: %empty_struct_type: type = struct_type {} [concrete]
|
|
// CHECK:STDOUT: %complete_type: <witness> = complete_type_witness %empty_struct_type [concrete]
|
|
// CHECK:STDOUT: %pattern_type.479: type = pattern_type %C [concrete]
|
|
// CHECK:STDOUT: %ptr.3a8: type = ptr_type %C [concrete]
|
|
// CHECK:STDOUT: %pattern_type.0d0: type = pattern_type %ptr.3a8 [concrete]
|
|
// CHECK:STDOUT: %const: type = const_type %ptr.3a8 [concrete]
|
|
// CHECK:STDOUT: %pattern_type.3f2: type = pattern_type %const [concrete]
|
|
// CHECK:STDOUT: %global_ref.var: ref %ptr.3a8 = var imports.%global_ref.var_patt [concrete]
|
|
// CHECK:STDOUT: %addr: %ptr.3a8 = addr_of imports.%global.var [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: imports {
|
|
// CHECK:STDOUT: %Core: <namespace> = namespace file.%Core.import, [concrete] {
|
|
// CHECK:STDOUT: import Core//prelude
|
|
// CHECK:STDOUT: import Core//prelude/...
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %Cpp: <namespace> = namespace file.%Cpp.import_cpp, [concrete] {
|
|
// CHECK:STDOUT: .C = %C.decl
|
|
// CHECK:STDOUT: .global = %global.var
|
|
// CHECK:STDOUT: .global_ptr = %global_ptr.var
|
|
// CHECK:STDOUT: .global_ref = %global_ref.var
|
|
// CHECK:STDOUT: import Cpp//...
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %C.decl: type = class_decl @C [concrete = constants.%C] {} {}
|
|
// CHECK:STDOUT: %global.patt: %pattern_type.479 = ref_binding_pattern global [concrete]
|
|
// CHECK:STDOUT: %global.var_patt: %pattern_type.479 = var_pattern %global.patt [concrete]
|
|
// CHECK:STDOUT: %global.var: ref %C = var %global.var_patt [concrete]
|
|
// CHECK:STDOUT: %global_ptr.patt: %pattern_type.0d0 = ref_binding_pattern global_ptr [concrete]
|
|
// CHECK:STDOUT: %global_ptr.var_patt: %pattern_type.0d0 = var_pattern %global_ptr.patt [concrete]
|
|
// CHECK:STDOUT: %global_ptr.var: ref %ptr.3a8 = var %global_ptr.var_patt [concrete]
|
|
// CHECK:STDOUT: %global_ref.patt: %pattern_type.3f2 = ref_binding_pattern global_ref [concrete]
|
|
// CHECK:STDOUT: %global_ref.var_patt: %pattern_type.3f2 = var_pattern %global_ref.patt [concrete]
|
|
// CHECK:STDOUT: %global_ref.var: ref %const = var %global_ref.var_patt [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace [concrete] {
|
|
// CHECK:STDOUT: .Core = imports.%Core
|
|
// CHECK:STDOUT: .Cpp = imports.%Cpp
|
|
// CHECK:STDOUT: .MyF = %MyF.decl
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %Core.import = import Core
|
|
// CHECK:STDOUT: %Cpp.import_cpp = import_cpp {
|
|
// CHECK:STDOUT: import Cpp "global_scope.h"
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %MyF.decl: %MyF.type = fn_decl @MyF [concrete = constants.%MyF] {} {}
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: class @C {
|
|
// CHECK:STDOUT: %empty_struct_type: type = struct_type {} [concrete = constants.%empty_struct_type]
|
|
// CHECK:STDOUT: %complete_type: <witness> = complete_type_witness %empty_struct_type [concrete = constants.%complete_type]
|
|
// CHECK:STDOUT: complete_type_witness = %complete_type
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !members:
|
|
// CHECK:STDOUT: import Cpp//...
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @MyF() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: name_binding_decl {
|
|
// CHECK:STDOUT: %local.patt: %pattern_type.479 = value_binding_pattern local [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %Cpp.ref.loc7_29: <namespace> = name_ref Cpp, imports.%Cpp [concrete = imports.%Cpp]
|
|
// CHECK:STDOUT: %global.ref: ref %C = name_ref global, imports.%global.var [concrete = imports.%global.var]
|
|
// CHECK:STDOUT: %.loc7_24: type = splice_block %C.ref.loc7 [concrete = constants.%C] {
|
|
// CHECK:STDOUT: %Cpp.ref.loc7_21: <namespace> = name_ref Cpp, imports.%Cpp [concrete = imports.%Cpp]
|
|
// CHECK:STDOUT: %C.ref.loc7: type = name_ref C, imports.%C.decl [concrete = constants.%C]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %.loc7_32: %C = acquire_value %global.ref
|
|
// CHECK:STDOUT: %local: %C = value_binding local, %.loc7_32
|
|
// CHECK:STDOUT: name_binding_decl {
|
|
// CHECK:STDOUT: %local_ptr.patt: %pattern_type.0d0 = value_binding_pattern local_ptr [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %Cpp.ref.loc8_34: <namespace> = name_ref Cpp, imports.%Cpp [concrete = imports.%Cpp]
|
|
// CHECK:STDOUT: %global_ptr.ref: ref %ptr.3a8 = name_ref global_ptr, imports.%global_ptr.var [concrete = imports.%global_ptr.var]
|
|
// CHECK:STDOUT: %.loc8_30: type = splice_block %ptr.loc8 [concrete = constants.%ptr.3a8] {
|
|
// CHECK:STDOUT: %Cpp.ref.loc8_25: <namespace> = name_ref Cpp, imports.%Cpp [concrete = imports.%Cpp]
|
|
// CHECK:STDOUT: %C.ref.loc8: type = name_ref C, imports.%C.decl [concrete = constants.%C]
|
|
// CHECK:STDOUT: %ptr.loc8: type = ptr_type %C.ref.loc8 [concrete = constants.%ptr.3a8]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %.loc8_37: %ptr.3a8 = acquire_value %global_ptr.ref
|
|
// CHECK:STDOUT: %local_ptr: %ptr.3a8 = value_binding local_ptr, %.loc8_37
|
|
// CHECK:STDOUT: name_binding_decl {
|
|
// CHECK:STDOUT: %local_ref.patt: %pattern_type.0d0 = value_binding_pattern local_ref [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %Cpp.ref.loc9_34: <namespace> = name_ref Cpp, imports.%Cpp [concrete = imports.%Cpp]
|
|
// CHECK:STDOUT: %global_ref.ref: ref %const = name_ref global_ref, imports.%global_ref.var [concrete = imports.%global_ref.var]
|
|
// CHECK:STDOUT: %.loc9_30: type = splice_block %ptr.loc9 [concrete = constants.%ptr.3a8] {
|
|
// CHECK:STDOUT: %Cpp.ref.loc9_25: <namespace> = name_ref Cpp, imports.%Cpp [concrete = imports.%Cpp]
|
|
// CHECK:STDOUT: %C.ref.loc9: type = name_ref C, imports.%C.decl [concrete = constants.%C]
|
|
// CHECK:STDOUT: %ptr.loc9: type = ptr_type %C.ref.loc9 [concrete = constants.%ptr.3a8]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %.loc9_37.1: ref %ptr.3a8 = as_compatible %global_ref.ref [concrete = constants.%global_ref.var]
|
|
// CHECK:STDOUT: %.loc9_37.2: ref %ptr.3a8 = converted %global_ref.ref, %.loc9_37.1 [concrete = constants.%global_ref.var]
|
|
// CHECK:STDOUT: %addr: %ptr.3a8 = addr_of imports.%global.var [concrete = constants.%addr]
|
|
// CHECK:STDOUT: %.loc9_37.3: %ptr.3a8 = acquire_value %.loc9_37.2 [concrete = constants.%addr]
|
|
// CHECK:STDOUT: %local_ref: %ptr.3a8 = value_binding local_ref, %.loc9_37.3
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: --- fail_import_unsupported_type.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %MyF.type: type = fn_type @MyF [concrete]
|
|
// CHECK:STDOUT: %MyF: %MyF.type = struct_value () [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: imports {
|
|
// CHECK:STDOUT: %Core: <namespace> = namespace file.%Core.import, [concrete] {
|
|
// CHECK:STDOUT: import Core//prelude
|
|
// CHECK:STDOUT: import Core//prelude/...
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %Cpp: <namespace> = namespace file.%Cpp.import_cpp, [concrete] {
|
|
// CHECK:STDOUT: .UnusupportedType = <error>
|
|
// CHECK:STDOUT: .global = <error>
|
|
// CHECK:STDOUT: import Cpp//...
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace [concrete] {
|
|
// CHECK:STDOUT: .Core = imports.%Core
|
|
// CHECK:STDOUT: .Cpp = imports.%Cpp
|
|
// CHECK:STDOUT: .MyF = %MyF.decl
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %Core.import = import Core
|
|
// CHECK:STDOUT: %Cpp.import_cpp = import_cpp {
|
|
// CHECK:STDOUT: import Cpp "unsupported_type.h"
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %MyF.decl: %MyF.type = fn_decl @MyF [concrete = constants.%MyF] {} {}
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @MyF() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: name_binding_decl {
|
|
// CHECK:STDOUT: %local.patt: <error> = value_binding_pattern local [concrete]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %Cpp.ref.loc22_44: <namespace> = name_ref Cpp, imports.%Cpp [concrete = imports.%Cpp]
|
|
// CHECK:STDOUT: %global.ref: <error> = name_ref global, <error> [concrete = <error>]
|
|
// CHECK:STDOUT: %.1: <error> = splice_block <error> [concrete = <error>] {
|
|
// CHECK:STDOUT: %Cpp.ref.loc22_21: <namespace> = name_ref Cpp, imports.%Cpp [concrete = imports.%Cpp]
|
|
// CHECK:STDOUT: %UnusupportedType.ref: <error> = name_ref UnusupportedType, <error> [concrete = <error>]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT: %local: <error> = value_binding local, <error> [concrete = <error>]
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|