mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Disables three new warnings because they lean more towards style conflicts than fixes. I've brought these up on #style. Other than that, mostly fixing basic issues, and things that clang-tidy-20 seems to fire where clang-tiday-16 didn't. One particular curious case is `llvm::StringLiteral::data()` uses, which are flagged as not strictly null-terminated; I'm switching to `const char*` in those spots which matches `llvm::formatv`'s format argument, but feels worse. I'm removing `run_clang_tidy.py` here because I'm observing it give fewer warnings than `bazel build --config=clang-tidy -k //toolchain/...`. The latter matches how we enforce in GitHub actions (and also caches results, and suppresses output for files that have no issues), so I'm dropping the bespoke script.
165 lines
6.0 KiB
C++
165 lines
6.0 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include <benchmark/benchmark.h>
|
|
|
|
#include <string>
|
|
|
|
#include "testing/base/global_exe_path.h"
|
|
#include "testing/base/source_gen.h"
|
|
#include "toolchain/driver/driver.h"
|
|
#include "toolchain/install/install_paths_test_helpers.h"
|
|
#include "toolchain/testing/compile_helper.h"
|
|
|
|
namespace Carbon::Testing {
|
|
namespace {
|
|
|
|
// Helper used to benchmark compilation across different phases.
|
|
//
|
|
// Handles setting up the compiler's driver, locating the prelude, and managing
|
|
// a VFS in which the compilations occur.
|
|
class CompileBenchmark {
|
|
public:
|
|
CompileBenchmark()
|
|
: installation_(InstallPaths::MakeForBazelRunfiles(GetExePath())),
|
|
driver_(fs_, &installation_, llvm::outs(), llvm::errs()) {
|
|
AddPreludeFilesToVfs(installation_, fs_);
|
|
}
|
|
|
|
// Setup a set of source files in the VFS for the driver. Each string input is
|
|
// materialized into a virtual file and a list of the virtual filenames is
|
|
// returned.
|
|
auto SetUpFiles(llvm::ArrayRef<std::string> sources)
|
|
-> llvm::OwningArrayRef<std::string> {
|
|
llvm::OwningArrayRef<std::string> file_names(sources.size());
|
|
for (ssize_t i : llvm::seq<ssize_t>(sources.size())) {
|
|
file_names[i] = llvm::formatv("file_{0}.carbon", i).str();
|
|
fs_->addFile(file_names[i], /*ModificationTime=*/0,
|
|
llvm::MemoryBuffer::getMemBuffer(sources[i]));
|
|
}
|
|
return file_names;
|
|
}
|
|
|
|
auto driver() -> Driver& { return driver_; }
|
|
auto gen() -> SourceGen& { return gen_; }
|
|
|
|
private:
|
|
llvm::IntrusiveRefCntPtr<llvm::vfs::InMemoryFileSystem> fs_ =
|
|
new llvm::vfs::InMemoryFileSystem;
|
|
const InstallPaths installation_;
|
|
Driver driver_;
|
|
|
|
SourceGen gen_;
|
|
};
|
|
|
|
// An enumerator used to select compilation phases to benchmark.
|
|
enum class Phase : uint8_t {
|
|
Lex,
|
|
Parse,
|
|
Check,
|
|
};
|
|
|
|
// Maps the enumerator for a compilation phase into a specific `compile` command
|
|
// line flag.
|
|
static auto PhaseFlag(Phase phase) -> llvm::StringRef {
|
|
switch (phase) {
|
|
case Phase::Lex:
|
|
return "--phase=lex";
|
|
case Phase::Parse:
|
|
return "--phase=parse";
|
|
case Phase::Check:
|
|
return "--phase=check";
|
|
}
|
|
}
|
|
|
|
// Benchmark on multiple files of the same size but with different source code
|
|
// in order to avoid branch prediction perfectly learning a particular file's
|
|
// structure and shape, and to get closer to a cache-cold benchmark number which
|
|
// is what we generally expect to care about in practice. We enforce an upper
|
|
// bound to avoid excessive benchmark time and a lower bound to avoid anchoring
|
|
// on a single source file that may have unrepresentative content.
|
|
//
|
|
// For simplicity, we compute a number of files from the target line count as a
|
|
// heuristic.
|
|
static auto ComputeFileCount(int target_lines) -> int {
|
|
#ifndef NDEBUG
|
|
// Use a smaller number of files in debug builds where compiles are slower.
|
|
return std::max(1, std::min(8, (1024 * 1024) / target_lines));
|
|
#else
|
|
return std::max(8, std::min(1024, (1024 * 1024) / target_lines));
|
|
#endif
|
|
}
|
|
|
|
template <Phase P>
|
|
static auto BM_CompileAPIFileDenseDecls(benchmark::State& state) -> void {
|
|
CompileBenchmark bench;
|
|
int target_lines = state.range(0);
|
|
int num_files = ComputeFileCount(target_lines);
|
|
llvm::OwningArrayRef<std::string> sources(num_files);
|
|
|
|
// Create a collection of random source files. Compute average statistics for
|
|
// counters for compilation speed.
|
|
CompileHelper compile_helper;
|
|
double total_bytes = 0.0;
|
|
double total_tokens = 0.0;
|
|
double total_lines = 0.0;
|
|
for (std::string& source : sources) {
|
|
source = bench.gen().GenAPIFileDenseDecls(target_lines,
|
|
SourceGen::DenseDeclParams{});
|
|
total_bytes += source.size();
|
|
total_tokens += compile_helper.GetTokenizedBuffer(source).size();
|
|
total_lines += llvm::count(source, '\n');
|
|
};
|
|
state.counters["Bytes"] =
|
|
benchmark::Counter(total_bytes / sources.size(),
|
|
benchmark::Counter::kIsIterationInvariantRate);
|
|
state.counters["Tokens"] =
|
|
benchmark::Counter(total_tokens / sources.size(),
|
|
benchmark::Counter::kIsIterationInvariantRate);
|
|
state.counters["Lines"] =
|
|
benchmark::Counter(total_lines / sources.size(),
|
|
benchmark::Counter::kIsIterationInvariantRate);
|
|
|
|
// Set up the sources as files for compilation.
|
|
llvm::OwningArrayRef<std::string> file_names = bench.SetUpFiles(sources);
|
|
CARBON_CHECK(static_cast<int>(file_names.size()) == num_files);
|
|
|
|
// We benchmark in batches of files to avoid benchmarking any peculiarities of
|
|
// a single file.
|
|
while (state.KeepRunningBatch(num_files)) {
|
|
for (ssize_t i = 0; i < num_files;) {
|
|
// We block optimizing `i` as that has proven both more effective at
|
|
// blocking the loop from being optimized away and avoiding disruption of
|
|
// the generated code that we're benchmarking.
|
|
benchmark::DoNotOptimize(i);
|
|
|
|
bool success = bench.driver()
|
|
.RunCommand({"compile", PhaseFlag(P), file_names[i]})
|
|
.success;
|
|
CARBON_DCHECK(success);
|
|
|
|
// We use the compilation success to step through the file names,
|
|
// establishing a dependency between each lookup. This doesn't fully allow
|
|
// us to measure latency rather than throughput, but minimizes any skew in
|
|
// measurements from speculating the start of the next compilation.
|
|
i += static_cast<ssize_t>(success);
|
|
}
|
|
}
|
|
}
|
|
|
|
// Benchmark from 256-line test cases through 256k line test cases, and for each
|
|
// phase of compilation.
|
|
BENCHMARK(BM_CompileAPIFileDenseDecls<Phase::Lex>)
|
|
->RangeMultiplier(4)
|
|
->Range(256, static_cast<int64_t>(256 * 1024));
|
|
BENCHMARK(BM_CompileAPIFileDenseDecls<Phase::Parse>)
|
|
->RangeMultiplier(4)
|
|
->Range(256, static_cast<int64_t>(256 * 1024));
|
|
BENCHMARK(BM_CompileAPIFileDenseDecls<Phase::Check>)
|
|
->RangeMultiplier(4)
|
|
->Range(256, static_cast<int64_t>(256 * 1024));
|
|
|
|
} // namespace
|
|
} // namespace Carbon::Testing
|