mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 21:10:12 +01:00
Chandler Carruth
d010d52f37
As part of this, move functions that seem reasonable to make out-of-line to a separate `_impl.h` header file that is only included where the explicit instantiation _definition_ is provided. By using explicit instantiation we can make these templates behave more like non-template classes in terms of supporting out-of-line definitions that don't need to be compiled by every translation unit. The set of eventual instantiations here is fundamentally known, and there tend to be headers that define a canonical "leaf" type where it makes sense to trigger the explicit instantiation. Where we already had a `.cpp` file to put the explicit instantiation definition, use it. But in some places we didn't have such a `.cpp` file so this PR adds those. This also requires that we have precise constraints on APIs that _can't_ be instantiated for specific argument types, as now we don't do this lazily. Combined, this appears to reduce the sum of object file sizes in the `check` directory by almost 40% (122mb -> 74mb) in my measurement. My actual goal was to improve compile times, but so far I don't have a great methodology for measuring these... But the object file size reduction seems to confirm this is a net win and likely represents a non-trivial improvement in compile time. Assisted-by: Antigravity with Gemini
51 lines
1.7 KiB
C++
51 lines
1.7 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_SEM_IR_SPECIFIC_INTERFACE_H_
|
|
#define CARBON_TOOLCHAIN_SEM_IR_SPECIFIC_INTERFACE_H_
|
|
|
|
#include "toolchain/base/canonical_value_store.h"
|
|
#include "toolchain/sem_ir/ids.h"
|
|
|
|
namespace Carbon::SemIR {
|
|
|
|
// A pair of an interface and a specific for that interface.
|
|
struct SpecificInterface {
|
|
using DiagnosticType = Diagnostics::TypeInfo<std::string>;
|
|
|
|
static const SpecificInterface None;
|
|
|
|
InterfaceId interface_id;
|
|
SpecificId specific_id;
|
|
|
|
friend auto operator<<(llvm::raw_ostream& out, SpecificInterface si)
|
|
-> llvm::raw_ostream& {
|
|
out << "{interface_id: " << si.interface_id
|
|
<< ", specific_id: " << si.specific_id << "}";
|
|
return out;
|
|
}
|
|
|
|
friend auto operator==(const SpecificInterface& lhs,
|
|
const SpecificInterface& rhs) -> bool = default;
|
|
};
|
|
|
|
inline constexpr SpecificInterface SpecificInterface::None = {
|
|
.interface_id = InterfaceId::None, .specific_id = SpecificId::None};
|
|
|
|
using SpecificInterfaceStore =
|
|
CanonicalValueStore<SpecificInterfaceId, SpecificInterface, Tag<CheckIRId>>;
|
|
|
|
} // namespace Carbon::SemIR
|
|
|
|
namespace Carbon {
|
|
extern template class CanonicalValueStore<SemIR::SpecificInterfaceId,
|
|
SemIR::SpecificInterface,
|
|
Tag<SemIR::CheckIRId>>;
|
|
extern template class ValueStore<SemIR::SpecificInterfaceId,
|
|
SemIR::SpecificInterface,
|
|
Tag<SemIR::CheckIRId>>;
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_TOOLCHAIN_SEM_IR_SPECIFIC_INTERFACE_H_
|