mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 21:00:13 +01:00
Adds a unit test, and some smaller edits: - Remove the `=` when defining names, in order to change `}` placement by clang-format on uses. - context: https://github.com/carbon-language/carbon-lang/pull/6053#discussion_r2343423178 - I believe with `EnumBase` that keeping the `=` had been a deliberate choice, so this PR is intended to confirm that removing it is okay. - Delete `EnumMaskBase::name` - context: https://github.com/carbon-language/carbon-lang/pull/6053#discussion_r2344233707 - We can't just do nothing because `EnumBase::name` uses indexing that's incompatible with `EnumMaskBase`. - Some small comment cleanups. - Tests don't need to be in the `Carbon` namespace anymore, macros work fine in other namespaces, but it's still the right namespace. - Documentation on `EnumBase::name` seems to be referring to a prior structure, wherein we had a macro defining the function instead of the `Names` array. --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk>
152 lines
5.6 KiB
C++
152 lines
5.6 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_COMMON_ENUM_MASK_BASE_H_
|
|
#define CARBON_COMMON_ENUM_MASK_BASE_H_
|
|
|
|
#include <bit>
|
|
|
|
#include "common/enum_base.h"
|
|
#include "llvm/ADT/StringExtras.h"
|
|
|
|
namespace Carbon::Internal {
|
|
|
|
// CRTP-style base class similar to `EnumBase`, but supporting mask enums.
|
|
// Enumerator values are consecutive bit shifts (1 << 0, 1 << 1, 1 << 2, 1 << 3,
|
|
// ...).
|
|
//
|
|
// Users must be in the `Carbon` namespace and should look like the following.
|
|
//
|
|
// In `my_kind.h`:
|
|
// ```
|
|
// #define CARBON_MY_KIND(X) \
|
|
// X(Enumerator1) \
|
|
// X(Enumerator2) \
|
|
// X(Enumerator3) \
|
|
// ...
|
|
//
|
|
// CARBON_DEFINE_RAW_ENUM_MASK(MyKind, uint32_t) {
|
|
// CARBON_MY_KIND(CARBON_RAW_ENUM_MASK_ENUMERATOR)
|
|
// };
|
|
//
|
|
// class MyKind : public CARBON_ENUM_MASK_BASE(MyKind) {
|
|
// public:
|
|
// CARBON_MY_KIND(CARBON_ENUM_MASK_CONSTANT_DECL)
|
|
//
|
|
// // Plus, anything else you wish to include.
|
|
// };
|
|
//
|
|
// #define CARBON_MY_KIND_WITH_TYPE(X) \
|
|
// CARBON_ENUM_MASK_CONSTANT_DEFINITION(MyKind, X)
|
|
// CARBON_MY_KIND(CARBON_MY_KIND_WITH_TYPE)
|
|
// #undef CARBON_MY_KIND_WITH_TYPE
|
|
// ```
|
|
//
|
|
// In `my_kind.cpp`:
|
|
// ```
|
|
// CARBON_DEFINE_ENUM_MASK_NAMES(MyKind) {
|
|
// CARBON_MY_KIND(CARBON_ENUM_MASK_NAME_STRING)
|
|
// };
|
|
// ```
|
|
template <typename DerivedT, typename EnumT, const llvm::StringLiteral Names[]>
|
|
class EnumMaskBase : public EnumBase<DerivedT, EnumT, Names> {
|
|
public:
|
|
// Provide a standard `None`.
|
|
//
|
|
// This uses a `&` to trigger slightly different instantiation behaviors in
|
|
// Clang. For context on why this is needed, see http://wg21.link/CWG2800.
|
|
// NOLINTNEXTLINE(readability-identifier-naming)
|
|
static const DerivedT& None;
|
|
|
|
// Returns true if there's a non-empty set intersection.
|
|
constexpr auto HasAnyOf(DerivedT other) const -> bool {
|
|
return !(*this & other).empty();
|
|
}
|
|
|
|
// Adds entries to the mask.
|
|
auto Add(DerivedT other) -> void { *this = *this | other; }
|
|
|
|
// Removes entries from the mask.
|
|
auto Remove(DerivedT other) -> void { *this = *this & ~other; }
|
|
|
|
constexpr auto empty() const -> bool { return this->AsInt() == 0; }
|
|
|
|
constexpr auto operator|(DerivedT other) const -> DerivedT {
|
|
return DerivedT::FromInt(this->AsInt() | other.AsInt());
|
|
}
|
|
|
|
constexpr auto operator&(DerivedT other) const -> DerivedT {
|
|
return DerivedT::FromInt(this->AsInt() & other.AsInt());
|
|
}
|
|
|
|
constexpr auto operator~() const -> DerivedT {
|
|
return DerivedT::FromInt(~this->AsInt());
|
|
}
|
|
|
|
// Use `Print` for mask entries. This hides `EnumBase::name`; it's not
|
|
// compatible with `EnumMaskBase`.
|
|
auto name() const -> llvm::StringRef = delete;
|
|
|
|
// Prints this value as a `|`-separated list of mask entries, or `None`.
|
|
//
|
|
// This shadows EnumBase::Print.
|
|
auto Print(llvm::raw_ostream& out) const -> void {
|
|
int value = this->AsInt();
|
|
if (value == 0) {
|
|
out << "None";
|
|
return;
|
|
}
|
|
llvm::ListSeparator sep("|");
|
|
for (int bit = 0; value != 0; value >>= 1, ++bit) {
|
|
if (value & 1) {
|
|
out << sep << Names[bit];
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
template <typename DerivedT, typename EnumT, const llvm::StringLiteral Names[]>
|
|
constexpr const DerivedT& EnumMaskBase<DerivedT, EnumT, Names>::None =
|
|
DerivedT::FromInt(0);
|
|
|
|
} // namespace Carbon::Internal
|
|
|
|
// Use this before defining a class that derives from `EnumMaskBase` to begin
|
|
// the definition of the raw `enum class`. It should be followed by the body of
|
|
// that raw enum class.
|
|
#define CARBON_DEFINE_RAW_ENUM_MASK(EnumMaskName, UnderlyingType) \
|
|
namespace Internal { \
|
|
struct EnumMaskName##Data { \
|
|
static const llvm::StringLiteral Names[]; \
|
|
/* For bit shifts, track the initial counter value. This will increment on \
|
|
* each enum entry. */ \
|
|
static constexpr uint64_t BitShiftCounter = __COUNTER__ + 1; \
|
|
enum class RawEnum : UnderlyingType; \
|
|
}; \
|
|
} \
|
|
enum class Internal::EnumMaskName##Data::RawEnum : UnderlyingType
|
|
|
|
// In the `CARBON_DEFINE_RAW_ENUM_MASK` block, use this to generate each
|
|
// enumerator.
|
|
#define CARBON_RAW_ENUM_MASK_ENUMERATOR(Name) \
|
|
Name = 1 << (__COUNTER__ - BitShiftCounter),
|
|
|
|
// Use this to compute the `Internal::EnumMaskBase` specialization for a Carbon
|
|
// enum mask. It both computes the name of the raw enum and ensures all the
|
|
// namespaces are correct.
|
|
#define CARBON_ENUM_MASK_BASE(EnumMaskName) \
|
|
::Carbon::Internal::EnumMaskBase<EnumMaskName, \
|
|
Internal::EnumMaskName##Data::RawEnum, \
|
|
Internal::EnumMaskName##Data::Names>
|
|
|
|
// Constants and names are declared equivalently as to `EnumBase`.
|
|
#define CARBON_ENUM_MASK_CONSTANT_DECL(Name) CARBON_ENUM_CONSTANT_DECL(Name)
|
|
#define CARBON_ENUM_MASK_CONSTANT_DEFINITION(EnumMaskName, Name) \
|
|
CARBON_ENUM_CONSTANT_DEFINITION(EnumMaskName, Name)
|
|
#define CARBON_DEFINE_ENUM_MASK_NAMES(EnumMaskName) \
|
|
CARBON_DEFINE_ENUM_CLASS_NAMES(EnumMaskName)
|
|
#define CARBON_ENUM_MASK_NAME_STRING(Name) CARBON_ENUM_CLASS_NAME_STRING(Name)
|
|
|
|
#endif // CARBON_COMMON_ENUM_MASK_BASE_H_
|