mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 09:38:10 +00:00
This was previously discussed at https://discord.com/channels/655572317891461132/655578254970716160/1209975051588210729. I'm initiating this mainly because we typically use "id" suffixes to indicate an `IdBase` being passed around and the non-id suffix of `parse_node` suggests at it carrying more data than it actually does. There used to be more reason for avoiding `node_id` because `SemIR::InstId` used to be named `NodeId`, but that's no longer necessary. As a consequence, I'd like to rename `parse_node` to more precisely reflect its type. In full, this is doing: ``` parse_node_kind -> node_kind parse_node -> node_id ParseNodeCategory -> NodeCategory ParseNodeKind -> NodeKind ParseNode -> NodeId ``` This is primarily in check and sem_ir, but with some `parse_node_kind` references in parse too. Pluralization is consistent with name forms on both sides, so that wasn't part of my replacements.
32 lines
1.3 KiB
C++
32 lines
1.3 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_CHECK_FUNCTION_H_
|
|
#define CARBON_TOOLCHAIN_CHECK_FUNCTION_H_
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/sem_ir/function.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
// Checks that `new_function_id` does not differ from `prev_function_id`.
|
|
// Prints a suitable diagnostic and returns false if not.
|
|
auto CheckFunctionRedecl(Context& context, SemIR::FunctionId new_function_id,
|
|
SemIR::FunctionId prev_function_id) -> bool;
|
|
|
|
// Tries to merge new_function into prev_function_id. Since new_function won't
|
|
// have a definition even if one is upcoming, set is_definition to indicate the
|
|
// planned result.
|
|
//
|
|
// If merging is successful, updates the FunctionId on new_function and returns
|
|
// true. Otherwise, returns false. Prints a diagnostic when appropriate.
|
|
auto MergeFunctionRedecl(Context& context, Parse::NodeId node_id,
|
|
SemIR::Function& new_function,
|
|
SemIR::FunctionId prev_function_id, bool is_definition)
|
|
-> bool;
|
|
|
|
} // namespace Carbon::Check
|
|
|
|
#endif // CARBON_TOOLCHAIN_CHECK_FUNCTION_H_
|