mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 15:11:05 +01:00
This fixes an issue with `constexpr` in ARM builds. The table needs to be a _`static`_ `constexpr` in order to be used w/o capture in the lambda. This was reported with an alternative fix in #3164 -- this fix avoids adding captures to the lambda by fixing the `constexpr` declaration. The name is tweaked and parentheses added to try to keep `clang-format` producing a nice formatting for this weird construct. Without these, I was getting distractingly bad results. The code path wasn't built outside of ARM, and so mostly showed up on ARM macOS builds -- in general, we don't currently have non-x86 GitHub CI to catch this kind of issue. Sorry for folks who bumped into it! I'm planning a subsequent PR that will refactor code so that we have more common code in the fallback and reduce our exposure to single-platform build issues like this.
Toolchain
A design is currently maintained in Google Drive. It'll be migrated to markdown once we are confident in its stability.