mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-27 08:00:09 +01:00
Jon Ross-Perkins
cb4686bf21
Pursuant to discussion regarding #4699, turn on `misc-non-private-member-variables-in-classes` using the `IgnoreClassesWithAllMemberVariablesBeingPublic` flag (the check treats structs as classes, so we need this for structs with all-public members). Updates the style guide notes to match, which should be pretty minor due to the scoping of test fixtures. Also fixes some underscore uses in test files on the way. Basically this is keeping the style for [class data member naming](https://google.github.io/styleguide/cppguide.html#Variable_Names) even while making them public.
83 lines
3.0 KiB
C++
83 lines
3.0 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/diagnostics/diagnostic_emitter.h"
|
|
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "llvm/ADT/StringRef.h"
|
|
#include "toolchain/diagnostics/mocks.h"
|
|
|
|
namespace Carbon::Testing {
|
|
namespace {
|
|
|
|
using ::Carbon::Testing::IsDiagnostic;
|
|
using ::Carbon::Testing::IsSingleDiagnostic;
|
|
using testing::ElementsAre;
|
|
|
|
struct FakeDiagnosticConverter : DiagnosticConverter<int> {
|
|
auto ConvertLoc(int n, ContextFnT /*context_fn*/) const
|
|
-> DiagnosticLoc override {
|
|
return {.line_number = 1, .column_number = n};
|
|
}
|
|
};
|
|
|
|
class DiagnosticEmitterTest : public ::testing::Test {
|
|
public:
|
|
DiagnosticEmitterTest() : emitter_(converter_, consumer_) {}
|
|
|
|
FakeDiagnosticConverter converter_;
|
|
Testing::MockDiagnosticConsumer consumer_;
|
|
DiagnosticEmitter<int> emitter_;
|
|
};
|
|
|
|
TEST_F(DiagnosticEmitterTest, EmitSimpleError) {
|
|
CARBON_DIAGNOSTIC(TestDiagnostic, Error, "simple error");
|
|
EXPECT_CALL(consumer_, HandleDiagnostic(IsSingleDiagnostic(
|
|
DiagnosticKind::TestDiagnostic,
|
|
DiagnosticLevel::Error, 1, 1, "simple error")));
|
|
EXPECT_CALL(consumer_, HandleDiagnostic(IsSingleDiagnostic(
|
|
DiagnosticKind::TestDiagnostic,
|
|
DiagnosticLevel::Error, 1, 2, "simple error")));
|
|
emitter_.Emit(1, TestDiagnostic);
|
|
emitter_.Emit(2, TestDiagnostic);
|
|
}
|
|
|
|
TEST_F(DiagnosticEmitterTest, EmitSimpleWarning) {
|
|
CARBON_DIAGNOSTIC(TestDiagnostic, Warning, "simple warning");
|
|
EXPECT_CALL(consumer_,
|
|
HandleDiagnostic(IsSingleDiagnostic(
|
|
DiagnosticKind::TestDiagnostic, DiagnosticLevel::Warning, 1,
|
|
1, "simple warning")));
|
|
emitter_.Emit(1, TestDiagnostic);
|
|
}
|
|
|
|
TEST_F(DiagnosticEmitterTest, EmitOneArgDiagnostic) {
|
|
CARBON_DIAGNOSTIC(TestDiagnostic, Error, "arg: `{0}`", std::string);
|
|
EXPECT_CALL(consumer_, HandleDiagnostic(IsSingleDiagnostic(
|
|
DiagnosticKind::TestDiagnostic,
|
|
DiagnosticLevel::Error, 1, 1, "arg: `str`")));
|
|
emitter_.Emit(1, TestDiagnostic, "str");
|
|
}
|
|
|
|
TEST_F(DiagnosticEmitterTest, EmitNote) {
|
|
CARBON_DIAGNOSTIC(TestDiagnostic, Warning, "simple warning");
|
|
CARBON_DIAGNOSTIC(TestDiagnosticNote, Note, "note");
|
|
EXPECT_CALL(
|
|
consumer_,
|
|
HandleDiagnostic(IsDiagnostic(
|
|
DiagnosticLevel::Warning,
|
|
ElementsAre(
|
|
IsDiagnosticMessage(DiagnosticKind::TestDiagnostic,
|
|
DiagnosticLevel::Warning, 1, 1,
|
|
"simple warning"),
|
|
IsDiagnosticMessage(DiagnosticKind::TestDiagnosticNote,
|
|
DiagnosticLevel::Note, 1, 2, "note")))));
|
|
emitter_.Build(1, TestDiagnostic).Note(2, TestDiagnosticNote).Emit();
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon::Testing
|