mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-27 22:02:33 +01:00
4845f40dff
This switches `DCHECK` and `FATAL` as well. The goal is to reduce the code size impact of these assertions so that we can keep more of them enabled. Currently, the largest cost I see from `CHECK` is not the actual check or the cold code itself, but actually the failure to inline trivial functions due to the presence of the cold code. This means that our goal isn't to reduce apparent code size in the final binary but the LLVM IR cost assessed for these routines in the inliner, which closely correlates with code size but is a bit different. As discussed in #4283, experimentation shows that a single function call with a minimal number of arguments is the lowest cost model for these. This is easily achieved with a format-string API that internally uses `llvm::formatv`. This PR is essentially the `CHECK` version of #4283. However, the check macros are substantially harder to make work with both format strings and streaming because they also take a condition. Also, unexpectedly, I was very successful at devising a regular expression based automated rewrite from the streaming to the format string form with only low 10s of manual fixes. This includes compacting strings broken up across lines, etc. Given how well that went, I've prepared this PR which just directly switches to the format string API and migrate everything to use it. One nice side-effect is that the format string approach ends up greatly simplifying the implementation here as well. This is ... *shockingly* effective. Parsing speeds up by more than 3% with just this change. And checking speeds up by **8%** with this change alone: ``` BM_CompileAPIFileDenseDecls<Phase::Parse>/256 86.3µs ± 1% 82.9µs ± 1% -3.94% (p=0.000 n=17+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/1024 431µs ± 1% 415µs ± 1% -3.76% (p=0.000 n=18+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/4096 1.77ms ± 1% 1.71ms ± 1% -3.18% (p=0.000 n=18+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/16384 7.44ms ± 1% 7.17ms ± 2% -3.56% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Parse>/65536 30.7ms ± 1% 29.7ms ± 1% -3.15% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Parse>/262144 131ms ± 1% 127ms ± 1% -2.81% (p=0.000 n=18+18) BM_CompileAPIFileDenseDecls<Phase::Check>/256 878µs ± 2% 800µs ± 1% -8.91% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/1024 1.88ms ± 2% 1.72ms ± 1% -8.56% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/4096 5.78ms ± 2% 5.28ms ± 1% -8.70% (p=0.000 n=20+18) BM_CompileAPIFileDenseDecls<Phase::Check>/16384 21.9ms ± 1% 20.1ms ± 1% -8.02% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Check>/65536 90.4ms ± 2% 83.1ms ± 1% -8.04% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/262144 381ms ± 2% 352ms ± 1% -7.79% (p=0.000 n=19+19) ``` --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk> Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
106 lines
3.4 KiB
C++
106 lines
3.4 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_EXPLORER_AST_IMPL_BINDING_H_
|
|
#define CARBON_EXPLORER_AST_IMPL_BINDING_H_
|
|
|
|
#include <map>
|
|
|
|
#include "common/check.h"
|
|
#include "common/ostream.h"
|
|
#include "explorer/ast/ast_node.h"
|
|
#include "explorer/ast/expression_category.h"
|
|
|
|
namespace Carbon {
|
|
|
|
class Value;
|
|
class Expression;
|
|
class GenericBinding;
|
|
|
|
// `ImplBinding` plays the role of the parameter for passing witness
|
|
// tables to a generic. However, unlike regular parameters
|
|
// (`BindingPattern`) there is no explicit syntax that corresponds to
|
|
// an `ImplBinding`, so they are not created during parsing. Instances
|
|
// of `ImplBinding` are created during type checking, when processing
|
|
// a type parameter (a `GenericBinding`), or an `impls` requirement in
|
|
// a `where` clause.
|
|
class ImplBinding : public AstNode {
|
|
public:
|
|
using ImplementsCarbonValueNode = void;
|
|
|
|
ImplBinding(SourceLocation source_loc,
|
|
Nonnull<const GenericBinding*> type_var,
|
|
std::optional<Nonnull<const Value*>> iface)
|
|
: AstNode(AstNodeKind::ImplBinding, source_loc),
|
|
type_var_(type_var),
|
|
iface_(iface) {}
|
|
|
|
explicit ImplBinding(CloneContext& context, const ImplBinding& other);
|
|
|
|
static auto classof(const AstNode* node) -> bool {
|
|
return InheritsFromImplBinding(node->kind());
|
|
}
|
|
void Print(llvm::raw_ostream& out) const override;
|
|
void PrintID(llvm::raw_ostream& out) const override;
|
|
|
|
// The binding for the type variable.
|
|
auto type_var() const -> Nonnull<const GenericBinding*> { return type_var_; }
|
|
// The constraint being implemented.
|
|
// TODO: Rename this to `constraint`.
|
|
auto interface() const -> Nonnull<const Value*> {
|
|
CARBON_CHECK(iface_, "interface has not been set yet");
|
|
return *iface_;
|
|
}
|
|
|
|
// Set the interface being implemented, if not set by the constructor. Should
|
|
// only be called by typechecking.
|
|
void set_interface(Nonnull<const Value*> iface) {
|
|
CARBON_CHECK(!iface_, "interface set twice");
|
|
iface_ = iface;
|
|
}
|
|
|
|
// Required for the ValueNode interface
|
|
auto constant_value() const -> std::optional<Nonnull<const Value*>> {
|
|
return std::nullopt;
|
|
}
|
|
auto symbolic_identity() const -> std::optional<Nonnull<const Value*>> {
|
|
return symbolic_identity_;
|
|
}
|
|
void set_symbolic_identity(Nonnull<const Value*> value) {
|
|
CARBON_CHECK(!symbolic_identity_.has_value());
|
|
symbolic_identity_ = value;
|
|
}
|
|
|
|
// These functions exist only so that an `ImplBinding` can be used as a
|
|
// `ValueNodeView` as a key in a `StaticScope`.
|
|
auto static_type() const -> const Value& {
|
|
CARBON_FATAL("an ImplBinding has no type");
|
|
}
|
|
auto expression_category() const -> ExpressionCategory {
|
|
return ExpressionCategory::Value;
|
|
}
|
|
|
|
// Return the original impl binding.
|
|
auto original() const -> Nonnull<const ImplBinding*> {
|
|
if (original_.has_value()) {
|
|
return *original_;
|
|
} else {
|
|
return this;
|
|
}
|
|
}
|
|
|
|
// Set the original impl binding.
|
|
void set_original(Nonnull<const ImplBinding*> orig) { original_ = orig; }
|
|
|
|
private:
|
|
Nonnull<const GenericBinding*> type_var_;
|
|
std::optional<Nonnull<const Value*>> iface_;
|
|
std::optional<Nonnull<const Value*>> symbolic_identity_;
|
|
std::optional<Nonnull<const ImplBinding*>> original_;
|
|
};
|
|
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_EXPLORER_AST_IMPL_BINDING_H_
|