mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-27 19:50:11 +01:00
This switches `DCHECK` and `FATAL` as well. The goal is to reduce the code size impact of these assertions so that we can keep more of them enabled. Currently, the largest cost I see from `CHECK` is not the actual check or the cold code itself, but actually the failure to inline trivial functions due to the presence of the cold code. This means that our goal isn't to reduce apparent code size in the final binary but the LLVM IR cost assessed for these routines in the inliner, which closely correlates with code size but is a bit different. As discussed in #4283, experimentation shows that a single function call with a minimal number of arguments is the lowest cost model for these. This is easily achieved with a format-string API that internally uses `llvm::formatv`. This PR is essentially the `CHECK` version of #4283. However, the check macros are substantially harder to make work with both format strings and streaming because they also take a condition. Also, unexpectedly, I was very successful at devising a regular expression based automated rewrite from the streaming to the format string form with only low 10s of manual fixes. This includes compacting strings broken up across lines, etc. Given how well that went, I've prepared this PR which just directly switches to the format string API and migrate everything to use it. One nice side-effect is that the format string approach ends up greatly simplifying the implementation here as well. This is ... *shockingly* effective. Parsing speeds up by more than 3% with just this change. And checking speeds up by **8%** with this change alone: ``` BM_CompileAPIFileDenseDecls<Phase::Parse>/256 86.3µs ± 1% 82.9µs ± 1% -3.94% (p=0.000 n=17+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/1024 431µs ± 1% 415µs ± 1% -3.76% (p=0.000 n=18+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/4096 1.77ms ± 1% 1.71ms ± 1% -3.18% (p=0.000 n=18+19) BM_CompileAPIFileDenseDecls<Phase::Parse>/16384 7.44ms ± 1% 7.17ms ± 2% -3.56% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Parse>/65536 30.7ms ± 1% 29.7ms ± 1% -3.15% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Parse>/262144 131ms ± 1% 127ms ± 1% -2.81% (p=0.000 n=18+18) BM_CompileAPIFileDenseDecls<Phase::Check>/256 878µs ± 2% 800µs ± 1% -8.91% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/1024 1.88ms ± 2% 1.72ms ± 1% -8.56% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/4096 5.78ms ± 2% 5.28ms ± 1% -8.70% (p=0.000 n=20+18) BM_CompileAPIFileDenseDecls<Phase::Check>/16384 21.9ms ± 1% 20.1ms ± 1% -8.02% (p=0.000 n=18+20) BM_CompileAPIFileDenseDecls<Phase::Check>/65536 90.4ms ± 2% 83.1ms ± 1% -8.04% (p=0.000 n=19+20) BM_CompileAPIFileDenseDecls<Phase::Check>/262144 381ms ± 2% 352ms ± 1% -7.79% (p=0.000 n=19+19) ``` --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk> Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
143 lines
5.1 KiB
C++
143 lines
5.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_EXPLORER_AST_ELEMENT_PATH_H_
|
|
#define CARBON_EXPLORER_AST_ELEMENT_PATH_H_
|
|
|
|
#include <algorithm>
|
|
#include <optional>
|
|
#include <string>
|
|
#include <string_view>
|
|
#include <vector>
|
|
|
|
#include "common/check.h"
|
|
#include "common/ostream.h"
|
|
#include "explorer/ast/element.h"
|
|
#include "explorer/ast/value_node.h"
|
|
#include "llvm/Support/Compiler.h"
|
|
|
|
namespace Carbon {
|
|
|
|
class InterfaceType;
|
|
class Witness;
|
|
|
|
// Given some initial Value, a ElementPath identifies a sub-Value within it,
|
|
// in much the same way that a file path identifies a file within some
|
|
// directory. FieldPaths are relative rather than absolute: the initial
|
|
// Value is specified by the context in which the ElementPath is used, not
|
|
// by the ElementPath itself.
|
|
//
|
|
// A ElementPath consists of a series of steps, which specify how to
|
|
// incrementally navigate from a Value to one of its fields. Currently
|
|
// there is only one kind of step, a string specifying a child field by name,
|
|
// but that may change as Carbon develops. Note that an empty ElementPath
|
|
// refers to the initial Value itself.
|
|
class ElementPath : public Printable<ElementPath> {
|
|
public:
|
|
// Constructs an empty ElementPath.
|
|
ElementPath() = default;
|
|
|
|
// A single component of the ElementPath, which is typically the name
|
|
// of a field. However, inside a generic, when there is a field
|
|
// access on something of a generic type, e.g., `T`, then we also
|
|
// need `witness`, a pointer to the witness table containing that field.
|
|
class Component : public Printable<Component> {
|
|
public:
|
|
explicit Component(Nonnull<const Element*> element) : element_(element) {}
|
|
Component(Nonnull<const Element*> element,
|
|
std::optional<Nonnull<const InterfaceType*>> interface,
|
|
std::optional<Nonnull<const Witness*>> witness)
|
|
: element_(element), interface_(interface), witness_(witness) {}
|
|
|
|
inline friend auto operator==(const Component& lhs, const Component& rhs)
|
|
-> bool {
|
|
return lhs.element_ == rhs.element_ && lhs.interface_ == rhs.interface_ &&
|
|
lhs.witness_ == rhs.witness_;
|
|
}
|
|
inline friend auto hash_value(const Component& component)
|
|
-> llvm::hash_code {
|
|
return llvm::hash_combine(component.element_, component.interface_,
|
|
component.witness_);
|
|
}
|
|
|
|
auto element() const -> Nonnull<const Element*> { return element_; }
|
|
|
|
auto IsNamed(std::string_view name) const -> bool {
|
|
return element_->IsNamed(name);
|
|
}
|
|
|
|
auto interface() const -> std::optional<Nonnull<const InterfaceType*>> {
|
|
return interface_;
|
|
}
|
|
|
|
auto witness() const -> std::optional<Nonnull<const Witness*>> {
|
|
return witness_;
|
|
}
|
|
|
|
void Print(llvm::raw_ostream& out) const { return element_->Print(out); }
|
|
|
|
private:
|
|
Nonnull<const Element*> element_;
|
|
std::optional<Nonnull<const InterfaceType*>> interface_;
|
|
std::optional<Nonnull<const Witness*>> witness_;
|
|
};
|
|
|
|
// Constructs a ElementPath consisting of a single step.
|
|
explicit ElementPath(Nonnull<const Element*> element)
|
|
: components_({Component(element)}) {}
|
|
explicit ElementPath(const Component& f) : components_({f}) {}
|
|
|
|
ElementPath(const ElementPath&) = default;
|
|
ElementPath(ElementPath&&) = default;
|
|
auto operator=(const ElementPath&) -> ElementPath& = default;
|
|
auto operator=(ElementPath&&) -> ElementPath& = default;
|
|
|
|
inline friend auto operator==(const ElementPath& lhs, const ElementPath& rhs)
|
|
-> bool {
|
|
return lhs.components_ == rhs.components_;
|
|
}
|
|
inline friend auto hash_value(const ElementPath& path) -> llvm::hash_code {
|
|
return llvm::hash_combine_range(path.components_.begin(),
|
|
path.components_.end());
|
|
}
|
|
|
|
// Returns whether *this is empty.
|
|
auto IsEmpty() const -> bool { return components_.empty(); }
|
|
|
|
// Appends `element` to the end of *this.
|
|
auto Append(Nonnull<const Element*> element) -> void {
|
|
components_.push_back(Component(element));
|
|
}
|
|
|
|
// Removes all trailing `BaseElement`s, errors if there are no base elements.
|
|
auto RemoveTrailingBaseElements() -> void {
|
|
CARBON_CHECK(!components_.empty() && components_.back().element()->kind() ==
|
|
ElementKind::BaseElement,
|
|
"No base elements to remove.");
|
|
const auto r_it = std::find_if(
|
|
components_.rbegin(), components_.rend(), [](const Component& c) {
|
|
return c.element()->kind() != ElementKind::BaseElement;
|
|
});
|
|
components_.erase(r_it.base(), components_.end());
|
|
}
|
|
|
|
void Print(llvm::raw_ostream& out) const {
|
|
for (const Component& component : components_) {
|
|
out << "." << component;
|
|
}
|
|
}
|
|
|
|
private:
|
|
// The representation of ElementPath describes how to locate a Value within
|
|
// another Value, so its implementation details are tied to the implementation
|
|
// details of Value.
|
|
friend class Value;
|
|
friend class Heap;
|
|
std::vector<Component> components_;
|
|
};
|
|
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_EXPLORER_AST_ELEMENT_PATH_H_
|