mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 18:55:01 +01:00
Jon Ross-Perkins
b9df8ca765
A lot of this is more boring "remove unused header", plus some other minor cleanups. I think the most significant changes were: - yaml_test_helpers.cpp is doing a switch on an unsigned int, comparing to enum values. - [bugprone-switch-missing-default-case](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/switch-missing-default-case.html) is unhappy with EnumBase, but correctly identified yaml_test_helpers.cpp, so I'm opting to address it rather than disabling it even though it needs NOLINT in several locations as a result, in addition to what I think are some low-value `default` cases. I'd be fine going the other way with this too and disabling it globally (I could see it being noisier in the explorer). - MarkInitializerFor swaps the argument names between the .h and .cpp. I think the .cpp had the order as intended. - There's a new-ish [performance-enum-size](https://clang.llvm.org/extra/clang-tidy/checks/performance/enum-size.html) which I'm basically treating as "add int8_t to enums". My main motivation here is to just clean up as many of these as I can so that I stop seeing them in vscode.
46 lines
1.7 KiB
C++
46 lines
1.7 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_DIAGNOSTICS_DIAGNOSTIC_KIND_H_
|
|
#define CARBON_TOOLCHAIN_DIAGNOSTICS_DIAGNOSTIC_KIND_H_
|
|
|
|
#include <cstdint>
|
|
|
|
#include "common/enum_base.h"
|
|
|
|
namespace Carbon {
|
|
|
|
// Although this currently fits into int8_t, it shouldn't be expected to
|
|
// long-term.
|
|
// NOLINTNEXTLINE(performance-enum-size)
|
|
CARBON_DEFINE_RAW_ENUM_CLASS(DiagnosticKind, uint16_t) {
|
|
#define CARBON_DIAGNOSTIC_KIND(Name) CARBON_RAW_ENUM_ENUMERATOR(Name)
|
|
#include "toolchain/diagnostics/diagnostic_kind.def"
|
|
};
|
|
|
|
// An enumeration of all diagnostics provided by the toolchain. Diagnostics must
|
|
// be added to diagnostic_kind.def, and defined locally to where they're
|
|
// used using the `DIAGNOSTIC` macro in diagnostic_emitter.h.
|
|
//
|
|
// Diagnostic definitions are decentralized because placing all diagnostic
|
|
// definitions centrally is expected to create a compilation bottleneck
|
|
// long-term, and we also see value to keeping diagnostic format strings close
|
|
// to the consuming code.
|
|
class DiagnosticKind : public CARBON_ENUM_BASE(DiagnosticKind) {
|
|
public:
|
|
#define CARBON_DIAGNOSTIC_KIND(Name) CARBON_ENUM_CONSTANT_DECLARATION(Name)
|
|
#include "toolchain/diagnostics/diagnostic_kind.def"
|
|
};
|
|
|
|
#define CARBON_DIAGNOSTIC_KIND(Name) \
|
|
CARBON_ENUM_CONSTANT_DEFINITION(DiagnosticKind, Name)
|
|
#include "toolchain/diagnostics/diagnostic_kind.def"
|
|
|
|
// We expect DiagnosticKind to fit into 2 bits.
|
|
static_assert(sizeof(DiagnosticKind) == 2, "DiagnosticKind includes padding!");
|
|
|
|
} // namespace Carbon
|
|
|
|
#endif // CARBON_TOOLCHAIN_DIAGNOSTICS_DIAGNOSTIC_KIND_H_
|