Files
carbon-lang/toolchain/check/testdata/index/tuple_element_access.carbon
T
Jon Ross-Perkins 91f0c23124 Provide diagnostic locations for imported namespaces. (#3640)
Building on #3636 which handles the general import case, add special
casing for namespaces. Namespaces can be combined cross-IR, so it's a
little more complex.

The implementation adds import_id to the Namespace instruction as a
reference to find the original using the normal structure. This is
achieved by moving the name_id to NameScope to free up space.

---

I considered a few alternatives...

I considered adding import_id to NameScope, but:

1. It's more consistent with things such as Function or Class that
provide name_id on the info object rather than the instruction.
2. I thought it more likely that there would be more NameScope cases
that might want a name_id rather than the import_id, since ImportRef
will typically be used.

I considered putting the import source (cross-ref IR id + inst id) on
the NameScope versus a separate ImportRef, which seems like the
strongest argument towards the NameScope approach because it removes an
instruction. That just felt inconsistent though, and the overhead of
instruction-per-imported-namespace should be low (theoretically few
namespaces should be used). Plus I feel a bit odd adding two
generally-unused ids to NameScope.

A specialized Namespace structure could also have been created to store
the import_id, but that would add an indirection to the NameScope.
2024-01-24 18:00:32 +00:00

51 lines
2.5 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// AUTOUPDATE
var a: (i32,) = (12,);
var b: (i32,) = a;
var c: i32 = b[0];
// CHECK:STDOUT: --- tuple_element_access.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: %.1: type = tuple_type (type) [template]
// CHECK:STDOUT: %.2: type = tuple_type (i32) [template]
// CHECK:STDOUT: %.3: i32 = int_literal 12 [template]
// CHECK:STDOUT: %.4: (i32,) = tuple_value (%.3) [template]
// CHECK:STDOUT: %.5: i32 = int_literal 0 [template]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace {.a = %a, .b = %b, .c = %c} [template]
// CHECK:STDOUT: %.loc7_13.1: (type,) = tuple_literal (i32)
// CHECK:STDOUT: %.loc7_13.2: type = converted %.loc7_13.1, constants.%.2 [template = constants.%.2]
// CHECK:STDOUT: %a.var: ref (i32,) = var a
// CHECK:STDOUT: %a: ref (i32,) = bind_name a, %a.var
// CHECK:STDOUT: %.loc7_18: i32 = int_literal 12 [template = constants.%.3]
// CHECK:STDOUT: %.loc7_21.1: (i32,) = tuple_literal (%.loc7_18)
// CHECK:STDOUT: %.loc7_21.2: init (i32,) = tuple_init (%.loc7_18) to %a.var [template = constants.%.4]
// CHECK:STDOUT: %.loc7_21.3: init (i32,) = converted %.loc7_21.1, %.loc7_21.2 [template = constants.%.4]
// CHECK:STDOUT: assign %a.var, %.loc7_21.3
// CHECK:STDOUT: %.loc8_13.1: (type,) = tuple_literal (i32)
// CHECK:STDOUT: %.loc8_13.2: type = converted %.loc8_13.1, constants.%.2 [template = constants.%.2]
// CHECK:STDOUT: %b.var: ref (i32,) = var b
// CHECK:STDOUT: %b: ref (i32,) = bind_name b, %b.var
// CHECK:STDOUT: %a.ref: ref (i32,) = name_ref a, %a
// CHECK:STDOUT: %.loc8_17.1: ref i32 = tuple_access %a.ref, element0
// CHECK:STDOUT: %.loc8_17.2: i32 = bind_value %.loc8_17.1
// CHECK:STDOUT: %.loc8_17.3: init (i32,) = tuple_init (%.loc8_17.2) to %b.var
// CHECK:STDOUT: %.loc8_17.4: init (i32,) = converted %a.ref, %.loc8_17.3
// CHECK:STDOUT: assign %b.var, %.loc8_17.4
// CHECK:STDOUT: %c.var: ref i32 = var c
// CHECK:STDOUT: %c: ref i32 = bind_name c, %c.var
// CHECK:STDOUT: %b.ref: ref (i32,) = name_ref b, %b
// CHECK:STDOUT: %.loc9_16: i32 = int_literal 0 [template = constants.%.5]
// CHECK:STDOUT: %.loc9_17.1: ref i32 = tuple_index %b.ref, %.loc9_16
// CHECK:STDOUT: %.loc9_17.2: i32 = bind_value %.loc9_17.1
// CHECK:STDOUT: assign %c.var, %.loc9_17.2
// CHECK:STDOUT: }
// CHECK:STDOUT: