mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-02 22:02:51 +01:00
In order to maintain diagnostic quality, add a mechanism to add notes to any diagnostics that are produced as part of initialization of function parameters. As suggested in review of #3205. In passing, fix the only caller of `ImplicitAsRequired` outside of the implementation of `Check::Context` to instead use `ConvertToValueExpressionOfType`. This causes some missing `value_binding` nodes to be added to the produced SemIR. Also fixed a matching bug in lowering where a bogus load was being added, that resulted in assertion failures when the checker bug was fixed. The warning `-Wnon-virtual-dtor` starts producing false-positive warnings after this change. Replace it with the fixed version, `-Wdelete-non-virtual-dtor`.