mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-21 04:26:45 +00:00
Fixes integer builtins to produce the correct values (and not CHECK-fail) when used on integer literals. Also adds impls to the prelude to use the new builtins to perform operations on integer literals. Perhaps most importantly, this allows directly initializing `i32` values with negative numbers, as the negation operation on integer literals now works. For testing I've added tests for use of literals with one operator in each class (addition, multiplication, ordering, bitwise, etc) for which there are distinct rules or overflow behavior, rather than exhaustively testing all the combinations. This is aimed at finding a good tradeoff between maintainability of the tests and thorough test coverage. Also fixes lowering of heterogeneous shifts and comparisons. These are currently disabled when one of the operands is an integer literal, but we may want to allow that when the integer literal operand has a known constant value.
90 lines
2.0 KiB
Plaintext
90 lines
2.0 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
package Core library "prelude/operators/bitwise";
|
|
|
|
import library "prelude/types/int_literal";
|
|
|
|
// Bit complement: `^a`.
|
|
interface BitComplement {
|
|
fn Op[self: Self]() -> Self;
|
|
}
|
|
|
|
// Bitwise AND: `a & b`.
|
|
interface BitAnd {
|
|
fn Op[self: Self](other: Self) -> Self;
|
|
}
|
|
|
|
// Bitwise AND with assignment: `a &= b`.
|
|
interface BitAndAssign {
|
|
fn Op[addr self: Self*](other: Self);
|
|
}
|
|
|
|
// Bitwise OR: `a | b`.
|
|
interface BitOr {
|
|
fn Op[self: Self](other: Self) -> Self;
|
|
}
|
|
|
|
// Bitwise OR with assignment: `a |= b`.
|
|
interface BitOrAssign {
|
|
fn Op[addr self: Self*](other: Self);
|
|
}
|
|
|
|
// Bitwise XOR: `a ^ b`.
|
|
interface BitXor {
|
|
fn Op[self: Self](other: Self) -> Self;
|
|
}
|
|
|
|
// Bitwise XOR with assignment: `a ^= b`.
|
|
interface BitXorAssign {
|
|
fn Op[addr self: Self*](other: Self);
|
|
}
|
|
|
|
// Left shift: `a << b`.
|
|
interface LeftShift {
|
|
fn Op[self: Self](other: Self) -> Self;
|
|
}
|
|
|
|
// Left shift with assignment: `a <<= b`.
|
|
interface LeftShiftAssign {
|
|
fn Op[addr self: Self*](other: Self);
|
|
}
|
|
|
|
// Right shift: `a >> b`.
|
|
interface RightShift {
|
|
fn Op[self: Self](other: Self) -> Self;
|
|
}
|
|
|
|
// Right shift with assignment: `a >>= b`.
|
|
interface RightShiftAssign {
|
|
fn Op[addr self: Self*](other: Self);
|
|
}
|
|
|
|
|
|
// Operations for IntLiteral. These need to be here because IntLiteral has no
|
|
// associated library of its own.
|
|
impl IntLiteral() as BitAnd {
|
|
fn Op[self: Self](other: Self) -> Self = "int.and";
|
|
}
|
|
|
|
impl IntLiteral() as BitComplement {
|
|
fn Op[self: Self]() -> Self = "int.complement";
|
|
}
|
|
|
|
impl IntLiteral() as BitOr {
|
|
fn Op[self: Self](other: Self) -> Self = "int.or";
|
|
}
|
|
|
|
impl IntLiteral() as BitXor {
|
|
fn Op[self: Self](other: Self) -> Self = "int.xor";
|
|
}
|
|
|
|
impl IntLiteral() as LeftShift {
|
|
fn Op[self: Self](other: Self) -> Self = "int.left_shift";
|
|
}
|
|
|
|
impl IntLiteral() as RightShift {
|
|
fn Op[self: Self](other: Self) -> Self = "int.right_shift";
|
|
}
|